Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.9.5, 1.9.9, 1.9.17
    • Fix Version/s: 1.9.18
    • Component/s: Language
    • Labels:
      None
    • Database:
      MySQL
    • Testing Instructions:
      Hide

      Testing difficulty: HARD (relies on an error thrown)

      1. Somehow, make Moodle cry and call print_error('zipfileserror') and print_error('cannotunzipfile')
      2. TEST: Make sure both strings are displayed as existing

      Show
      Testing difficulty: HARD (relies on an error thrown) 1. Somehow, make Moodle cry and call print_error('zipfileserror') and print_error('cannotunzipfile') 2. TEST: Make sure both strings are displayed as existing
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE
    • Pull from Repository:
    • Rank:
      7125

      Description

      If someone is using the zipfileserror language string, which is in some case used in eg Moodle 1.9.5 and 1.9.9, than you will notice that this language string is missing in the language file error.php.

      Fix:
      Just create an error.php file in your local language files and add the

      $string['zipfileserror'] = 'Could not create zip file!';

        Activity

        Hide
        Yevhenii Vlasenko added a comment -

        Patched

        Show
        Yevhenii Vlasenko added a comment - Patched
        Hide
        Koen Roggemans added a comment -

        Added David as a watcher - It should be checked if the problem exists in other versions aswell

        Show
        Koen Roggemans added a comment - Added David as a watcher - It should be checked if the problem exists in other versions aswell
        Hide
        David Mudrak added a comment -

        There are actually two problems. There is another missing string 'unzipfileserror' referenced by print_error() calls. I replaced these calls so they use the existing string 'cannotunzipfile' instead. And adding the string 'zipfileserror' as suggested by Yevhenii, thanks!

        This affects just Moodle 1.x. Moodle 2.x versions do not refer to the 'zipfileserror' string any more.

        Show
        David Mudrak added a comment - There are actually two problems. There is another missing string 'unzipfileserror' referenced by print_error() calls. I replaced these calls so they use the existing string 'cannotunzipfile' instead. And adding the string 'zipfileserror' as suggested by Yevhenii, thanks! This affects just Moodle 1.x. Moodle 2.x versions do not refer to the 'zipfileserror' string any more.
        Hide
        David Mudrak added a comment -

        Dear integrators.

        You know what I think about translating error messages. And I know what you think about accepting trivial improvements into this dying MOODLE_19_STABLE branch. However, I am hereby referring to the Moodle HQ Internal Policy Document No. 42, page 328, head II, paragraph 3 (also known as "No community memeber's patch left behind" act) and ask you for the review and eventual integration of this branch.

        With love, David.

        Show
        David Mudrak added a comment - Dear integrators. You know what I think about translating error messages. And I know what you think about accepting trivial improvements into this dying MOODLE_19_STABLE branch. However, I am hereby referring to the Moodle HQ Internal Policy Document No. 42, page 328, head II, paragraph 3 (also known as "No community memeber's patch left behind" act) and ask you for the review and eventual integration of this branch. With love, David.
        Hide
        Aparup Banerjee added a comment -

        The main moodle.git repository has just been updated (yesterday) with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Aparup Banerjee added a comment - The main moodle.git repository has just been updated (yesterday) with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Sam Hemelryk added a comment -

        Gets my +1 for integration, will leave in the sprint to gather votes/get integrated (sure it will)

        Show
        Sam Hemelryk added a comment - Gets my +1 for integration, will leave in the sprint to gather votes/get integrated (sure it will)
        Hide
        Dan Poltawski added a comment -

        Thanks, I have integrated this.

        Show
        Dan Poltawski added a comment - Thanks, I have integrated this.
        Hide
        Dan Poltawski added a comment -

        Looks good, thanks for the patches

        Show
        Dan Poltawski added a comment - Looks good, thanks for the patches
        Hide
        Dan Poltawski added a comment -

        Jolly good show!

        Your changes have made it into the Moodle release - its time to celebrate! I suggest a hot cup of English tea (with milk, no sugar) or a hoppy English ale.

        Tally-ho!

        Show
        Dan Poltawski added a comment - Jolly good show! Your changes have made it into the Moodle release - its time to celebrate! I suggest a hot cup of English tea (with milk, no sugar) or a hoppy English ale. Tally-ho!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: