Moodle
  1. Moodle
  2. MDL-24563

forum posts in messaging look bad

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: Forum, Messages
    • Labels:
      None
    • Database:
      Any
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Rank:
      24849

      Description

      Forum posts notifications are now routed through messaging. On the messaging pages they look bad. They're really large and include lots of not really necessary information.

      IMs include a footer in email notifications:

      ---------------------------------------------------------------------
      This email is a copy of a message sent to you at "My Moodle Site"

      The footer is in the emails but isn't displayed within the messaging UI. Perhaps we should do something similar with forum posts.

        Issue Links

          Activity

          Hide
          Mary Cooch added a comment -

          Yes - this is very confusing at the moment because I (as in the duplicated tracker issue MDL-24506) am finding that in my message history to one specific person I have also got several forum posts of me talking to a completely different person. Probably the forum is the same and it so happened that someone involved in that thread messaged me but other posts from other peopl e in that forum thread shouldnt be intruding in my history of messages between me and somebody else.

          Show
          Mary Cooch added a comment - Yes - this is very confusing at the moment because I (as in the duplicated tracker issue MDL-24506 ) am finding that in my message history to one specific person I have also got several forum posts of me talking to a completely different person. Probably the forum is the same and it so happened that someone involved in that thread messaged me but other posts from other peopl e in that forum thread shouldnt be intruding in my history of messages between me and somebody else.
          Hide
          Andrew Davis added a comment - - edited

          For discussion Im attaching a patch plus 2 screenshots. I've tried to reduce the screen real estate devoted to forum notifications within messaging and also make it clear that it isnt actually the human being sending that notification.

          I've made use of the smallmessage columns that were always there but not really used. Ive changed the popup message processor and the messaging screen to use small message while the email processor continues to use full message. That means you still get the full html forum notification emails as before.

          The popup notification is of course only displayed to users who have it configured. For those who don't use the popup processor messages that are emailed or sent out via Jabber continue to be marked as read immediately as they did previously.

          I've just greatly trimmed down the forum notification displayed within the messaging system. I've also worded it in the third person so its apparent the its not the person in question who actually sent this message.

          Note that in the screen shots the students name is actually "Student Sam".

          Show
          Andrew Davis added a comment - - edited For discussion Im attaching a patch plus 2 screenshots. I've tried to reduce the screen real estate devoted to forum notifications within messaging and also make it clear that it isnt actually the human being sending that notification. I've made use of the smallmessage columns that were always there but not really used. Ive changed the popup message processor and the messaging screen to use small message while the email processor continues to use full message. That means you still get the full html forum notification emails as before. The popup notification is of course only displayed to users who have it configured. For those who don't use the popup processor messages that are emailed or sent out via Jabber continue to be marked as read immediately as they did previously. I've just greatly trimmed down the forum notification displayed within the messaging system. I've also worded it in the third person so its apparent the its not the person in question who actually sent this message. Note that in the screen shots the students name is actually "Student Sam".
          Hide
          Helen Foster added a comment -

          Hi Andrew, thanks for your suggested solution with screenshots.

          How about providing a "See this post in context" link (e.g. http://moodle.org/mod/forum/discuss.php?d=159774#p699798 ) rather than a reply link, as I think users would normally need to read the post in the context of the discussion before deciding whether or not to reply.

          You mention that 'The popup notification is of course only displayed to users who have it configured.' This means that in your example User Admin has the checkbox subscribed forum posts popup window ticked and is also subscribed to the test forum, right? What happens when User Admin posts in the test forum? Will they receive a popup notification which appears as a message from User Admin?

          Show
          Helen Foster added a comment - Hi Andrew, thanks for your suggested solution with screenshots. How about providing a "See this post in context" link (e.g. http://moodle.org/mod/forum/discuss.php?d=159774#p699798 ) rather than a reply link, as I think users would normally need to read the post in the context of the discussion before deciding whether or not to reply. You mention that 'The popup notification is of course only displayed to users who have it configured.' This means that in your example User Admin has the checkbox subscribed forum posts popup window ticked and is also subscribed to the test forum, right? What happens when User Admin posts in the test forum? Will they receive a popup notification which appears as a message from User Admin?
          Hide
          Andrew Davis added a comment -

          Ive changed it over to a link to the post (like http://andrew.moodle.local/moodle/mod/forum/discuss.php?d=378#p1021) rather than a reply link. Not sure why I thought a reply link was a good idea.

          "You mention that 'The popup notification is of course only displayed to users who have it configured.' This means that in your example User Admin has the checkbox subscribed forum posts popup window ticked and is also subscribed to the test forum, right?"

          correct.

          "What happens when User Admin posts in the test forum? Will they receive a popup notification which appears as a message from User Admin?"

          Just tested this and it does look like you get notified of your own forum posts. That probably shouldnt be. I'll alter the forum cron code to exclude the posting user when its generating the notifications.

          Show
          Andrew Davis added a comment - Ive changed it over to a link to the post (like http://andrew.moodle.local/moodle/mod/forum/discuss.php?d=378#p1021 ) rather than a reply link. Not sure why I thought a reply link was a good idea. "You mention that 'The popup notification is of course only displayed to users who have it configured.' This means that in your example User Admin has the checkbox subscribed forum posts popup window ticked and is also subscribed to the test forum, right?" correct. "What happens when User Admin posts in the test forum? Will they receive a popup notification which appears as a message from User Admin?" Just tested this and it does look like you get notified of your own forum posts. That probably shouldnt be. I'll alter the forum cron code to exclude the posting user when its generating the notifications.
          Hide
          Helen Foster added a comment -

          Regarding notification of your own forum posts, regardless of how this is handled by the messaging system, I hope email copies of them continue, as this feature was appreciated in 1.9.

          Show
          Helen Foster added a comment - Regarding notification of your own forum posts, regardless of how this is handled by the messaging system, I hope email copies of them continue, as this feature was appreciated in 1.9.
          Hide
          Helen Foster added a comment -

          Just to note that on moodle.org I'm still getting forum posts made by me appearing as messages from other users.

          Show
          Helen Foster added a comment - Just to note that on moodle.org I'm still getting forum posts made by me appearing as messages from other users.
          Hide
          Andrew Davis added a comment -

          I've committed a bunch of changes. Forum notifications should be far less intrusive on /message/index.php than they are now. Still not perfect but better.

          Also, the popup processor now ignores messages that have the same user as the sender and recipient so you wont ever get popup notifications of your own forum posts. If you have email enabled you will still email notifications.

          I'm calling this particular task done although I think there's still more work to be done in this area. See http://docs.moodle.org/en/Development:Forum_notifications_as_messages for some suggestions of what that might be.

          Show
          Andrew Davis added a comment - I've committed a bunch of changes. Forum notifications should be far less intrusive on /message/index.php than they are now. Still not perfect but better. Also, the popup processor now ignores messages that have the same user as the sender and recipient so you wont ever get popup notifications of your own forum posts. If you have email enabled you will still email notifications. I'm calling this particular task done although I think there's still more work to be done in this area. See http://docs.moodle.org/en/Development:Forum_notifications_as_messages for some suggestions of what that might be.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: