Moodle
  1. Moodle
  2. MDL-24724

Course profile should include 'send message' link and email address

    Details

    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Rank:
      15147

      Description

      While testing MDLQA-455 I noticed that it is not possible to send a message to somebody from their course profile page.

      If you have access to the full profile you can view that and send a message, but some users don't have access to that page.

      It is still possible to send a message by going via the top-level navigation and going into Messaging and selecting course and user, but I think it should be possible directly from the course profile.

        Issue Links

          Activity

          Hide
          Helen Foster added a comment -

          Sam, thanks for your report.

          As well as a send message link, I think users' email addresses should be included in course profiles (when email address in profile is set to "Allow only other course members to see my email address" or "Allow everyone...") to enable course participants to communicate with each other easily.

          Comparing course profiles with full profiles, I notice country, city/town and first access are also missing from the course profile. On moodle.org it seems a shame that Moodlers can no longer view this information about their fellow course participants. Perhaps there should be a setting in User policies similar to hiddenuserfields for determining which user fields are displayed in course profiles?

          Adding Martin as a watcher, hoping for your comments and also that you can assign the issue appropriately.

          Show
          Helen Foster added a comment - Sam, thanks for your report. As well as a send message link, I think users' email addresses should be included in course profiles (when email address in profile is set to "Allow only other course members to see my email address" or "Allow everyone...") to enable course participants to communicate with each other easily. Comparing course profiles with full profiles, I notice country, city/town and first access are also missing from the course profile. On moodle.org it seems a shame that Moodlers can no longer view this information about their fellow course participants. Perhaps there should be a setting in User policies similar to hiddenuserfields for determining which user fields are displayed in course profiles? Adding Martin as a watcher, hoping for your comments and also that you can assign the issue appropriately.
          Hide
          Sam Marshall added a comment -

          In the absence of the setting Helen suggests, it would probably be sensible if ALL fields that are displayed on the full profile also display on the course profile, like in 1.9? At least without that setting, I don't really see the point of making course profile worse.

          Show
          Sam Marshall added a comment - In the absence of the setting Helen suggests, it would probably be sensible if ALL fields that are displayed on the full profile also display on the course profile, like in 1.9? At least without that setting, I don't really see the point of making course profile worse.
          Hide
          Helen Foster added a comment -

          Good point Sam, +1 for all fields being displayed on the course profile as an interim solution.

          Increasing priority because I think the course profile should really be fixed for 2.0.

          Show
          Helen Foster added a comment - Good point Sam, +1 for all fields being displayed on the course profile as an interim solution. Increasing priority because I think the course profile should really be fixed for 2.0.
          Hide
          Helen Foster added a comment -

          Thanks to Sam for agreeing to be assigned this issue.

          Martin, do you have any suggestions for the best possible solution?

          Show
          Helen Foster added a comment - Thanks to Sam for agreeing to be assigned this issue. Martin, do you have any suggestions for the best possible solution?
          Hide
          Mary Cooch added a comment -

          Just to say I am very much in agreement with this too!

          Show
          Mary Cooch added a comment - Just to say I am very much in agreement with this too!
          Hide
          Joseph Rézeau added a comment -

          +1 for me too

          Show
          Joseph Rézeau added a comment - +1 for me too
          Hide
          Andrew Davis added a comment -

          Linking related issue. Should have looked harder for an existing issue before opening a new one.

          Show
          Andrew Davis added a comment - Linking related issue. Should have looked harder for an existing issue before opening a new one.
          Hide
          Filter Manager added a comment -

          At the moment the separation is actually quite clean.

          The course profiles in "internal" and shows things that may differ between courses (groups, roles etc) apart from picture and description. There is now a messaging link too.

          The user profile shows all the external contact stuff. I think some sites may actually want it this way, so students can NOT see the external contact details of other students in the same course.

          On moodle.org we just need to tweak the roles to allow people to see full profiles.

          I'm going to close this ... please open a new bug if you strongly believe course profiles need to show more or be more configurable.

          Show
          Filter Manager added a comment - At the moment the separation is actually quite clean. The course profiles in "internal" and shows things that may differ between courses (groups, roles etc) apart from picture and description. There is now a messaging link too. The user profile shows all the external contact stuff. I think some sites may actually want it this way, so students can NOT see the external contact details of other students in the same course. On moodle.org we just need to tweak the roles to allow people to see full profiles. I'm going to close this ... please open a new bug if you strongly believe course profiles need to show more or be more configurable.
          Hide
          Sam Marshall added a comment -

          Just to comment: I think this solution is fine in general - I'm not really sure about the merits of separating them this way, but it makes reasonable sense.

          Here we have a requirement to show additional information which must be on both versions of profile page, however that is not related to this bug. This ought to be possible using the block interface but it is currently not possible to configure this due to a bug in the way user profile blocks are handled - I have filed this as MDL-25189.

          Show
          Sam Marshall added a comment - Just to comment: I think this solution is fine in general - I'm not really sure about the merits of separating them this way, but it makes reasonable sense. Here we have a requirement to show additional information which must be on both versions of profile page, however that is not related to this bug. This ought to be possible using the block interface but it is currently not possible to configure this due to a bug in the way user profile blocks are handled - I have filed this as MDL-25189 .
          Hide
          Tim Hunt added a comment -

          I don't actually understand why the bug was closed before the problem was fixed on Moodle.org.

          Here is the user story:

          1. You are reading a forum thread.
          2. You think "To reply to this person, it would be really good to know more about them".
          3. So you click on their name to get to their profile.
          4. You read their profile.

          Except that at the moment, there is a step 3 1/2. Then click on the Full profile link.

          I'm sorry, but that is just stupid.

          Yes, it is logical to separate those parts of the profile that depend on this course, from the 'Full profile', but it is most often the 'Full profile' information that you want, so hiding the fill profile information at the other end of a link is not logical. The page you get to by clicking someone's name should be their full profile. In necessary, add the 'Course profile' information underneat, on the same page, with a sub-heading to keep it logically separate.

          Show
          Tim Hunt added a comment - I don't actually understand why the bug was closed before the problem was fixed on Moodle.org. Here is the user story: 1. You are reading a forum thread. 2. You think "To reply to this person, it would be really good to know more about them". 3. So you click on their name to get to their profile. 4. You read their profile. Except that at the moment, there is a step 3 1/2. Then click on the Full profile link. I'm sorry, but that is just stupid. Yes, it is logical to separate those parts of the profile that depend on this course, from the 'Full profile', but it is most often the 'Full profile' information that you want, so hiding the fill profile information at the other end of a link is not logical. The page you get to by clicking someone's name should be their full profile. In necessary, add the 'Course profile' information underneat, on the same page, with a sub-heading to keep it logically separate.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Moving this to STABLE backlog, to be handled asap... ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Moving this to STABLE backlog, to be handled asap... ciao
          Hide
          Andrew Davis added a comment -

          Ive committed some code to my repository that simply adds the email field to the course profile. The code is directly copied from the user profile page.

          repo: git://github.com/andyjdavis/moodle.git
          branch: MDL-24724_course_profile
          diff: https://github.com/andyjdavis/moodle/compare/master...MDL-24724_course_profile

          This technically resolves this issue however I can understand the confusion here and the desire for more significant reworking. I'm inclined to call this issue done and to open another to come back, write some proper specs and do a more serious refactoring. Thoughts?

          Show
          Andrew Davis added a comment - Ive committed some code to my repository that simply adds the email field to the course profile. The code is directly copied from the user profile page. repo: git://github.com/andyjdavis/moodle.git branch: MDL-24724 _course_profile diff: https://github.com/andyjdavis/moodle/compare/master...MDL-24724_course_profile This technically resolves this issue however I can understand the confusion here and the desire for more significant reworking. I'm inclined to call this issue done and to open another to come back, write some proper specs and do a more serious refactoring. Thoughts?
          Hide
          Sam Marshall added a comment -

          I think your plan to call this bug finished and investigate it later is a good one.

          When considering the wider issue, can I recommend also including MDL-25189 - the user profile page has the same blocks as on course page, which is weird as it is clearly not the same page.

          Show
          Sam Marshall added a comment - I think your plan to call this bug finished and investigate it later is a good one. When considering the wider issue, can I recommend also including MDL-25189 - the user profile page has the same blocks as on course page, which is weird as it is clearly not the same page.
          Hide
          Andrew Davis added a comment -

          Ok. Im marking this resolved. PULL-348

          I have opened MDL-26548 to do more work to make the course profile area more sensible.

          Show
          Andrew Davis added a comment - Ok. Im marking this resolved. PULL-348 I have opened MDL-26548 to do more work to make the course profile area more sensible.
          Hide
          Petr Škoda added a comment -

          Reopening, the maildisplay==2 means only enrolled users may see it. I am going to file a separate issue for related privacy problem on the main profile page.

          Show
          Petr Škoda added a comment - Reopening, the maildisplay==2 means only enrolled users may see it. I am going to file a separate issue for related privacy problem on the main profile page.
          Hide
          Andrew Davis added a comment - - edited

          Switched to using is_enrolled() rather than is_guest(). PULL-370

          Also opened MDL-26645

          Show
          Andrew Davis added a comment - - edited Switched to using is_enrolled() rather than is_guest(). PULL-370 Also opened MDL-26645
          Hide
          Andrew Davis added a comment -

          Reopening this as the reviewer appears to have forgotten to do so after rejecting PULL-370

          Show
          Andrew Davis added a comment - Reopening this as the reviewer appears to have forgotten to do so after rejecting PULL-370
          Hide
          Andrew Davis added a comment -

          Think Ive fixed the issue. PULL-397

          Show
          Andrew Davis added a comment - Think Ive fixed the issue. PULL-397
          Hide
          Helen Foster added a comment -

          Thanks for everyone's comments and thanks to Andrew for fixing. The fix is included in the latest 2.0.2+.

          Show
          Helen Foster added a comment - Thanks for everyone's comments and thanks to Andrew for fixing. The fix is included in the latest 2.0.2+.

            People

            • Votes:
              10 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: