Moodle
  1. Moodle
  2. MDL-24791

Gradebook column hilighting wrong again

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.9
    • Fix Version/s: 1.9.11
    • Component/s: Gradebook
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      Basically, the fix for MDL-21315 is pretty broken.

      If a user is not using the fixed student column, and does not have the gradereport/user:view capability, then there is colspan, so the gradecelloffset horrible hack variable is being set incorrectly.

      In addition the set_col function in grade/report/grader/functions.js is hard-coding row numbers like 2, and 3, but the number of header rows depends on the number of nested categories.

      I'm working on a fix.

        Gliffy Diagrams

          Activity

          Hide
          Tim Hunt added a comment -

          Andrew, please can you review and commit this. Thanks.

          Show
          Tim Hunt added a comment - Andrew, please can you review and commit this. Thanks.
          Hide
          Tim Hunt added a comment -

          The code in Moodle 2.0 looks completely different. Can I assume that it works, or at least if it is broken, someone else will fix it? Let's just get this fix into 1.9 as soon as we can.

          Show
          Tim Hunt added a comment - The code in Moodle 2.0 looks completely different. Can I assume that it works, or at least if it is broken, someone else will fix it? Let's just get this fix into 1.9 as soon as we can.
          Hide
          Tim Hunt added a comment -

          Andrew, I know you are super-busy, but is there any chance you could have a quick look at this patch? Thanks.

          Show
          Tim Hunt added a comment - Andrew, I know you are super-busy, but is there any chance you could have a quick look at this patch? Thanks.
          Hide
          Andrew Davis added a comment -

          having a look

          Show
          Andrew Davis added a comment - having a look
          Hide
          Andrew Davis added a comment -

          I've committed the patch. Its tough trying to remember how this worked in 1.9. Thanks for the report and the patch

          Show
          Andrew Davis added a comment - I've committed the patch. Its tough trying to remember how this worked in 1.9. Thanks for the report and the patch
          Hide
          Tim Hunt added a comment -

          Thanks Andrew.

          Show
          Tim Hunt added a comment - Thanks Andrew.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: