Moodle
  1. Moodle
  2. MDL-24860

create messaging providers for needy modules to manage messaging (of emails eg: mod_data )

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0.2
    • Component/s: Messages
    • Labels:
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Rank:
      1562

      Description

      we need to find out what modules are using / need to use messaging to send out emails / notifications.
      Then implement them so that emails aren't redirected as IM inadvertently or going by default message preferences.

        Activity

        Hide
        Eloy Lafuente (stronk7) added a comment -

        NOTE: This issue was assigned to the STABLE backlog without complete triaging process. Marking it as triaged, but with this note for future reference.

        Show
        Eloy Lafuente (stronk7) added a comment - NOTE: This issue was assigned to the STABLE backlog without complete triaging process. Marking it as triaged, but with this note for future reference.
        Hide
        Andrew Davis added a comment -

        Ready for peer review git://github.com/andyjdavis/moodle.git
        branch: MDL-24860_messaging_providers
        diff: https://github.com/andyjdavis/moodle/compare/master...MDL-24860_messaging_providers

        I fixed up messaging support in mod_lesson.

        I went through the places that are directly sending email. They all seem to be directly emailing for a reason (user account not set up yet, database in inaccessible, moodle is probably broken etc). I just added a comment to indicate that a conscious decision was made that it was correct to directly email rather than using the messaging system.

        Show
        Andrew Davis added a comment - Ready for peer review git://github.com/andyjdavis/moodle.git branch: MDL-24860 _messaging_providers diff: https://github.com/andyjdavis/moodle/compare/master...MDL-24860_messaging_providers I fixed up messaging support in mod_lesson. I went through the places that are directly sending email. They all seem to be directly emailing for a reason (user account not set up yet, database in inaccessible, moodle is probably broken etc). I just added a comment to indicate that a conscious decision was made that it was correct to directly email rather than using the messaging system.
        Hide
        Sam Hemelryk added a comment -

        Hi Andrew,

        All looks good as you say mostly comments.
        I asked you about the lesson message provider and you pointed out that it is already implemented but wasn't actually added so thats all good.

        Cheers
        Sam

        Show
        Sam Hemelryk added a comment - Hi Andrew, All looks good as you say mostly comments. I asked you about the lesson message provider and you pointed out that it is already implemented but wasn't actually added so thats all good. Cheers Sam
        Hide
        Andrew Davis added a comment -

        have filed PULL-49

        Show
        Andrew Davis added a comment - have filed PULL-49
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Closing as fixed. Will land upstream in hours.

        While testing it, I've detected 2 annoyances: MDL-25817 and MDL-25816

        Thanks and ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Closing as fixed. Will land upstream in hours. While testing it, I've detected 2 annoyances: MDL-25817 and MDL-25816 Thanks and ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: