Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0.2
    • Component/s: RSS
    • Labels:
    • Environment:
      Ubuntu 10.04 Lucid, Moodle 2.0 RC1
    • Database:
      MySQL
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Rank:
      6522

      Description

      After enabling RSS site wide and activity why, when you click on the RSS feed link it reports "Error reading RSS data".

      Cron always reports
      Processing cron function for rss_client....
      0 feeds refreshed (took 0.001869 seconds)
      done.

      Even though I've enabled RSS in the forum news activity and posted messages after enabling RSS.

        Issue Links

          Activity

          Hide
          Andrew Davis added a comment -

          Hi Aaron. I think you're talking about two different things. The RSS stuff going on in cron is Moodle pulling in any external RSS feeds you may have configured. It's nothing to do with the RSS feeds that Moodle produces. Unless you've added an external RSS feed to Moodle via site administration there won't be any feeds to refresh.

          Regarding the error message you're getting so this is coming from a forum with posts in it? What are you using to view the RSS feed?

          Show
          Andrew Davis added a comment - Hi Aaron. I think you're talking about two different things. The RSS stuff going on in cron is Moodle pulling in any external RSS feeds you may have configured. It's nothing to do with the RSS feeds that Moodle produces. Unless you've added an external RSS feed to Moodle via site administration there won't be any feeds to refresh. Regarding the error message you're getting so this is coming from a forum with posts in it? What are you using to view the RSS feed?
          Hide
          Aaron Cowell added a comment -

          You are correct, the rss_client is the external RSS Feed process. I never see the below message appear in the Cron Job.

          Running rssfeeds if required...
          Generating rssfeeds...

          I've tried viewing the feed in IE9 and IE7. Also tried flushing cache on browsers, close, re-open, re-subscribe. Still same error and never see the rssfeeds cron feedback after adding new forums and discussions. Also, the only way I can see the RSS Feed of Discussion button is on the courses main page in the latest news block, there's no way to subscribe to a forum post/discussion directly in the forum activity.

          Show
          Aaron Cowell added a comment - You are correct, the rss_client is the external RSS Feed process. I never see the below message appear in the Cron Job. Running rssfeeds if required... Generating rssfeeds... I've tried viewing the feed in IE9 and IE7. Also tried flushing cache on browsers, close, re-open, re-subscribe. Still same error and never see the rssfeeds cron feedback after adding new forums and discussions. Also, the only way I can see the RSS Feed of Discussion button is on the courses main page in the latest news block, there's no way to subscribe to a forum post/discussion directly in the forum activity.
          Hide
          Andrew Davis added a comment - - edited

          When youre within the forum activity your browser will auto-detect the RSS feed. Im not sure about IE but Firefox puts an RSS icon in the address bar you can click to subscribe.

          Also, could you please purge your caches and see if that helps. If you are in developer mode at the very bottom of the page is a Purge Caches link. The contents of the RSS feeds are cached so if you got something broken into your cache you'll keep getting the same broken content.

          Show
          Andrew Davis added a comment - - edited When youre within the forum activity your browser will auto-detect the RSS feed. Im not sure about IE but Firefox puts an RSS icon in the address bar you can click to subscribe. Also, could you please purge your caches and see if that helps. If you are in developer mode at the very bottom of the page is a Purge Caches link. The contents of the RSS feeds are cached so if you got something broken into your cache you'll keep getting the same broken content.
          Hide
          Aaron Cowell added a comment -

          Ok, here's what I have...

          Cleared all caches, put myself into developer mode just to make sure everything stays cleared. Deleted all browser history and closed IE9 and IE7 after deleting all history/temp files/cookies, etc...

          Log into the Moodle 2.0 RC1, Click on my sample course, Here I see a "Latest News" block with an RSS Feed icon (Orange square with the .)))) If I click on that, I get the error about Error reading RSS Data.

          Now, if I click on my "Test" Forum activity... AHHH in IE7 there is a RSS button on the tabs bar that says "View RSS Feeds on this page", funny if I click the down button it says the course shortname, but after it says %FULLNAME% (Ex: SM2C: %FULLNAME%).

          On to IE9, they have eliminated the feed discovery button on the toolbar and in order to get to it, you need to press the ALT key, click Tools on the menu, click feed discovery, then select the feed it discovers.

          I find this really confusing, wondering if we can add the RSS Feed links back into the discussion table so you can find it easier and would be in the same location for all browsers? Or at least put the subscribe to feed in the settings menu like the glossary RSS feeds are handled?

          Show
          Aaron Cowell added a comment - Ok, here's what I have... Cleared all caches, put myself into developer mode just to make sure everything stays cleared. Deleted all browser history and closed IE9 and IE7 after deleting all history/temp files/cookies, etc... Log into the Moodle 2.0 RC1, Click on my sample course, Here I see a "Latest News" block with an RSS Feed icon (Orange square with the .)))) If I click on that, I get the error about Error reading RSS Data. Now, if I click on my "Test" Forum activity... AHHH in IE7 there is a RSS button on the tabs bar that says "View RSS Feeds on this page", funny if I click the down button it says the course shortname, but after it says %FULLNAME% (Ex: SM2C: %FULLNAME%). On to IE9, they have eliminated the feed discovery button on the toolbar and in order to get to it, you need to press the ALT key, click Tools on the menu, click feed discovery, then select the feed it discovers. I find this really confusing, wondering if we can add the RSS Feed links back into the discussion table so you can find it easier and would be in the same location for all browsers? Or at least put the subscribe to feed in the settings menu like the glossary RSS feeds are handled?
          Hide
          Helen Foster added a comment -

          Increasing priority to blocker as it's an error.

          It also seems to be affecting moodle.org, as reported by Joseph Rézeau:

          On the Modules and Plugins page, clicking on the RSS feed for this activity link displays Error reading RSS data.

          Show
          Helen Foster added a comment - Increasing priority to blocker as it's an error. It also seems to be affecting moodle.org, as reported by Joseph Rézeau: On the Modules and Plugins page, clicking on the RSS feed for this activity link displays Error reading RSS data.
          Hide
          geoff robinson added a comment -

          I've has the same problem and error. This is how it's affecting the site I'm developing thought this may help:

          It works fine clicking the rss icon when in the forum it's activated in (Latest news in this case) but when on another page in the moodle site and then clicking on the rss icon in the Latest news block to get the feed that's when the error comes up for me at the moment.

          Show
          geoff robinson added a comment - I've has the same problem and error. This is how it's affecting the site I'm developing thought this may help: It works fine clicking the rss icon when in the forum it's activated in (Latest news in this case) but when on another page in the moodle site and then clicking on the rss icon in the Latest news block to get the feed that's when the error comes up for me at the moment.
          Hide
          Andrew Davis added a comment -

          Fixes for these issues are ready for peer review.

          repo: git://github.com/andyjdavis/moodle.git
          branch: MDL-24870_rss_error
          diff: https://github.com/andyjdavis/moodle/compare/master...MDL-24870_rss_error

          There were two issues:
          1) The latest news block was putting the wrong context id in the rss URL. It needs to supply the context of the forum containing the news and not the context of the current page.
          2) The capability/permissions checks in the module RSS generation code wasn't quite right leading to some users being incorrectly denied access.

          Show
          Andrew Davis added a comment - Fixes for these issues are ready for peer review. repo: git://github.com/andyjdavis/moodle.git branch: MDL-24870 _rss_error diff: https://github.com/andyjdavis/moodle/compare/master...MDL-24870_rss_error There were two issues: 1) The latest news block was putting the wrong context id in the rss URL. It needs to supply the context of the forum containing the news and not the context of the current page. 2) The capability/permissions checks in the module RSS generation code wasn't quite right leading to some users being incorrectly denied access.
          Hide
          Sam Hemelryk added a comment -

          Hi Andrew,
          Your changes look good and seem to work well.
          I was a little concerned about security given the changing capabilities but I could break it so all good
          Has my +1 however I think you should make Petr the assignee of the PULL request so that he can review it with his security goggles

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Hi Andrew, Your changes look good and seem to work well. I was a little concerned about security given the changing capabilities but I could break it so all good Has my +1 however I think you should make Petr the assignee of the PULL request so that he can review it with his security goggles Cheers Sam
          Hide
          Andrew Davis added a comment -

          PULL-223

          I dont appear to have the capability to assign a reviewer to a pull request however Ive added a comment suggesting Petr.

          Show
          Andrew Davis added a comment - PULL-223 I dont appear to have the capability to assign a reviewer to a pull request however Ive added a comment suggesting Petr.
          Hide
          Helen Foster added a comment -

          Fix included in the weekly 2.0.1+. Thanks everyone.

          Show
          Helen Foster added a comment - Fix included in the weekly 2.0.1+. Thanks everyone.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: