Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-24887

Issue with External RSS feed block validator.org

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.9.10
    • Fix Version/s: 1.9.14
    • Component/s: RSS
    • Labels:
    • Environment:
      Linux, PSQL, 1.9.6 (Build: 20091021) or 1.9.10 (Build: 20101025)
    • Testing Instructions:
      Hide

      1/ Add a new rss block
      2/ Configure the block
      3/ Click 'edit news feeds'
      4/ Put the url: http://news.lancs.ac.uk/Web/_layouts/LUNews/rss.ashx?S=15&C=63
      5/ Click validate feed

      Expected result:
      The external validator validates the feed specified

      Actual result:
      The validator does not validate the feed because it has part of the string stripped

      Show
      1/ Add a new rss block 2/ Configure the block 3/ Click 'edit news feeds' 4/ Put the url: http://news.lancs.ac.uk/Web/_layouts/LUNews/rss.ashx?S=15&C=63 5/ Click validate feed Expected result: The external validator validates the feed specified Actual result: The validator does not validate the feed because it has part of the string stripped
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE
    • Pull from Repository:

      Description

      If you add a rss link from Echo 360, it has two links, one for mp3 and another for m4v. If you run these links through the 'Validate Feed' fails because the parameter is stripped off when calling validator.org.

      Fix is to add escape() to the javascript call.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            tlock Tim Lock added a comment -

            Patch to fix lib/rsslib.php

            Show
            tlock Tim Lock added a comment - Patch to fix lib/rsslib.php
            Hide
            mblake Michael Blake added a comment -

            This issue is causing problems for MP client. Please give it priority.

            Show
            mblake Michael Blake added a comment - This issue is causing problems for MP client. Please give it priority.
            Hide
            poltawski Dan Poltawski added a comment -

            A 'test rss' feed url would be useful to explain this - i've found one http://news.lancs.ac.uk/Web/_layouts/LUNews/rss.ashx?S=15&C=63

            Show
            poltawski Dan Poltawski added a comment - A 'test rss' feed url would be useful to explain this - i've found one http://news.lancs.ac.uk/Web/_layouts/LUNews/rss.ashx?S=15&C=63
            Hide
            poltawski Dan Poltawski added a comment -

            Integrators: This only affects 1.9 and I believe it to be a trivial issue so I would not be upset if this is not integrated

            Show
            poltawski Dan Poltawski added a comment - Integrators: This only affects 1.9 and I believe it to be a trivial issue so I would not be upset if this is not integrated
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The integration of this issue has been delayed to next week due to time constraints. Thanks for your support and patience!

            Sorry and ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The integration of this issue has been delayed to next week due to time constraints. Thanks for your support and patience! Sorry and ciao
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Integrated, thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
            Hide
            rajeshtaneja Rajesh Taneja added a comment -

            Rss link provided in testcase show error,
            But tried with http://thefonecast.com/RSS.ashx?4 and it works fine.

            Thanks for fixing this Tim and Dan

            Show
            rajeshtaneja Rajesh Taneja added a comment - Rss link provided in testcase show error, But tried with http://thefonecast.com/RSS.ashx?4 and it works fine. Thanks for fixing this Tim and Dan
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Such an effort has get its prize. Universal Award to the very-best Moodle developer in the family. Thanks!

            Closing. Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Such an effort has get its prize. Universal Award to the very-best Moodle developer in the family. Thanks! Closing. Ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Oct/11