Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-24951

Groups mode in a forum without defined groups in a course gives a misleading error message

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.9, 1.9.10, 2.0, 2.7, 3.1.2, 3.5.3, 3.6.1, 3.7
    • Fix Version/s: 3.5.4, 3.6.2
    • Component/s: Course, Forum
    • Labels:
    • Database:
      Any
    • Testing Instructions:
      Hide
      1. Create a course
      2. Enrol a user as student and a user as a non-editing teacher into the course
      3. Create a group in 'course' called 'group 1'
      4. Ensure no user is a member of 'group 1'
      5. Create a forum activity in the course configured with group mode in "Seperate group mode"
      6. Login as 'teacher'
      7. Try to post in the forum
        1. Confirm that the teacher sees the following warning:
          You do not have permission to add a new discussion topic for all participants.
      8. Login as 'student'
      9. Try to post in the forum
        1. Confirm that the student sees the following warning:
          You do not have permission to add a new discussion topic. You are not a member of any groups.
      10. Login as admin
      11. add both 'teacher' & 'student' to 'group 1'
      12. Login as 'teacher'
      13. Try to post in the forum
        1. Confirm that the teacher is able to add a new discussion
      14. Login as 'student'
      15. Try to post in the forum
        1. Confirm that the student is able to add a new discussion
      Show
      Create a course Enrol a user as student and a user as a non-editing teacher into the course Create a group in 'course' called 'group 1' Ensure no user is a member of 'group 1' Create a forum activity in the course configured with group mode in "Seperate group mode" Login as 'teacher' Try to post in the forum Confirm that the teacher sees the following warning: You do not have permission to add a new discussion topic for all participants. Login as 'student' Try to post in the forum Confirm that the student sees the following warning: You do not have permission to add a new discussion topic. You are not a member of any groups. Login as admin add both 'teacher' & 'student' to 'group 1' Login as 'teacher' Try to post in the forum Confirm that the teacher is able to add a new discussion Login as 'student' Try to post in the forum Confirm that the student is able to add a new discussion
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE, MOODLE_27_STABLE, MOODLE_31_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE
    • Pull 3.5 Branch:
    • Pull 3.6 Branch:
    • Pull Master Branch:
      MDL-24951-master

      Description

      Creating a forum with a groups mode enabled without any groups defined in the course causes a non-obvious failure. For example, if you create a forum with separate groups in a course without any defined groups, any student who visits the forum receives this message: "You do not have permission to add a new discussion topic for all participants." Contrast this behavior with a wiki, which gracefully allows a wiki for "All Participants," even though we're in groups mode.

      One way to fix this is to prohibit creating an activity when there no defined groups. I've attached patches for 1.9.9 and 2.0 RC1 which accomplish this. Another way might be a new default behavior for a forum (similar to the wiki) or at least a more apparent error message.

        Attachments

        1. groupsmode_199.diff
          2 kB
        2. groupsmode_200.diff
          2 kB
        3. MDL-24951.jpg
          MDL-24951.jpg
          23 kB

          Issue Links

            Activity

              People

              • Votes:
                10 Vote for this issue
                Watchers:
                10 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/Jan/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 40 minutes
                  40m