Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-25027

Web Service moodle_user_create_users() does not accept leading/trailing spaces in firstname / lastname

    Details

    • Testing Instructions:
      Hide

      1) turn on web services under advanced features.
      2) plugins->web services -> external services , create a web service
      3) define in the GUI, a web services function that creates moodle users using 'moodle_user_create_users'
      4) call the web service with a web services test client (some can be cloned from here : git@github.com:moodlehq/sample-ws-clients.git )
      5) check that it can create firstname and lastnames with spaces in it.

      Please test MDL-30878 also. Part of this patch was removed for testing MDL-30878.

      Show
      1) turn on web services under advanced features. 2) plugins->web services -> external services , create a web service 3) define in the GUI, a web services function that creates moodle users using 'moodle_user_create_users' 4) call the web service with a web services test client (some can be cloned from here : git@github.com:moodlehq/sample-ws-clients.git ) 5) check that it can create firstname and lastnames with spaces in it. Please test MDL-30878 also. Part of this patch was removed for testing MDL-30878.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-25027_stable_consistency_fix

      Description

      Users can be added with leading/trailing spaces in firstname and lastname via the GUI form. However, the same values submitted via web services will cause an exception to be thrown.

      This appears to be because the create_users service runs the data through truncate_userinfo() and throws an exception if it is returned modified in anyway. truncate_userinfo() has a call to trim() which strips the spaces. The fields are of type PARAM_NOTAGS which allows the spaces.

        Gliffy Diagrams

          Issue Links

            Activity

            ashleyholman Ashley Holman created issue -
            jerome Jérôme Mouneyrac made changes -
            Field Original Value New Value
            Fix Version/s 2.0 [ 10122 ]
            Hide
            jerome Jérôme Mouneyrac added a comment -

            I added Petr as watcher. He wrote the:

            $truncated = truncate_userinfo($user);
                        foreach ($truncated as $key=>$value) {
                                ...
                        }

            I'm not sure why user information needs to be truncated, the phpdoc say:

            Will truncate userinfo as it comes from auth_get_userinfo (from external auth) which may have large fields

            what does that mean?

            Show
            jerome Jérôme Mouneyrac added a comment - I added Petr as watcher. He wrote the: $truncated = truncate_userinfo($user); foreach ($truncated as $key=>$value) { ... } I'm not sure why user information needs to be truncated, the phpdoc say: Will truncate userinfo as it comes from auth_get_userinfo (from external auth) which may have large fields what does that mean?
            Hide
            skodak Petr Skoda added a comment -

            Tt means that external source may have fields 32786826738 characters long, but our DB would throw error.

            Show
            skodak Petr Skoda added a comment - Tt means that external source may have fields 32786826738 characters long, but our DB would throw error.
            Hide
            jerome Jérôme Mouneyrac added a comment -

            Ok I understand now, thanks.

            Two possibilities, user firstname/address/lastname/email... :
            a- can have leading/trailing white space => I'll fix it
            b- cannot => continue to throw an exception. I just need to update the error message that is incomplete.

            Petr? Apparently b) seems correct.

            Show
            jerome Jérôme Mouneyrac added a comment - Ok I understand now, thanks. Two possibilities, user firstname/address/lastname/email... : a- can have leading/trailing white space => I'll fix it b- cannot => continue to throw an exception. I just need to update the error message that is incomplete. Petr? Apparently b) seems correct.
            dougiamas Martin Dougiamas made changes -
            Fix Version/s 2.0.1 [ 10420 ]
            Fix Version/s 2.0 [ 10122 ]
            jerome Jérôme Mouneyrac made changes -
            Fix Version/s STABLE backlog [ 10463 ]
            Fix Version/s 2.0.1 [ 10420 ]
            Hide
            ashleyholman Ashley Holman added a comment -

            Option b would mean that the web service behaves differently to the manual "add user" page, which is the bug I am reporting. It should be possible to add a user with whitespace around their name if you can do it via GUI.

            Show
            ashleyholman Ashley Holman added a comment - Option b would mean that the web service behaves differently to the manual "add user" page, which is the bug I am reporting. It should be possible to add a user with whitespace around their name if you can do it via GUI.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            NOTE: This issue was assigned to the STABLE backlog without complete triaging process. Marking it as triaged, but with this note for future reference.

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - NOTE: This issue was assigned to the STABLE backlog without complete triaging process. Marking it as triaged, but with this note for future reference.
            stronk7 Eloy Lafuente (stronk7) made changes -
            Labels triaged
            dougiamas Martin Dougiamas made changes -
            Workflow jira [ 40001 ] MDL Workflow [ 47009 ]
            dougiamas Martin Dougiamas made changes -
            Workflow MDL Workflow [ 47009 ] MDL Full Workflow [ 75221 ]
            ashleyholman Ashley Holman made changes -
            Labels triaged netspot triaged
            Hide
            mblake Michael Blake added a comment -

            This issue has been reported to affect MP clients. Please give it priority.

            Show
            mblake Michael Blake added a comment - This issue has been reported to affect MP clients. Please give it priority.
            mblake Michael Blake made changes -
            Labels netspot triaged netspot partner triaged
            jerome Jérôme Mouneyrac made changes -
            Priority Minor [ 4 ] Critical [ 2 ]
            jerome Jérôme Mouneyrac made changes -
            Link This issue will help resolve MDL-29276 [ MDL-29276 ]
            filter manager Filter Manager made changes -
            Fix Version/s STABLE Sprint 14 [ 11050 ]
            Fix Version/s STABLE backlog [ 10463 ]
            Assignee Jerome Mouneyrac [ jerome ] Aparup Banerjee [ nebgor ]
            jerome Jérôme Mouneyrac made changes -
            Link This issue has a non-specific relationship to MDL-29374 [ MDL-29374 ]
            nebgor Aparup Banerjee made changes -
            Status Open [ 1 ] Development in progress [ 3 ]
            Hide
            nebgor Aparup Banerjee added a comment - - edited

            Petr,
            need your opinion, is there any history about spaces in fields related to ldap/ext-db auth i should know about?

            afaik i see no reason for trimming in truncate_userinfo() but i'm not familiar with other auth usages etc.

            Show
            nebgor Aparup Banerjee added a comment - - edited Petr, need your opinion, is there any history about spaces in fields related to ldap/ext-db auth i should know about? afaik i see no reason for trimming in truncate_userinfo() but i'm not familiar with other auth usages etc.
            Hide
            skodak Petr Skoda added a comment -

            +1 to throw validation error in web UIs when typing new or changing existing usernames, I personally do not like any silent modification of submitted/external data

            Show
            skodak Petr Skoda added a comment - +1 to throw validation error in web UIs when typing new or changing existing usernames, I personally do not like any silent modification of submitted/external data
            Hide
            nebgor Aparup Banerjee added a comment -

            linking issue created to fix GUI validations.

            Show
            nebgor Aparup Banerjee added a comment - linking issue created to fix GUI validations.
            nebgor Aparup Banerjee made changes -
            Link This issue has been marked as being related by MDL-29582 [ MDL-29582 ]
            Hide
            nebgor Aparup Banerjee added a comment -

            ok, removed trimming to stop silently screwing with data.
            up for peer-review.

            Show
            nebgor Aparup Banerjee added a comment - ok, removed trimming to stop silently screwing with data. up for peer-review.
            nebgor Aparup Banerjee made changes -
            Status Development in progress [ 3 ] Waiting for peer review [ 10012 ]
            Peer reviewer rwijaya
            nebgor Aparup Banerjee made changes -
            Testing Instructions 1) turn on web services under advanced features.
            2) plugins->web services -> external services , create a web service
            3) define in the GUI, a web services function that creates moodle users using 'moodle_user_create_users'
            4) call the web service with a web services test client
            5) check that it can create firstname and lastnames with spaces in it.
            rwijaya Rossiani Wijaya made changes -
            Original Estimate 0 minutes [ 0 ]
            Remaining Estimate 0 minutes [ 0 ]
            Status Waiting for peer review [ 10012 ] Peer review in progress [ 10013 ]
            nebgor Aparup Banerjee made changes -
            Pull Master Diff URL https://github.com/nebgor/moodle/compare/master...MDL-25027 https://github.com/nebgor/moodle/compare/mistress...MDL-25027
            Testing Instructions 1) turn on web services under advanced features.
            2) plugins->web services -> external services , create a web service
            3) define in the GUI, a web services function that creates moodle users using 'moodle_user_create_users'
            4) call the web service with a web services test client
            5) check that it can create firstname and lastnames with spaces in it.
            1) turn on web services under advanced features.
            2) plugins->web services -> external services , create a web service
            3) define in the GUI, a web services function that creates moodle users using 'moodle_user_create_users'
            4) call the web service with a web services test client (some can be cloned from here : git@github.com:moodlehq/sample-ws-clients.git )
            5) check that it can create firstname and lastnames with spaces in it.
            nebgor Aparup Banerjee made changes -
            Status Peer review in progress [ 10013 ] Development in progress [ 3 ]
            Hide
            nebgor Aparup Banerjee added a comment -

            Hi Rosie, thanks for the peer-review, i've improved the fix now.

            Show
            nebgor Aparup Banerjee added a comment - Hi Rosie, thanks for the peer-review, i've improved the fix now.
            rwijaya Rossiani Wijaya made changes -
            Status Development in progress [ 3 ] Peer review in progress [ 10013 ]
            Hide
            rwijaya Rossiani Wijaya added a comment -

            Hi Apu, Thanks for fixing the patch.
            This is working great in all branches.

            Show
            rwijaya Rossiani Wijaya added a comment - Hi Apu, Thanks for fixing the patch. This is working great in all branches.
            rwijaya Rossiani Wijaya made changes -
            Status Peer review in progress [ 10013 ] Development in progress [ 3 ]
            Hide
            rwijaya Rossiani Wijaya added a comment -

            sending for integration review

            Show
            rwijaya Rossiani Wijaya added a comment - sending for integration review
            rwijaya Rossiani Wijaya made changes -
            Status Development in progress [ 3 ] Waiting for integration review [ 10010 ]
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Uhm, I was going to integrate this (leave any lead/trail whitespace unmodified in the WS creating services) but then I read the followup MDL-29582 about the UI and it seems that we are going to the "error/prevent" route there, or am I wrong?

            In any case, I think the same restrictions and behavior should be expected both when creating users from WS or UI and it seems we are going to continue bahving differently? Please clarify / discuss and decide.

            I'm reopening this. Feel free to re-send it once defined the (ideally) unique behavior.

            Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Uhm, I was going to integrate this (leave any lead/trail whitespace unmodified in the WS creating services) but then I read the followup MDL-29582 about the UI and it seems that we are going to the "error/prevent" route there, or am I wrong? In any case, I think the same restrictions and behavior should be expected both when creating users from WS or UI and it seems we are going to continue bahving differently? Please clarify / discuss and decide. I'm reopening this. Feel free to re-send it once defined the (ideally) unique behavior. Ciao
            stronk7 Eloy Lafuente (stronk7) made changes -
            Status Waiting for integration review [ 10010 ] Reopened [ 4 ]
            Hide
            nebgor Aparup Banerjee added a comment - - edited

            well the follow up of error/prevent issue is to decide whether we want to go the error/prevent route. I'll clarify that there.
            I sort of agreed with Petr's comment .

            The changes to webservices iS firstly to make them consistent for now but secondly to prevent modification of incoming external data.
            Alternatively we could go the route of modifying external data and perhaps log to admin log? but it could be a crazy amount of log ..

            Show
            nebgor Aparup Banerjee added a comment - - edited well the follow up of error/prevent issue is to decide whether we want to go the error/prevent route. I'll clarify that there. I sort of agreed with Petr's comment . The changes to webservices iS firstly to make them consistent for now but secondly to prevent modification of incoming external data. Alternatively we could go the route of modifying external data and perhaps log to admin log? but it could be a crazy amount of log ..
            moodle.com moodle.com made changes -
            Affects Version/s STABLE Sprint 15 [ 11158 ]
            Affects Version/s 2.0 [ 10122 ]
            moodle.com moodle.com made changes -
            Fix Version/s STABLE Sprint 15 [ 11158 ]
            Fix Version/s STABLE Sprint 14 [ 11050 ]
            nebgor Aparup Banerjee made changes -
            Status Reopened [ 4 ] Development in progress [ 3 ]
            Hide
            nebgor Aparup Banerjee added a comment - - edited

            Requesting insight of Mr Sam Hemelryk (or anyone else!)

            Show
            nebgor Aparup Banerjee added a comment - - edited Requesting insight of Mr Sam Hemelryk (or anyone else!)
            nebgor Aparup Banerjee made changes -
            Status Development in progress [ 3 ] Waiting for peer review [ 10012 ]
            Peer reviewer rwijaya samhemelryk
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Hi

            I've been looking at this issue and MDL-29582 this morning and have to admit I'm a little confused.

            1. The modified method truncate_userinfo is taking a portion of the string and then trimming which is a weird order to have those two operations in. The only reason I can think of for the trim is to remove trailing whitespace that is perhaps left over from the substr operation... department "Department of communication & technology" would be trimmed to "Department of communication & " (note the now trailing whitespace). This would of course mean that
            2. Only some fields are safe to substring; username, idnumber, email, country for sure are not. Where as institution, department, etc wouldn't really matter. At a glance with username's being trimmed should we in the future increase the length of the username field there would be a risk of authentication plugins adding users that already exist because of username concatenation.

            As for the actual issue of accepting leading and trailing whitespace - I lack to see why we would want to accept leading/trailing whitespace but of course that is inconsequential - really this issue is about consistency right?

            My personal opinion at this point is that Moodle code should not be truncating user_info, and should not be trimming it either. I think core should be validating the incoming data to make sure that it meets the requirements we have, and any failure to meet those requirements (field length etc) should result in error/exception.
            Any trimming or concatenation should be done as an entirely separate operation before that validation, on a field by field basis, and really only if we know that incoming data is going not going to meet our requirements and only if we know it is safe to complete such operations (so really only on information only fields).

            Perhaps I've missed something?

            Cheers
            Sam

            Show
            samhemelryk Sam Hemelryk added a comment - Hi I've been looking at this issue and MDL-29582 this morning and have to admit I'm a little confused. The modified method truncate_userinfo is taking a portion of the string and then trimming which is a weird order to have those two operations in. The only reason I can think of for the trim is to remove trailing whitespace that is perhaps left over from the substr operation... department "Department of communication & technology" would be trimmed to "Department of communication & " (note the now trailing whitespace). This would of course mean that Only some fields are safe to substring; username, idnumber, email, country for sure are not. Where as institution, department, etc wouldn't really matter. At a glance with username's being trimmed should we in the future increase the length of the username field there would be a risk of authentication plugins adding users that already exist because of username concatenation. As for the actual issue of accepting leading and trailing whitespace - I lack to see why we would want to accept leading/trailing whitespace but of course that is inconsequential - really this issue is about consistency right? My personal opinion at this point is that Moodle code should not be truncating user_info, and should not be trimming it either. I think core should be validating the incoming data to make sure that it meets the requirements we have, and any failure to meet those requirements (field length etc) should result in error/exception. Any trimming or concatenation should be done as an entirely separate operation before that validation, on a field by field basis, and really only if we know that incoming data is going not going to meet our requirements and only if we know it is safe to complete such operations (so really only on information only fields). Perhaps I've missed something? Cheers Sam
            samhemelryk Sam Hemelryk made changes -
            Comment [ Hi :)

            I've been looking at this issue and MDL-29582 this morning and have to admit I'm a little confused.

            # The modified method _truncate_userinfo_ is taking a portion of the string and then trimming which is a weird order to have those two operations in. The only reason I can think of for the trim is to remove trailing whitespace that is perhaps left over from the substr operation... department "Department of communication & technology" would be trimmed to "Department of communication & " (note the now trailing whitespace). This would of course mean that
            # Only some fields are safe to substring; username, idnumber, email, country for sure are not. Where as institution, department, etc wouldn't really matter. At a glance with username's being trimmed should we in the future increase the length of the username field there would be a risk of authentication plugins adding users that already exist because of username concatenation.

            As for the actual issue of accepting leading and trailing whitespace - I lack to see why we would want to accept leading/trailing whitespace but of course that is inconsequential - really this issue is about consistency right?

            My personal opinion at this point is that Moodle code should not be truncating user_info, and should not be trimming it either. I think core should be validating the incoming data to make sure that it meets the requirements we have, and any failure to meet those requirements (field length etc) should result in error/exception.
            Any trimming or concatenation should be done as an entirely separate operation before that validation, on a field by field basis, and really only if we know that incoming data is going not going to meet our requirements and only if we know it is safe to complete such operations (so really only on information only fields).

            Perhaps I've missed something?

            Cheers
            Sam ]
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Whoops just realised I didn't push commit - sorry!

            Show
            samhemelryk Sam Hemelryk added a comment - Whoops just realised I didn't push commit - sorry!
            Hide
            nebgor Aparup Banerjee added a comment -

            Sam,
            agreed that this issue is about consistency. I also agree that we should be throw back error/exception upon receive data that aren't to requirements. I think i was trying to separate the two points by creating MDL-29582 as a dev task of improving web services (which i realize now is how i missed the fact that this applies to stable as well).

            I'll write up a patch so that ws goes along the lines of validation+error instead of mangling data.

            Show
            nebgor Aparup Banerjee added a comment - Sam, agreed that this issue is about consistency. I also agree that we should be throw back error/exception upon receive data that aren't to requirements. I think i was trying to separate the two points by creating MDL-29582 as a dev task of improving web services (which i realize now is how i missed the fact that this applies to stable as well). I'll write up a patch so that ws goes along the lines of validation+error instead of mangling data.
            nebgor Aparup Banerjee made changes -
            Status Waiting for peer review [ 10012 ] Development in progress [ 3 ]
            Show
            nebgor Aparup Banerjee added a comment - fmi: http://docs.moodle.org/dev/XMLDB_column_types
            moodle.com moodle.com made changes -
            Fix Version/s STABLE Sprint 16 [ 11350 ]
            Fix Version/s STABLE Sprint 15 [ 11158 ]
            moodle.com moodle.com made changes -
            Labels netspot partner triaged sprinting
            salvetore Michael de Raadt made changes -
            Labels sprinting netspot partner sprinting triaged
            Hide
            salvetore Michael de Raadt added a comment -

            Carrying this over to the next STABLE Sprint.

            Show
            salvetore Michael de Raadt added a comment - Carrying this over to the next STABLE Sprint.
            salvetore Michael de Raadt made changes -
            Fix Version/s STABLE Sprint 17 [ 11550 ]
            Fix Version/s STABLE Sprint 16 [ 11350 ]
            Hide
            nebgor Aparup Banerjee added a comment -

            found some weird @property usages - fixed in MDL-31711

            Show
            nebgor Aparup Banerjee added a comment - found some weird @property usages - fixed in MDL-31711
            Hide
            nebgor Aparup Banerjee added a comment - - edited

            ok, i've made changes so that the web service call to create_users() validation doesn't truncate the user info and also now checks that the email is valid (like GUI @ user/editadvanced_form.php:validation() does).

            I've spoken to Jerome, and according to him, the objective of web services is to cater any of moodle's core services, as is, consistently to the external applications etc.. this patch would help achieve that.

            If firstname lastname should at all be truncated, it should be a proper improvement , i've created : MDL-31714

            Show
            nebgor Aparup Banerjee added a comment - - edited ok, i've made changes so that the web service call to create_users() validation doesn't truncate the user info and also now checks that the email is valid (like GUI @ user/editadvanced_form.php:validation() does). I've spoken to Jerome, and according to him, the objective of web services is to cater any of moodle's core services, as is, consistently to the external applications etc.. this patch would help achieve that. If firstname lastname should at all be truncated, it should be a proper improvement , i've created : MDL-31714
            nebgor Aparup Banerjee made changes -
            Link This issue development required addition/change MDL-31714 [ MDL-31714 ]
            nebgor Aparup Banerjee made changes -
            Status Development in progress [ 3 ] Waiting for peer review [ 10012 ]
            salvetore Michael de Raadt made changes -
            Fix Version/s STABLE Sprint 18 [ 11650 ]
            Fix Version/s STABLE Sprint 17 [ 11550 ]
            Hide
            nebgor Aparup Banerjee added a comment -

            up for integration, after Sam's review: (selective copy n paste :-p)

            (10:14:08) samhemelryk@moodle.org: The changes you have made certainly look like positive changes in regards to aligning it with how the UI works

            Sam has created MDL-31762 for other things he's noticed lacking in user_create_user().

            Show
            nebgor Aparup Banerjee added a comment - up for integration, after Sam's review: (selective copy n paste :-p) (10:14:08) samhemelryk@moodle.org: The changes you have made certainly look like positive changes in regards to aligning it with how the UI works Sam has created MDL-31762 for other things he's noticed lacking in user_create_user().
            nebgor Aparup Banerjee made changes -
            Status Waiting for peer review [ 10012 ] Waiting for integration review [ 10010 ]
            Pull from Repository git://github.com/nebgor/moodle.git
            Integrator stronk7
            stronk7 Eloy Lafuente (stronk7) made changes -
            Currently in integration Yes [ 10041 ]
            stronk7 Eloy Lafuente (stronk7) made changes -
            Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Certainly user validations need more work, but I think the followups created can be a good place for that.

            So integrating this (21, 22 & master). Thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Certainly user validations need more work, but I think the followups created can be a good place for that. So integrating this (21, 22 & master). Thanks!
            stronk7 Eloy Lafuente (stronk7) made changes -
            Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
            Affects Version/s 2.2.1 [ 11456 ]
            Affects Version/s 2.1.4 [ 11452 ]
            Fix Version/s 2.1.5 [ 11553 ]
            Fix Version/s 2.2.2 [ 11552 ]
            salvetore Michael de Raadt made changes -
            Tester rajeshtaneja
            rajeshtaneja Rajesh Taneja made changes -
            Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
            Hide
            rajeshtaneja Rajesh Taneja added a comment -

            Sorry Apu, I am getting

            <DEBUGINFO>Email address already exists: apdhatest@moo1dle2.com</DEBUGINFO>

            error. As discussed with you, it is happening because check is being done in transaction after user_create_user is called, so probably a nice idea to move it above this function or in user_create_user function

            Show
            rajeshtaneja Rajesh Taneja added a comment - Sorry Apu, I am getting <DEBUGINFO>Email address already exists: apdhatest@moo1dle2.com</DEBUGINFO> error. As discussed with you, it is happening because check is being done in transaction after user_create_user is called, so probably a nice idea to move it above this function or in user_create_user function
            rajeshtaneja Rajesh Taneja made changes -
            Status Testing in progress [ 10011 ] Problem during testing [ 10007 ]
            rajeshtaneja Rajesh Taneja made changes -
            Testing Instructions 1) turn on web services under advanced features.
            2) plugins->web services -> external services , create a web service
            3) define in the GUI, a web services function that creates moodle users using 'moodle_user_create_users'
            4) call the web service with a web services test client (some can be cloned from here : git@github.com:moodlehq/sample-ws-clients.git )
            5) check that it can create firstname and lastnames with spaces in it.
            1) turn on web services under advanced features.
            2) plugins->web services -> external services , create a web service
            3) define in the GUI, a web services function that creates moodle users using 'moodle_user_create_users'
            4) call the web service with a web services test client (some can be cloned from here : git@github.com:moodlehq/sample-ws-clients.git )
            5) check that it can create firstname and lastnames with spaces in it.

            Please test MDL-30878 also. Part of this patch was removed for testing MDL-30878.
            Hide
            nebgor Aparup Banerjee added a comment - - edited

            Thanks for spotting that Raj!
            i've put up this fix : https://github.com/nebgor/moodle/commit/d1eced9c816beebca7788b20e84fd0d7f627ef67 - that commit is based on integration.git/master branch

            edit: diff url https://github.com/nebgor/moodle/compare/int_master...int_m_MDL-25027

            this should fix that DB check.

            Eloy: Please cherry-pick this to master, 22 and 21. it applies clean for me atm.

            Show
            nebgor Aparup Banerjee added a comment - - edited Thanks for spotting that Raj! i've put up this fix : https://github.com/nebgor/moodle/commit/d1eced9c816beebca7788b20e84fd0d7f627ef67 - that commit is based on integration.git/master branch edit: diff url https://github.com/nebgor/moodle/compare/int_master...int_m_MDL-25027 this should fix that DB check. Eloy: Please cherry-pick this to master, 22 and 21. it applies clean for me atm.
            Hide
            rajeshtaneja Rajesh Taneja added a comment -

            Thanks Aparup,

            Works Great.. Also, tested MDL-30878 and works fine

            Show
            rajeshtaneja Rajesh Taneja added a comment - Thanks Aparup, Works Great.. Also, tested MDL-30878 and works fine
            stronk7 Eloy Lafuente (stronk7) made changes -
            Status Problem during testing [ 10007 ] Integration review in progress [ 10004 ]
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            New commit added to 21, 22 & master, reseting back to testing phase... thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - New commit added to 21, 22 & master, reseting back to testing phase... thanks!
            stronk7 Eloy Lafuente (stronk7) made changes -
            Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
            rajeshtaneja Rajesh Taneja made changes -
            Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
            Hide
            rajeshtaneja Rajesh Taneja added a comment -

            Thanks Everyone,
            Works Great

            FYI:
            tested for moodle_user_create_users and core_users_create_users

            Show
            rajeshtaneja Rajesh Taneja added a comment - Thanks Everyone, Works Great FYI: tested for moodle_user_create_users and core_users_create_users
            rajeshtaneja Rajesh Taneja made changes -
            Status Testing in progress [ 10011 ] Tested [ 10006 ]
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Well,

            I wish I said it every time
            you do the things you do.
            You always lend a helping hand,
            and I'm filled with gratitude.

            You are strong and generous
            for each and everyone one of us.
            I am eternally grateful,
            I cannot say thanks enough.

            Sorry for the (un)cool bit above, lol. Closing this as fixed. Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Well, I wish I said it every time you do the things you do. You always lend a helping hand, and I'm filled with gratitude. You are strong and generous for each and everyone one of us. I am eternally grateful, I cannot say thanks enough. Sorry for the (un)cool bit above, lol. Closing this as fixed. Ciao
            stronk7 Eloy Lafuente (stronk7) made changes -
            Status Tested [ 10006 ] Closed [ 6 ]
            Resolution Fixed [ 1 ]
            Currently in integration Yes [ 10041 ]
            Integration date 01/Mar/12
            stronk7 Eloy Lafuente (stronk7) made changes -
            Affects Version/s STABLE Sprint 15 [ 11158 ]
            stronk7 Eloy Lafuente (stronk7) made changes -
            Fix Version/s STABLE Sprint 18 [ 11650 ]

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/Mar/12