Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-25028

Anomaly contains a function which is not used within it's lib.php file

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: Themes
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      Anomaly has a function theme_enable_block_region within it's lib.php file that isn't ever used.
      Although this isn't necessarily a nasty thing it is problem with people copying the theme to make changes because the function isn't named explicitly enough can easily be forgotten when renaming things.

      In this case I am going to remove the function as it is not used and ask that anyone in the future adding functions to a theme to please name functions more explicitly (always containing the theme's name).

      Cheers
      Sam

        Attachments

          Activity

            People

            • Assignee:
              samhemelryk Sam Hemelryk
              Reporter:
              samhemelryk Sam Hemelryk
              Tester:
              Nobody
              Participants:
              Component watchers:
              Bas Brands
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                24/Nov/10