Moodle
  1. Moodle
  2. MDL-25075

Themes brick, fusion, nonzero, and overlay need to be reviewed for a better solution to the report layout.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Won't Fix
    • Affects Version/s: 2.0
    • Fix Version/s: None
    • Component/s: Themes
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Rank:
      1556

      Description

      Hi Patrick,

      This issue is off the back of MDL-24895.

      There is now a new page layout `report` that is used on pages where there is going to be large horizontal overflow. Reports being of course the main culprit.
      I've gone through all themes and added a report layout, for all but the noted four theme's this layout allows the browser to horizontally scroll.
      Presently on the four theme's there only the content area scrolls.

      Could you please review each of the four theme (and all the rest if you have time) and see what you think should/could be done. It would be ideal to get the browser to scroll horizontally but I don't want to destroy the awesome designs for each theme by doing so.

      Let me know if there is anything I can help with.

      For more information on this check out:

      Cheers
      Sam

        Issue Links

          Activity

          Hide
          Sam Hemelryk added a comment -

          Linked to the main issue for my work on overflow problems.

          Show
          Sam Hemelryk added a comment - Linked to the main issue for my work on overflow problems.
          Hide
          Patrick Malley added a comment -

          Sam - I'm not 100% sure what you'd like me to review. I'm looking at the grade report screen in all of these themes listed and it appears that all are using the report layout and the grade table is scrolling. Are you looking for an alternative solution?

          Show
          Patrick Malley added a comment - Sam - I'm not 100% sure what you'd like me to review. I'm looking at the grade report screen in all of these themes listed and it appears that all are using the report layout and the grade table is scrolling. Are you looking for an alternative solution?
          Hide
          Sam Hemelryk added a comment -

          Hi Patrick,

          Indeed, just looking to see if you have any ideas about a better solution to it.
          Ideally it would be nice to have the browser scroll horizontally rather than just the content div.
          I spent a bit of time trying to work out a cross browser layout that kept the blocks on the right and allowed horizontal scrolling of the whole page but didn't end up finding a good solution.
          I suppose the options are:

          1. Live with it as it is. There have been a couple of tracker issues and a few people in the forums who have missed the content scrollbars but eventually people will become used to it.
          2. Attempt to work out a layout that keeps the blocks on the right and scroll horizontally and works across all browsers. I fear this may be a hole into which we could pour a lot of time.
          3. Shift the blocks to the left for this one layout on these theme's. Probably messes up the theme's themselves and not ideal as people will not be used it.
          4. Use tables for this one layout on these theme's.

          Let me know what you think. Personally I am leaning towards perhaps 1, or 3 but then I don't really know the theme's well enough to judge what is possible and/or the best solution.

          I've also added Martin as a watcher so perhaps if has any ideas he can share them with us.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Hi Patrick, Indeed, just looking to see if you have any ideas about a better solution to it. Ideally it would be nice to have the browser scroll horizontally rather than just the content div. I spent a bit of time trying to work out a cross browser layout that kept the blocks on the right and allowed horizontal scrolling of the whole page but didn't end up finding a good solution. I suppose the options are: Live with it as it is. There have been a couple of tracker issues and a few people in the forums who have missed the content scrollbars but eventually people will become used to it. Attempt to work out a layout that keeps the blocks on the right and scroll horizontally and works across all browsers. I fear this may be a hole into which we could pour a lot of time. Shift the blocks to the left for this one layout on these theme's. Probably messes up the theme's themselves and not ideal as people will not be used it. Use tables for this one layout on these theme's. Let me know what you think. Personally I am leaning towards perhaps 1, or 3 but then I don't really know the theme's well enough to judge what is possible and/or the best solution. I've also added Martin as a watcher so perhaps if has any ideas he can share them with us. Cheers Sam
          Hide
          Patrick Malley added a comment -

          We've been going with 1 for our custom theme clients for the past couple months. Since these are admin pages, I don't think 3 would be too bad an option. I'm going to include John Stabinger - he has coded quite a few of these themes - let's see what he thinks.

          Patrick

          Show
          Patrick Malley added a comment - We've been going with 1 for our custom theme clients for the past couple months. Since these are admin pages, I don't think 3 would be too bad an option. I'm going to include John Stabinger - he has coded quite a few of these themes - let's see what he thinks. Patrick
          Hide
          Patrick Malley added a comment -

          Hey Sam,

          I was just reviewing this issue as it reared its head in our custom themes this week. Looking at the grader report, I don't see any reason to do anything different in the themes you've listed. It's my opinion that the scrollbars are not the best option, but they do the job. Couldn't we just use a table for the report layout? Not the most elegant solution, I realize, but if we embedded the content (blocks and all) into a table, the grader table would effectively push the block column as far right as necessary to show the entire table. Now, how much of the page would we have to embed in this table for it to look okay, I'm not sure.

          Show
          Patrick Malley added a comment - Hey Sam, I was just reviewing this issue as it reared its head in our custom themes this week. Looking at the grader report, I don't see any reason to do anything different in the themes you've listed. It's my opinion that the scrollbars are not the best option, but they do the job. Couldn't we just use a table for the report layout? Not the most elegant solution, I realize, but if we embedded the content (blocks and all) into a table, the grader table would effectively push the block column as far right as necessary to show the entire table. Now, how much of the page would we have to embed in this table for it to look okay, I'm not sure.
          Hide
          Sam Hemelryk added a comment -

          Hi Patrick,

          I don't think there is anything wrong with using a table layout for the theme's where this is no better way to get it to work nicely and as expected.

          I discussed using tables with Martin in regards to base+standard when I was first working on this horizontal scrolling issues. He was very keen to keep the 2,1,3 layout that ensures the content comes first in the page order which is why we didn't go with tables for those theme's however in regards to theme's that have right hand side blocks only your content would always come first anyway so really the only negative to it is the use of the table itself.

          As for how to use data, providing the structure of the layout hasn't changed too drastically from base you could refer to the standardold theme. It is basically just standard but uses tables instead of div's for its layout (helps avoid many problems in IE6).
          If it has changed then the I found when creating the standardold layouts that I could create the table, give it the id's of the divs in a sequential order, and then add additional divs within the td as required. Once done it took a little bit of CSS to prevent the div's from trying to position themselves and then that was about it.

          If you get stuck feel free to come back here and ask questions, or the forums.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Hi Patrick, I don't think there is anything wrong with using a table layout for the theme's where this is no better way to get it to work nicely and as expected. I discussed using tables with Martin in regards to base+standard when I was first working on this horizontal scrolling issues. He was very keen to keep the 2,1,3 layout that ensures the content comes first in the page order which is why we didn't go with tables for those theme's however in regards to theme's that have right hand side blocks only your content would always come first anyway so really the only negative to it is the use of the table itself. As for how to use data, providing the structure of the layout hasn't changed too drastically from base you could refer to the standardold theme. It is basically just standard but uses tables instead of div's for its layout (helps avoid many problems in IE6). If it has changed then the I found when creating the standardold layouts that I could create the table, give it the id's of the divs in a sequential order, and then add additional divs within the td as required. Once done it took a little bit of CSS to prevent the div's from trying to position themselves and then that was about it. If you get stuck feel free to come back here and ask questions, or the forums. Cheers Sam
          Hide
          Mary Evans added a comment -

          Hi Sam,

          Just found this tracker and wondered if this needed updating?
          Things have changed so much since the beginning of the year, the problems with this is similar to what happened recently in Formal White don't you think?

          Cheers
          Mary

          Show
          Mary Evans added a comment - Hi Sam, Just found this tracker and wondered if this needed updating? Things have changed so much since the beginning of the year, the problems with this is similar to what happened recently in Formal White don't you think? Cheers Mary
          Hide
          Mary Evans added a comment -

          @Dietmar

          I've just added you as watcher to keep you in the loop
          Cheers Mary

          Show
          Mary Evans added a comment - @Dietmar I've just added you as watcher to keep you in the loop Cheers Mary
          Hide
          Dietmar Wagner added a comment -

          Hi Mary,
          count me in!

          Cheers
          Dietmar

          Show
          Dietmar Wagner added a comment - Hi Mary, count me in! Cheers Dietmar
          Hide
          Mary Evans added a comment -

          Hi Dietmar,
          I have just finished 2 of the 4 themes needing fixing. Brick was relatively easy, but needs testing. Fusion was a challenge, but I managed it in the end, so I am uploading proof of my time spent on it today...in the form of my "To-day's Log" screenshot.

          Phew!

          Time I logged out.
          Thanks for your help.
          Cheers
          Mary

          Show
          Mary Evans added a comment - Hi Dietmar, I have just finished 2 of the 4 themes needing fixing. Brick was relatively easy, but needs testing. Fusion was a challenge, but I managed it in the end, so I am uploading proof of my time spent on it today...in the form of my "To-day's Log" screenshot. Phew! Time I logged out. Thanks for your help. Cheers Mary
          Hide
          Mary Evans added a comment -

          I need to review these and see if the recent changes to base and other theme report page will help understand how to deal with this group of themes. I really hate the fact that each one is different...it would make it fairly straightforward if they all had the same basic layout, then they could all use the same report.php but be styles according to the theme colours.

          I've separated this from the parent issue it was linked to so that I could close that issue to tidy things up.

          Show
          Mary Evans added a comment - I need to review these and see if the recent changes to base and other theme report page will help understand how to deal with this group of themes. I really hate the fact that each one is different...it would make it fairly straightforward if they all had the same basic layout, then they could all use the same report.php but be styles according to the theme colours. I've separated this from the parent issue it was linked to so that I could close that issue to tidy things up.
          Hide
          Mary Evans added a comment -

          Closing as this issue is no longer a problem.

          Show
          Mary Evans added a comment - Closing as this issue is no longer a problem.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: