Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-25138

tag_get_tags() and tag_get_correlated() need to return unique records

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0, 2.6.5, 2.7.2, 2.8.5, 2.9
    • Fix Version/s: 2.8.7, 2.9.1
    • Component/s: Tags
    • Testing Instructions:
      Hide
      1. Enable tags: usetags.
      2. Go to Site pages > Site blogs > Add new entry.
      3. Add 3 tags on the Other tags section (separated by commas).
      4. Add 2 more blog entries repeating those same tags from the first post.
      5. Run Cron.
      6. On the blog posts list, click in one of the tags you've just added.
      7. Make sure you don't get any error as mentioned above.
      8. Make sure the Related tags: doesn't display duplicated tags.
      9. Click on Manage tags and make sure it display all the tags created correctly.
      10. Click on the button Blocks editing on.
      11. Add the Tags block and make sure it displays correctly all the tags.
      12. On the Tags block, click in one of the tags.
      13. Add the Flickr block and make sure it displays images related to the selected tag. (This block is only available on tag)
      14. Enable course tags: block_tags_showcoursetags
      15. Add a course or select an existing one.
      16. Add the block Tags to the course.
      17. Make sure you're able to add new tags, view those tags, edit without any error.
      Show
      Enable tags: usetags . Go to Site pages > Site blogs > Add new entry. Add 3 tags on the Other tags section (separated by commas). Add 2 more blog entries repeating those same tags from the first post. Run Cron. On the blog posts list, click in one of the tags you've just added. Make sure you don't get any error as mentioned above. Make sure the Related tags: doesn't display duplicated tags. Click on Manage tags and make sure it display all the tags created correctly. Click on the button Blocks editing on . Add the Tags block and make sure it displays correctly all the tags. On the Tags block, click in one of the tags. Add the Flickr block and make sure it displays images related to the selected tag. (This block is only available on tag) Enable course tags: block_tags_showcoursetags Add a course or select an existing one. Add the block Tags to the course. Make sure you're able to add new tags, view those tags, edit without any error.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-25138-master
    • Sprint:
      Team '; drop tables Sprint 6

      Description

      Did you remember to make the first column something unique in your call to get_records? Duplicate value '1' found in column 'id'.

          * line 741 of /lib/dml/mysqli_native_moodle_database.php: call to debugging()
          * line 951 of /tag/lib.php: call to mysqli_native_moodle_database->get_records_sql()
          * line 458 of /tag/lib.php: call to tag_get_correlated()
          * line 107 of /tag/locallib.php: call to tag_get_related_tags()
          * line 94 of /tag/index.php: call to tag_print_description_box()

      Did you remember to make the first column something unique in your call to get_records? Duplicate value '1' found in column 'id'.

          * line 741 of /lib/dml/mysqli_native_moodle_database.php: call to debugging()
          * line 951 of /tag/lib.php: call to mysqli_native_moodle_database->get_records_sql()
          * line 458 of /tag/lib.php: call to tag_get_correlated()
          * line 107 of /tag/locallib.php: call to tag_get_related_tags()
          * line 94 of /tag/index.php: call to tag_print_description_box()

      Did you remember to make the first column something unique in your call to get_records? Duplicate value '1' found in column 'id'.

          * line 741 of /lib/dml/mysqli_native_moodle_database.php: call to debugging()
          * line 951 of /tag/lib.php: call to mysqli_native_moodle_database->get_records_sql()
          * line 458 of /tag/lib.php: call to tag_get_correlated()
          * line 107 of /tag/locallib.php: call to tag_get_related_tags()
          * line 94 of /tag/index.php: call to tag_print_description_box()

      Did you remember to make the first column something unique in your call to get_records? Duplicate value '1' found in column 'id'.

          * line 741 of /lib/dml/mysqli_native_moodle_database.php: call to debugging()
          * line 951 of /tag/lib.php: call to mysqli_native_moodle_database->get_records_sql()
          * line 458 of /tag/lib.php: call to tag_get_correlated()
          * line 107 of /tag/locallib.php: call to tag_get_related_tags()
          * line 94 of /tag/index.php: call to tag_print_description_box()

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  6/Jul/15