Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-25148

define ('MESSAGE_WINDOW', true); is a horrible hack

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: Messages
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      define ('MESSAGE_WINDOW', true); is defined in message/lib.php which is not correct because it is defined in bunch of other files which causes:
      Notice: Constant MESSAGE_WINDOW already defined in /server/workspace/moodle20/message/lib.php on line 30
      during upgrade.

      In any case using define for prevention of message popups does not seem like a good idea. This looks like a typical properly of $PAGE, it should not be very difficult to add support for it there. Or tehre might be some other better solution.

        Attachments

          Activity

            People

            Assignee:
            andyjdavis Andrew Davis
            Reporter:
            skodak Petr Skoda
            Tester:
            Nobody
            Participants:
            Component watchers:
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              24/Nov/10