Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0.1
    • Component/s: Global search
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Rank:
      216

      Description

      1 results returned for 'woo'.

      Missing picture property in $user object, this is a performance problem that needs to be fixed by a developer. Please use user_picture::fields() to get the full list of required fields.

      • line 158 of /lib/outputcomponents.php: call to debugging()
      • line 1787 of /lib/outputrenderers.php: call to user_picture->__construct()
      • line 348 of /search/query.php: call to core_renderer->user_picture()
        1. moodle.org/hq freediving
        Type: user, Score: 1, Author: Admin User

        Issue Links

          Activity

          Hide
          Aparup Banerjee added a comment -

          just a link to where this problem was noted.

          Show
          Aparup Banerjee added a comment - just a link to where this problem was noted.
          Hide
          Aparup Banerjee added a comment -

          simple patch attached.
          Petr , from your TODO comment, did you mean that can we should fetch the user data records outside this loop?

          Show
          Aparup Banerjee added a comment - simple patch attached. Petr , from your TODO comment, did you mean that can we should fetch the user data records outside this loop?
          Hide
          Aparup Banerjee added a comment -

          note: i'm using the fix here as a personal test to reviewing and getting stuff into git.moodle.org/moodle.git
          reference => https://github.com/moodle/moodle/pull/3

          Show
          Aparup Banerjee added a comment - note: i'm using the fix here as a personal test to reviewing and getting stuff into git.moodle.org/moodle.git reference => https://github.com/moodle/moodle/pull/3
          Hide
          Aparup Banerjee added a comment -

          i don't know where to put in fixes now other than using cvs (which is going to be turned off, so no point using it other than urgent fixes)

          ok so heres the fix which would need review (is there a tracker status for reviewables?)
          https://github.com/nebgor/moodle/commit/2a86f6f63be92ece0e6592679dbe140ecc197dda

          hopefully i can see how this commit goes through (if accepted!) the review process and into moodle when pull requests are up and running on tracker.

          Show
          Aparup Banerjee added a comment - i don't know where to put in fixes now other than using cvs (which is going to be turned off, so no point using it other than urgent fixes) ok so heres the fix which would need review (is there a tracker status for reviewables?) https://github.com/nebgor/moodle/commit/2a86f6f63be92ece0e6592679dbe140ecc197dda hopefully i can see how this commit goes through (if accepted!) the review process and into moodle when pull requests are up and running on tracker.
          Hide
          Petr Škoda added a comment -

          +1, please commit to CVS now

          Show
          Petr Škoda added a comment - +1, please commit to CVS now
          Hide
          Aparup Banerjee added a comment -

          thanks, committed into head via CVS.

          Show
          Aparup Banerjee added a comment - thanks, committed into head via CVS.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: