Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-25178

Add new condition for completion criteria of Glossary

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0.1
    • Component/s: Glossary
    • Labels:
      None
    • Environment:
      2.0 RC1 daily build 12112010
    • Difficulty:
      Moderate
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      At the moment there are two conditions to complete a glossary - view it or receive a grade.

      Would make sense to have a third, namely 'submit an entry', a-la the Choice and Feedback activities.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Attaching patch that implements one completion rule for glossaries based in number of entries created and approved. I used forum to guide me in the creation. Seems to be working ok.

            For your consideration is this should be included for 2.0 or no... ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Attaching patch that implements one completion rule for glossaries based in number of entries created and approved. I used forum to guide me in the creation. Seems to be working ok. For your consideration is this should be included for 2.0 or no... ciao
            Hide
            drex Mark Drechsler added a comment -

            Thanks!

            Let me get it on a dev instance internally and have a look - but if it works as described then I'd love to have it in 2.0

            Mark.

            Show
            drex Mark Drechsler added a comment - Thanks! Let me get it on a dev instance internally and have a look - but if it works as described then I'd love to have it in 2.0 Mark.
            Hide
            drex Mark Drechsler added a comment -

            All looks good to me in terms of doing what it needs to do - tested fine, so thanks!

            Only suggestion I'd make would be to maybe have students shown somewhere what the completion criteria are, like in the Database where it will tell you how many entries are required, but this is secondary to actually having the feature in there.

            Thanks again,

            Mark.

            Show
            drex Mark Drechsler added a comment - All looks good to me in terms of doing what it needs to do - tested fine, so thanks! Only suggestion I'd make would be to maybe have students shown somewhere what the completion criteria are, like in the Database where it will tell you how many entries are required, but this is secondary to actually having the feature in there. Thanks again, Mark.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Thanks for testing Mark. I need permission from his majesty (Martin) to push this to cvs-land.... awaiting for it.

            Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Thanks for testing Mark. I need permission from his majesty (Martin) to push this to cvs-land.... awaiting for it. Ciao
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            I'm resolving this as fixed as far as it has been sent for review at PULL-20.

            Surely will land to next 2.1 if approved, until then, enjoy!

            Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - I'm resolving this as fixed as far as it has been sent for review at PULL-20. Surely will land to next 2.1 if approved, until then, enjoy! Ciao
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            reopening to set it in review status

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - reopening to set it in review status
            Hide
            skodak Petr Skoda added a comment -

            thanks, closing

            Show
            skodak Petr Skoda added a comment - thanks, closing

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  25/Dec/10