Moodle
  1. Moodle
  2. MDL-25197

innodb web migration tool should give innodb status

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.3
    • Component/s: Database SQL/XMLDB
    • Labels:
      None
    • Environment:
      Moodle installed on LAMP server
    • Database:
      MySQL
    • Testing Instructions:
      Hide
      1. Setup moodle with mysql DB
      2. convert some tables back to myisam (easiest way is to use the admin/cli/mysql_engine.php CLI tool - php admin/cli/mysql_engine.php --engine=myisam )
      3. Visit admin/tool/innodb/and run migration
      4. Visit admin/tool/innodb/ again and run migration, it should tell you it was already converted
      Show
      Setup moodle with mysql DB convert some tables back to myisam (easiest way is to use the admin/cli/mysql_engine.php CLI tool - php admin/cli/mysql_engine.php --engine=myisam ) Visit admin/tool/innodb/and run migration Visit admin/tool/innodb/ again and run migration, it should tell you it was already converted
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w20_MDL-25197_m23_innodb
    • Rank:
      6468

      Description

      If I go to http://MOODLE-SERVER/admin/innodb.php should give innodb status and click yes to "Are you sure you want convert all your tables to the InnoDB format?" and then go back to that URL after the conversion is done, all I see is the same questions. If removing the question after it was run is not easily possible or not desired, I think seeing a message that said something like:

      The conversion to InnoDB was last run on XYZ date. You do not need to reconvert.

      or something similar to that would be helpful.

        Issue Links

          Activity

          Hide
          Felicia Berryman added a comment -

          My first description doesn't make much sense... See again below:

          If I go to http://MOODLE-SERVER/admin/innodb.php and click yes to:
          "Are you sure you want convert all your tables to the InnoDB format?"
          and then later revisit http://MOODLE-SERVER/admin/innodb.php after the conversion is done, all I see is the same question asking me if I want to convert.

          I think seeing a message that said something like:
          "The conversion to InnoDB was last run on XYZ date. You do not need to reconvert."
          or something similar to that would be helpful.

          Show
          Felicia Berryman added a comment - My first description doesn't make much sense... See again below: If I go to http://MOODLE-SERVER/admin/innodb.php and click yes to: "Are you sure you want convert all your tables to the InnoDB format?" and then later revisit http://MOODLE-SERVER/admin/innodb.php after the conversion is done, all I see is the same question asking me if I want to convert. I think seeing a message that said something like: "The conversion to InnoDB was last run on XYZ date. You do not need to reconvert." or something similar to that would be helpful.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Assigning to Petr

          Show
          Eloy Lafuente (stronk7) added a comment - Assigning to Petr
          Hide
          Petr Škoda added a comment -

          Thanks for the report, I have added detection of existing InnoDB tables.

          Petr

          Show
          Petr Škoda added a comment - Thanks for the report, I have added detection of existing InnoDB tables. Petr
          Hide
          Dan Poltawski added a comment -

          I've integrated this, thanks

          Show
          Dan Poltawski added a comment - I've integrated this, thanks
          Hide
          Dan Poltawski added a comment -

          THis works, but then I discovered.. MDL-33001

          Show
          Dan Poltawski added a comment - THis works, but then I discovered.. MDL-33001
          Hide
          Eloy Lafuente (stronk7) added a comment -

          U P S T R E A M I Z E D !

          Many thanks for the hard work, closing this as fixed.

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - U P S T R E A M I Z E D ! Many thanks for the hard work, closing this as fixed. Ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: