Moodle

MNET: Language string not displaying correctly

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Trivial Trivial
  • Resolution: Fixed
  • Affects Version/s: 2.0, 2.1.4, 2.2.1, 2.3
  • Fix Version/s: 2.1.5, 2.2.2
  • Component/s: MNet
  • Labels:
  • Testing Instructions:
    Hide
    1. Enable MNet on two sites
    2. On site one proceed to start adding the second as a peer
    3. When reviewing the details before saving delete the key and attempt to save
    4. Check you get a required notice
    5. Refresh the browser so you get the key back and save
    6. Now edit the saved peer and remove the public key
    7. Ensure you get an error again
    Show
    Enable MNet on two sites On site one proceed to start adding the second as a peer When reviewing the details before saving delete the key and attempt to save Check you get a required notice Refresh the browser so you get the key back and save Now edit the saved peer and remove the public key Ensure you get an error again
  • Difficulty:
    Easy
  • Affected Branches:
    MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
  • Fixed Branches:
    MOODLE_21_STABLE, MOODLE_22_STABLE
  • Pull from Repository:
  • Pull Master Branch:
    wip-MDL-25299-m23
  • Pull Master Diff URL:

Description

Hi Sam,

Not sure who is responsible for the mnet component so assigned to you

When you submit the form when editing a host with an empty public key you are displayed with an incomplete language string.

"The key is not a valid SSL key. (3: The subject of the certificate:
{$a->subject}
does not match the host it came from:
{$a->host}.
)"

Regards,

Mark

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Sam Hemelryk added a comment -

Putting this up for peer-review now. I've implemented better validation of the public key field.

Show
Sam Hemelryk added a comment - Putting this up for peer-review now. I've implemented better validation of the public key field.
Hide
Permalink
Ankit Agarwal added a comment -

Hi Sam,
Master compare url is giving 404 errors
Had a look on stables and changes look good to me.
Thanks

Show
Ankit Agarwal added a comment - Hi Sam, Master compare url is giving 404 errors Had a look on stables and changes look good to me. Thanks
Hide
Permalink
Sam Hemelryk added a comment -

Thanks Ankit, fixed up the missing branch and this is up for integration now.

Cheers
Sam

Show
Sam Hemelryk added a comment - Thanks Ankit, fixed up the missing branch and this is up for integration now. Cheers Sam
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Integrated, thanks!

Show
Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
Hide
Permalink
Andrew Davis added a comment -

Works as described although I had to go back to the main peers page and start the add peer process over again to get the key back. Passing.

There are some fairly obvious usability problems, no cancel button on the edit peer page, "Peers" in the breadcrumbs isnt clickable, but I guess that isnt worth bothering with what with all of this eventually being replaced by web services.

Show
Andrew Davis added a comment - Works as described although I had to go back to the main peers page and start the add peer process over again to get the key back. Passing. There are some fairly obvious usability problems, no cancel button on the edit peer page, "Peers" in the breadcrumbs isnt clickable, but I guess that isnt worth bothering with what with all of this eventually being replaced by web services.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Some changes to Moodle should be milestones in the project by themselves.

This is not the case and your fix is not so important, but your collaboration is highly appreciated, thanks!

Closing as fixed, ciao

Show
Eloy Lafuente (stronk7) added a comment - Some changes to Moodle should be milestones in the project by themselves. This is not the case and your fix is not so important, but your collaboration is highly appreciated, thanks! Closing as fixed, ciao

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: