Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-25314

@ob_end_flush() in a few places...

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: General
    • Labels:
      None
    • Database:
      Any
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      Just detected a bunch of remaining:

      @ob_end_flush();

      courrences here and there, more noticeably in filelib, causing all my test sites to stop sending files completely (because I've disabled the shut-up operator).

      I think it would be nice to change them to something avoiding those @ if possible, like we recently did in unittests and some ob_end_clean() uses. Perhaps encapsulating the whole loop within a function or so.

      grep -r '@ob_end_flush' *
       
      admin/bloglevelupgrade.php:while(@ob_end_flush());
      admin/multilangupgrade.php:while(@ob_end_flush());
      admin/report/security/index.php:while(@ob_end_flush());
      lib/adminlib.php:    while(@ob_end_flush());
      lib/filelib.php:    while (@ob_end_flush()); //flush the buffers - save memory and disable sid rewrite
      lib/filelib.php:        while (@ob_end_flush()); //flush the buffers - save memory and disable sid rewrite
      lib/filelib.php:            while (@ob_end_flush()); //flush the buffers - save memory and disable sid rewrite
      lib/filelib.php:            while (@ob_end_flush()); //flush the buffers - save memory and disable sid rewrite
      lib/filelib.php:            while (@ob_end_flush()); //flush the buffers - save memory and disable sid rewrite
      lib/filelib.php:        while (@ob_end_flush()); //flush the buffers - save memory and disable sid rewrite
      lib/filelib.php:            while (@ob_end_flush()); //flush the buffers - save memory and disable sid rewrite
      lib/filelib.php:            while (@ob_end_flush()); //flush the buffers - save memory and disable sid rewrite
      lib/filelib.php:            while (@ob_end_flush()); //flush the buffers - save memory and disable sid rewrite
      lib/filelib.php:        while (@ob_end_flush()); //flush the buffers - save memory and disable sid rewrite
      lib/filelib.php:        while (@ob_end_flush()); //flush the buffers - save memory and disable sid rewrite
      mod/chat/gui_header_js/jsupdated.php:    @ob_end_flush();
      mod/chat/gui_header_js/jsupdated.php:            @ob_end_flush();
      mod/chat/gui_header_js/jsupdated.php:            @ob_end_flush();
      mod/chat/gui_header_js/jsupdated.php:        @ob_end_flush();
      search/indexer.php:@ob_end_flush();
      search/tests/index.php:    @ob_end_flush();

        Attachments

          Activity

            People

            Assignee:
            skodak Petr Skoda
            Reporter:
            stronk7 Eloy Lafuente (stronk7)
            Tester:
            Nobody
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              24/Nov/10