Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: 1.9.5, 1.9.8
    • Fix Version/s: None
    • Component/s: Assignment (2.2)
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Rank:
      2794

      Description

      Some student submissions made to the assignment activity are invisible to the instructors (1.9.5 and 1.9.8)

      Description:
      Student uploads a file or posts online text in the Assignment activity. Student can see his own submission just fine there.
      Instructors do not. But they can see the rest of the submissions in the same activity.
      Instructor can re-sort the assignment submissions page by any other column, e.g. by Last Modified. This will magically reveal the "missing" submission.

      I have marked it as major, because instructors assume that such student missed the assignment, and give that student a bad grade.

      We found out that the cause of the bug is multiple entries into the database. (e.g. student managed to click on Upload button multiple times)
      We have tried to reproduce the bug, but we were not able to. It seems that certain conditions need to be just right for the bug to happen. It might be server lagging, or pushing the submit button at a specific interval.
      Querying the database found 67 duplicate entries by users from 200,000 entries in the assignment_submissions table that have been submitted in total. So, it seems to be a very rare bug. However, it does happen

      Related discussions:

        Activity

        Hide
        Markus Strobl added a comment -

        I have nearly the same problem, however for ALL instructors and administrators are alle submissions invisible; only the submission as a test from tem instructor is listed

        Show
        Markus Strobl added a comment - I have nearly the same problem, however for ALL instructors and administrators are alle submissions invisible; only the submission as a test from tem instructor is listed
        Hide
        Mikeles added a comment -

        Hello to all

        after reviewing line by line all libraries of submissions, i found the problem

        in \mod\assignment\lib.php

        line 1151 (or near), we have the sql query, only change it:

        COALESCE(SIGN(SIGN(s.timemarked) + SIGN(s.timemarked - s.timemodified)), 0) AS status ';

        COALESCE(SIGN(CAST(s.timemarked as SIGNED) + SIGN(CAST(s.timemarked as SIGNED) - CAST(s.timemodified as SIGNED))), 0) AS status ';

        i'm using mysql 5.5.8

        when the clause try order this send a error because, timemarked sometimes is null and no have sign (is UNSIGNED in the DB)

        regards

        Show
        Mikeles added a comment - Hello to all after reviewing line by line all libraries of submissions, i found the problem in \mod\assignment\lib.php line 1151 (or near), we have the sql query, only change it: COALESCE(SIGN(SIGN(s.timemarked) + SIGN(s.timemarked - s.timemodified)), 0) AS status '; COALESCE(SIGN(CAST(s.timemarked as SIGNED) + SIGN(CAST(s.timemarked as SIGNED) - CAST(s.timemodified as SIGNED))), 0) AS status '; i'm using mysql 5.5.8 when the clause try order this send a error because, timemarked sometimes is null and no have sign (is UNSIGNED in the DB) regards
        Hide
        Michael de Raadt added a comment -

        Thanks for reporting this issue.

        We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported.

        If you believe that this issue is still relevant to current versions (2.3 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

        Michael d;

        4d6f6f646c6521

        Show
        Michael de Raadt added a comment - Thanks for reporting this issue. We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported. If you believe that this issue is still relevant to current versions (2.3 and beyond), please comment on the issue. Issues left inactive for a further month will be closed. Michael d; 4d6f6f646c6521
        Hide
        Michael de Raadt added a comment -

        I'm closing this issue as it has been inactive for over a year has been recorded as affecting versions that are no longer supported.

        If you still believe this is an issue in supported versions, please report a new issue.

        Show
        Michael de Raadt added a comment - I'm closing this issue as it has been inactive for over a year has been recorded as affecting versions that are no longer supported. If you still believe this is an issue in supported versions, please report a new issue.

          People

          • Votes:
            7 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: