Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-25357

Allow more than 52 sections or just a section 0 in a course

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0, 2.1, 2.2
    • Fix Version/s: 2.1.1
    • Component/s: Course
    • Labels:
    • Testing Instructions:
      Hide

      Go to the course default settings page, and see if the new "'Maximum for number of weeks/topics" setting is there.

      Set that setting to something different.

      Create a new course, and/or edit an existing course. Make sure that number of week/topics option goes up to the maximum you set.

      Show
      Go to the course default settings page, and see if the new "'Maximum for number of weeks/topics" setting is there. Set that setting to something different. Create a new course, and/or edit an existing course. Make sure that number of week/topics option goes up to the maximum you set.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-25357_wip

      Description

      There are occasions when more than 52 sections can be needed in a course, yet there is no way to create a greater number of sections except to directly modify the code--if one has the necessary permissions to do so. Could there be a setting in the site level course/course default settings page called "MaximumSections" which could have as a default "52" but which would allow the site admin to manually enter another number if required? I think that a simply text box entry would be preferable to a pulldown selection for this.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              timhunt Tim Hunt added a comment -

              Here is a patch that does several things:

              1. Allows the admin to choose the maximum value of num weeks to 52, 104 or 208. (Note that OU codebase currently has the course settings form hacked to allow choices up to 200.)
              2. Allows 0 sections as a valid choice on both the course settings form, and on the corresponding admin setting. In some course formats, section 0 looks very different from the 'real' sections, so you may well want a course with only a section 0. Again, we use that at the OU.
              3. Finally I spotted a <br/> in a lang string that got rendered as <br/> on-screen, which clearly sucks, so I fixed that.

              https://github.com/timhunt/moodle/compare/master...MDL-25357_wip

              Comments please.

              Show
              timhunt Tim Hunt added a comment - Here is a patch that does several things: Allows the admin to choose the maximum value of num weeks to 52, 104 or 208. (Note that OU codebase currently has the course settings form hacked to allow choices up to 200.) Allows 0 sections as a valid choice on both the course settings form, and on the corresponding admin setting. In some course formats, section 0 looks very different from the 'real' sections, so you may well want a course with only a section 0. Again, we use that at the OU. Finally I spotted a <br/> in a lang string that got rendered as <br/> on-screen, which clearly sucks, so I fixed that. https://github.com/timhunt/moodle/compare/master...MDL-25357_wip Comments please.
              Hide
              timhunt Tim Hunt added a comment -

              Adding a couple of watchers. Thanks.

              Show
              timhunt Tim Hunt added a comment - Adding a couple of watchers. Thanks.
              Hide
              mchurch Mike Churchward added a comment -

              I like the idea, and we frequently get asked for this. But why limit the choices to 52, 104 and 208?

              Show
              mchurch Mike Churchward added a comment - I like the idea, and we frequently get asked for this. But why limit the choices to 52, 104 and 208?
              Hide
              timhunt Tim Hunt added a comment -

              Well, I had to do something. 52 is the old setting, so had to be included. The OU wants 200, so actually I did 1, 2, and 4 x 52. However, better suggestions welcome.

              Show
              timhunt Tim Hunt added a comment - Well, I had to do something. 52 is the old setting, so had to be included. The OU wants 200, so actually I did 1, 2, and 4 x 52. However, better suggestions welcome.
              Hide
              mchurch Mike Churchward added a comment -

              I guess a free entry numeric value would be a bad idea?
              Is there a "real" limit that should be used for the maximum? Something that causes it to perform badly or something?

              Show
              mchurch Mike Churchward added a comment - I guess a free entry numeric value would be a bad idea? Is there a "real" limit that should be used for the maximum? Something that causes it to perform badly or something?
              Hide
              timhunt Tim Hunt added a comment -

              I wonder if there is any chance of anyone looking at this?

              Show
              timhunt Tim Hunt added a comment - I wonder if there is any chance of anyone looking at this?
              Hide
              timhunt Tim Hunt added a comment -

              Michael, I'm pinging you to see if I can get this looked at. Thanks.

              Show
              timhunt Tim Hunt added a comment - Michael, I'm pinging you to see if I can get this looked at. Thanks.
              Hide
              timhunt Tim Hunt added a comment -

              Changing to a text input, and submitting for integration as suggested by Mike.

              If possible, please could we have this in 2.1.1 as well as on master. Thanks.

              Show
              timhunt Tim Hunt added a comment - Changing to a text input, and submitting for integration as suggested by Mike. If possible, please could we have this in 2.1.1 as well as on master. Thanks.
              Hide
              samhemelryk Sam Hemelryk added a comment -

              Thanks Tim - I discussed this with Eloy and we are happy for it to go in.
              I will add the label `qa test required` to signify to Helen that there should be a QA test created for this functionality.

              Cheers
              Sam

              Show
              samhemelryk Sam Hemelryk added a comment - Thanks Tim - I discussed this with Eloy and we are happy for it to go in. I will add the label `qa test required` to signify to Helen that there should be a QA test created for this functionality. Cheers Sam
              Hide
              nebgor Aparup Banerjee added a comment -

              i'm guessing this should be tested on integration/master and integration/MOODLE_21_STABLE

              Show
              nebgor Aparup Banerjee added a comment - i'm guessing this should be tested on integration/master and integration/MOODLE_21_STABLE
              Hide
              samhemelryk Sam Hemelryk added a comment -

              Yip it was integrated to those two, sorry I see I forgot to mention that in my message

              Show
              samhemelryk Sam Hemelryk added a comment - Yip it was integrated to those two, sorry I see I forgot to mention that in my message
              Hide
              nebgor Aparup Banerjee added a comment -

              this worked well without a hitch.

              Show
              nebgor Aparup Banerjee added a comment - this worked well without a hitch.
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Landed upstream, many thanks!

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Landed upstream, many thanks!

                People

                • Votes:
                  2 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    1/Aug/11