Moodle
  1. Moodle
  2. MDL-25388

Confusing options when restoring an activity backup

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: 2.0
    • Fix Version/s: None
    • Component/s: Backup
    • Labels:
    • Affected Branches:
      MOODLE_20_STABLE
    • Rank:
      470

      Description

      When restoring an activity backup, you are given several options:

      • Restore as a new course - doesn't seem to make sense
      • Merge the backup course into the existing course - I guess this means "Add the activity to an existing course"
      • Delete the contents of the existing course and then restore - also doesn't seem to make sense

      Is it possible to detect that the backup file is just one activity and then only provide the option "Add the activity to an existing course"?

      Also, in step 7 of the restore process it states "The course was restored successfully, clicking the continue button below will take you to view the course you restored." Again this doesn't make sense because only an activity was restored.

      1. testbackup.php
        2 kB
        Eloy Lafuente (stronk7)
      2. testrestore.php
        3 kB
        Eloy Lafuente (stronk7)

        Issue Links

          Activity

          Hide
          Eloy Lafuente (stronk7) added a comment -

          100% agree with everything, so I'm going to:

          1) take out the restore as a new course
          2) take out the "Delete the contents..." option
          3) Try to change the strings to be "add the activity to an existing course"
          4) Try to redirect to activity instead of course a the end of the process

          That will make "add the activity to existing course" the only option available, much like the import course one.

          Show
          Eloy Lafuente (stronk7) added a comment - 100% agree with everything, so I'm going to: 1) take out the restore as a new course 2) take out the "Delete the contents..." option 3) Try to change the strings to be "add the activity to an existing course" 4) Try to redirect to activity instead of course a the end of the process That will make "add the activity to existing course" the only option available, much like the import course one.
          Hide
          Helen Foster added a comment -

          Sounds perfect, nice that you always agree with me (well, nearly always!)

          Show
          Helen Foster added a comment - Sounds perfect, nice that you always agree with me (well, nearly always!)
          Hide
          Tim Hunt added a comment -

          More problems with the backup and restore UI:

          1. One of the annoying things about backup in 1.9 is that if you got a fatal error while doing the backup, you could not just click reload to try the backup again once you had fixed the bugs. 2.0 backup seems to have the same flaw. You have to click back many times and start again, even though it looks like clicking back once, then reload, then 'Perform backup' again might work.

          2. Also, 'Schema settings' are not words that mean anything to a teacher.

          3. Wow! you actually managed to have more steps in the restore wizard in 2.0 than in 1.9. What an achievement!

          Show
          Tim Hunt added a comment - More problems with the backup and restore UI: 1. One of the annoying things about backup in 1.9 is that if you got a fatal error while doing the backup, you could not just click reload to try the backup again once you had fixed the bugs. 2.0 backup seems to have the same flaw. You have to click back many times and start again, even though it looks like clicking back once, then reload, then 'Perform backup' again might work. 2. Also, 'Schema settings' are not words that mean anything to a teacher. 3. Wow! you actually managed to have more steps in the restore wizard in 2.0 than in 1.9. What an achievement!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Update:

          • I've created PULL-385 about to reduce the options available when restoring 1-activity backups.

          TODO:

          • Try to redirect to activity (and fix message) at the end of the process.
          • Change "schema settings" by something else more meaningful (ideas welcome).

          Tim, I understand that's annoying if you are developing and continuously trying and trying. But IMO we must prevent "repeated" backups and (specially) restores (on purpose) from the UI. Alternatively, you can easily build one php script to test your backups in development. I'm attaching here the ones I use in my dev environment, hope they help. Clean them, they have various unnecessary lines.

          About 3, well... yes... and we feel we can still add 5 or 6 more pages, just give us time, lol.

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Update: I've created PULL-385 about to reduce the options available when restoring 1-activity backups. TODO: Try to redirect to activity (and fix message) at the end of the process. Change "schema settings" by something else more meaningful (ideas welcome). Tim, I understand that's annoying if you are developing and continuously trying and trying. But IMO we must prevent "repeated" backups and (specially) restores (on purpose) from the UI. Alternatively, you can easily build one php script to test your backups in development. I'm attaching here the ones I use in my dev environment, hope they help. Clean them, they have various unnecessary lines. About 3, well... yes... and we feel we can still add 5 or 6 more pages, just give us time, lol. Ciao
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Ping, this is a request for finding a good replacement for "schema settings". Any idea will be welcome.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Ping, this is a request for finding a good replacement for "schema settings". Any idea will be welcome. TIA and ciao
          Hide
          Helen Foster added a comment -

          Just one small point regarding restoring a 1-activity backup. In step 7, the following message is displayed:

          The course was restored successfully, clicking the continue button below will take you to view the course you restored.

          How about changing the wording to:

          The backup was restored successfully. Click the continue button to view the restored course or activity.

          Show
          Helen Foster added a comment - Just one small point regarding restoring a 1-activity backup. In step 7, the following message is displayed: The course was restored successfully, clicking the continue button below will take you to view the course you restored. How about changing the wording to: The backup was restored successfully. Click the continue button to view the restored course or activity.
          Hide
          Michael de Raadt added a comment -

          Thanks for reporting this issue.

          We have detected that this issue has been inactive for over a year. It was reported as affecting versions that are no longer supported.

          If you believe that this issue is still relevant to current versions (2.5 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

          Michael d.

          TW9vZGxlDQo=

          Show
          Michael de Raadt added a comment - Thanks for reporting this issue. We have detected that this issue has been inactive for over a year. It was reported as affecting versions that are no longer supported. If you believe that this issue is still relevant to current versions (2.5 and beyond), please comment on the issue. Issues left inactive for a further month will be closed. Michael d. TW9vZGxlDQo=
          Hide
          Michael de Raadt added a comment -

          I'm closing this issue as it has been inactive for over a year has been recorded as affecting versions that are no longer supported.

          This is being done as part of a bulk annual clean-up of issues.

          If you still believe this is an issue in supported versions, please create a new issue.

          Show
          Michael de Raadt added a comment - I'm closing this issue as it has been inactive for over a year has been recorded as affecting versions that are no longer supported. This is being done as part of a bulk annual clean-up of issues. If you still believe this is an issue in supported versions, please create a new issue.

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: