Moodle

Redundant call to time in format.php of topics course format

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Trivial Trivial
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.2
  • Component/s: Course
  • Labels:
    None
  • Environment:
    All

Description

In version 1.133 line 135 of format.php of the topics course format there is a call to time() which is assigned to the variable $timenow, but this variable is never used:

$timenow = time();

Therefore it is redundant and uses some processing time pointlessly.

Issue Links

has a non-specific relationship to

Bug - A problem which impairs or prevents Moodle from functioning correctly. CONTRIB-2660 Redundant call to time in format.php

  • Trivial - Cosmetic problem like misspelt words or misaligned text
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Dan Poltawski added a comment -

I will push this change when we have a 2.1 development branch

Show
Dan Poltawski added a comment - I will push this change when we have a 2.1 development branch
Hide
Permalink
Gareth J Barnard added a comment -

With respect Dan, if you wait until you have a branch will that not duplicate the issue into two branches? And then the fix will have to be applied twice. It is just a simple task of deleting the line - why the procrastination?

Show
Gareth J Barnard added a comment - With respect Dan, if you wait until you have a branch will that not duplicate the issue into two branches? And then the fix will have to be applied twice. It is just a simple task of deleting the line - why the procrastination?
Hide
Permalink
Dan Poltawski added a comment -

Hi Gareth - I wait for a development branch because this is a minor issue of little consequence and its best not to make so many changes on the stable branch unless necessary.

Submitting for integration now, sorry it took so long.

Show
Dan Poltawski added a comment - Hi Gareth - I wait for a development branch because this is a minor issue of little consequence and its best not to make so many changes on the stable branch unless necessary. Submitting for integration now, sorry it took so long.
Hide
Permalink
Sam Hemelryk added a comment -

Thanks Dan, this has been integrated now.
Quite right in that this really only belongs in the master branch.

Cheers
Sam

Show
Sam Hemelryk added a comment - Thanks Dan, this has been integrated now. Quite right in that this really only belongs in the master branch. Cheers Sam
Hide
Permalink
Aparup Banerjee added a comment -

no errors seen.

Show
Aparup Banerjee added a comment - no errors seen.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Sent upstream and closing, many thanks!

Show
Eloy Lafuente (stronk7) added a comment - Sent upstream and closing, many thanks!

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: