Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Trivial
-
Resolution: Fixed
-
Affects Version/s: 2.0
-
Fix Version/s: 2.2
-
Component/s: Course
-
Labels:None
-
Environment:All
-
Testing Instructions:
-
Difficulty:Easy
-
Affected Branches:MOODLE_20_STABLE
-
Fixed Branches:MOODLE_22_STABLE
-
Pull from Repository:
-
Pull Master Branch:MDL_25417
Description
In version 1.133 line 135 of format.php of the topics course format there is a call to time() which is assigned to the variable $timenow, but this variable is never used:
$timenow = time();
Therefore it is redundant and uses some processing time pointlessly.
Gliffy Diagrams
Attachments
Issue Links
- has a non-specific relationship to
-
-
- Closed
-
Activity
- All
- Comments
- Work Log
- History
- Activity
- Links Hierarchy
With respect Dan, if you wait until you have a branch will that not duplicate the issue into two branches? And then the fix will have to be applied twice. It is just a simple task of deleting the line - why the procrastination?
Hi Gareth - I wait for a development branch because this is a minor issue of little consequence and its best not to make so many changes on the stable branch unless necessary.
Submitting for integration now, sorry it took so long.
Thanks Dan, this has been integrated now.
Quite right in that this really only belongs in the master branch.
Cheers
Sam
no errors seen.
Sent upstream and closing, many thanks!
I will push this change when we have a 2.1 development branch