Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30213 format properly all CSS in CORE themes
  3. MDL-25511

format properly Canvas CSS

          Details

          • Type: Sub-task
          • Status: Closed
          • Priority: Minor
          • Resolution: Fixed
          • Affects Version/s: 2.0.5, 2.1.2, 2.2
          • Fix Version/s: 2.2
          • Component/s: Themes
          • Labels:
          • Testing Instructions:
            Hide

            It's only a format change (one liners to multiple, clean tabs...) so no changes are expected at all.

            In any case:

            1) pick a canvas based theme (fusion, nimble...) Look for $THEME->parents to find more if you want.
            2) Use it overall and check that nothing is visibly broken.

            Ciao

            Show
            It's only a format change (one liners to multiple, clean tabs...) so no changes are expected at all. In any case: 1) pick a canvas based theme (fusion, nimble...) Look for $THEME->parents to find more if you want. 2) Use it overall and check that nothing is visibly broken. Ciao
          • Difficulty:
            Easy
          • Affected Branches:
            MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
          • Fixed Branches:
            MOODLE_22_STABLE
          • Pull from Repository:
          • Pull Master Branch:
            wip-MDL-25511
          • Pull Master Diff URL:

            Description

            See:

            http://moodle.org/mod/forum/discuss.php?d=162731#p712865

            Basically, this task is to change all of the core theme CSS from one line to a multi-line format.

            Here's what I propose:

            selector {
            property: value;
            }

              Gliffy Diagrams

                Attachments

                  Issue Links

                  will help resolve

                  Improvement - An enhancement to an existing Moodle feature. MDL-30213 format properly all CSS in CORE themes

                  • Minor - Minor loss of function where workaround is possible
                  • Closed

                    Activity

                    Ascending order - Click to sort in descending order
                    Hide
                    Permalink
                    aquisse Thomas Hanley added a comment -

                    +1, this change would remove an unnecessary and frustrating obstacle to customising themes

                    Show
                    aquisse Thomas Hanley added a comment - +1, this change would remove an unnecessary and frustrating obstacle to customising themes
                    Hide
                    Permalink
                    lazydaisy Mary Evans added a comment -

                    This looks like a big job! I think I might start on Base theme, a page a day!

                    Show
                    lazydaisy Mary Evans added a comment - This looks like a big job! I think I might start on Base theme, a page a day!
                    Hide
                    Permalink
                    lazydaisy Mary Evans added a comment -

                    Work started...I may be some time!

                    Show
                    lazydaisy Mary Evans added a comment - Work started...I may be some time!
                    Hide
                    Permalink
                    stronk7 Eloy Lafuente (stronk7) added a comment -

                    Plz, take a look to http://tracker.moodle.org/browse/MDL-22351?focusedCommentId=129578&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-129578
                    about how we are going to handle all these...TIA!

                    Show
                    stronk7 Eloy Lafuente (stronk7) added a comment - Plz, take a look to http://tracker.moodle.org/browse/MDL-22351?focusedCommentId=129578&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-129578 about how we are going to handle all these...TIA!
                    Hide
                    Permalink
                    stronk7 Eloy Lafuente (stronk7) added a comment -

                    Integrated, thanks!

                    Show
                    stronk7 Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
                    Hide
                    Permalink
                    stronk7 Eloy Lafuente (stronk7) added a comment -

                    Note: plz always you submit something to integration, specify in testing instructions what is expected to do on testing. It can go from "nothing to test" (explaining why) to anything else, with the detail necessary for any tester to test it properly.

                    Ciao

                    Show
                    stronk7 Eloy Lafuente (stronk7) added a comment - Note: plz always you submit something to integration, specify in testing instructions what is expected to do on testing. It can go from "nothing to test" (explaining why) to anything else, with the detail necessary for any tester to test it properly. Ciao
                    Hide
                    Permalink
                    abgreeve Adrian Greeve added a comment -

                    I applied fusion and nimble. Tested in Firefox and Chrome. I couldn't find any problems.

                    Show
                    abgreeve Adrian Greeve added a comment - I applied fusion and nimble. Tested in Firefox and Chrome. I couldn't find any problems.
                    Hide
                    Permalink
                    stronk7 Eloy Lafuente (stronk7) added a comment -

                    Yes, you got this finally upstream, just in time for Moodle 2.2beta. Congrats and thanks!

                    Ciao

                    Show
                    stronk7 Eloy Lafuente (stronk7) added a comment - Yes, you got this finally upstream, just in time for Moodle 2.2beta. Congrats and thanks! Ciao

                      People

                      • Votes:
                        6 Vote for this issue
                        Watchers:
                        7 Start watching this issue

                        Dates

                        • Created:
                          Updated:
                          Resolved:
                          Fix Release Date:
                          5/Dec/11