Details
-
Type:
Sub-task
-
Status:
Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.0.5, 2.1.2, 2.2
-
Fix Version/s: 2.2
-
Component/s: Themes
-
Labels:
-
Testing Instructions:Hide
It's only a format change (one liners to multiple, clean tabs...) so no changes are expected at all.
In any case:
1) pick a canvas based theme (fusion, nimble...) Look for $THEME->parents to find more if you want.
2) Use it overall and check that nothing is visibly broken.Ciao
ShowIt's only a format change (one liners to multiple, clean tabs...) so no changes are expected at all. In any case: 1) pick a canvas based theme (fusion, nimble...) Look for $THEME->parents to find more if you want. 2) Use it overall and check that nothing is visibly broken. Ciao -
Difficulty:Easy
-
Affected Branches:MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
-
Fixed Branches:MOODLE_22_STABLE
-
Pull from Repository:
-
Pull Master Branch:wip-
MDL-25511 -
Pull Master Diff URL:
Description
See:
http://moodle.org/mod/forum/discuss.php?d=162731#p712865
Basically, this task is to change all of the core theme CSS from one line to a multi-line format.
Here's what I propose:
selector {
property: value;
}
Issue Links
- will help resolve
-
MDL-30213
format properly all CSS in CORE themes
-
Activity
This looks like a big job! I think I might start on Base theme, a page a day!
Note: plz always you submit something to integration, specify in testing instructions what is expected to do on testing. It can go from "nothing to test" (explaining why) to anything else, with the detail necessary for any tester to test it properly.
Ciao
Yes, you got this finally upstream, just in time for Moodle 2.2beta. Congrats and thanks!
Ciao
+1, this change would remove an unnecessary and frustrating obstacle to customising themes