Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-25525

Calendar tooltip icons don't appear for components other than moodle

    Details

    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      Calendar library doesn't pass the component variable to $OUTPUT->pix_icon which makes pix_icon default to only looking in the core 'moodle' component, and not the component in question (i.e. activities).

      To reproduce:
      1. Add an activity (e.g. an Assignment) with a due date
      2. Add a calendar block to course page
      3. Hover over calendar event - tooltip has broken image (shows alt text)
      See screenshot for example.

      Expected result: See the activities icon, not alt-text.

      Patch that fixes this attached.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              poltawski Dan Poltawski added a comment -

              Thanks, verified and tested.

              I've created PULL-64 to get this change merged

              Show
              poltawski Dan Poltawski added a comment - Thanks, verified and tested. I've created PULL-64 to get this change merged
              Hide
              skodak Petr Skoda added a comment -

              closing, thanks

              Show
              skodak Petr Skoda added a comment - closing, thanks

                People

                • Votes:
                  1 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    21/Feb/11