Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-25536

IMS Enterprise module configuration data possible name collision

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: None
    • Component/s: Enrolments
    • Labels:
      None
    • Environment:
      N/A
    • Database:
      Any
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_20_STABLE

      Description

      In Moodle 1.9, we run the modified IMS module "Minted IMS Enterprise plugin v2.3" from the Univ of Sussex, with some additional enhancements for Thunderbird School of Global Management (see http://help.thunderbird.edu/content/enhanced-ims-xml-enrollment-module)

      While implementing this for Moodle 2, we decided to use the new feature to have global settings specific to the plugin (instead of the v1.9 module which overloaded the use of global $CFG->vars from the original IMS module).
      I found a name space collision when trying to isolate all plugin variables into it's own section.
      A function in the IMS enrolment module reads plugin config values from the table without the use of the plugin name.

      The fix is nearly trivial:
      In /enrol/imsenterprise/lib.php, line 752
      = $DB->get_field('config_plugins', 'value', array('name'=>'imsrolemap' . $imsrolenum));
      change to
      = $DB->get_field('config_plugins', 'value', array('plugin'=>'enrol_imsenterprise','name'=>'imsrolemap' . $imsrolenum));

      Could you kindly consider adding this to the source tree.
      Thanks,
      Johan

        Gliffy Diagrams

          Activity

          Hide
          skodak Petr Skoda added a comment -

          Hello,
          should be fixed now, please test.
          Thanks for the report!

          Petr Škoda

          Show
          skodak Petr Skoda added a comment - Hello, should be fixed now, please test. Thanks for the report! Petr Škoda

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: