Moodle
  1. Moodle
  2. MDL-25561

Make name in user view of gradebook clickable

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.10, 2.0.6, 2.1.3, 2.2, 2.3
    • Fix Version/s: 2.1.4, 2.2.1
    • Component/s: Gradebook
    • Labels:
    • Environment:
      all
    • Database:
      Any
    • Testing Instructions:
      Hide

      As a teacher or admin go into a course with at least two students. Click on grades in course administration then select user report from the gradebook navigation drop down (may be tabs depending on your set up)

      The user report adds a second navigation drop down that allows you to select a student.

      Select a single student. Check that both the general gradebook navigation drop down and the student selection drop down are displayed.
      Check that the students name in the title is clickable and clicking it takes you to that student's course profile.

      Go back to the user report and select all users from the student selection drop down. Again, check that both navigation drop downs are displayed.
      Check that all student names are clickable and that they take you to the student's course profile.

      Show
      As a teacher or admin go into a course with at least two students. Click on grades in course administration then select user report from the gradebook navigation drop down (may be tabs depending on your set up) The user report adds a second navigation drop down that allows you to select a student. Select a single student. Check that both the general gradebook navigation drop down and the student selection drop down are displayed. Check that the students name in the title is clickable and clicking it takes you to that student's course profile. Go back to the user report and select all users from the student selection drop down. Again, check that both navigation drop downs are displayed. Check that all student names are clickable and that they take you to the student's course profile.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:
      MDL-25561_user_report_name_clickable

      Description

      I have large classes and near the end of the semester spend a lot of time in the gradebook, reviewing individual student work with the user view. When in this view, the user is selected from a long drop-down list, and then when the gradebook refreshes their name is top center of the page. This name is not linked- whereas almost everywhere within moodle student name/icons link directly to their profile. This is very convenient and would be a nice addition to the name in the user view of the gradebook, and make it more consistent with the rest of the environment. In my case I want to go to their profile to look at recent activity as a way of helping them bring up their grades. Given the user info is already on the page, this would be a VERY easy addition, (simply changing the name at the top to be a hyperlink to the user id).

        Gliffy Diagrams

        1. grades.png
          27 kB
        2. userlink.JPG
          61 kB

          Activity

          Hide
          Andrew Davis added a comment -

          Added testing instructions and a master branch. I will create branches for other versions after peer review.

          Show
          Andrew Davis added a comment - Added testing instructions and a master branch. I will create branches for other versions after peer review.
          Hide
          Andrew Davis added a comment -

          Note that the change in grade/lib.php fixes a bug in the 2.x versions where the student name wasn't being shown at all when you viewed the user report of a single user. Found and fixed that while I was making the student name a link.

          Show
          Andrew Davis added a comment - Note that the change in grade/lib.php fixes a bug in the 2.x versions where the student name wasn't being shown at all when you viewed the user report of a single user. Found and fixed that while I was making the student name a link.
          Hide
          Sam Hemelryk added a comment -

          Hi Andrew,

          Changes look good thanks!

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Hi Andrew, Changes look good thanks! Cheers Sam
          Hide
          Andrew Davis added a comment -

          Adding branches

          Show
          Andrew Davis added a comment - Adding branches
          Hide
          Aparup Banerjee added a comment -

          Thanks for that Andrew,
          I've integrated this and also fixed up some minor whitespaces.

          As we slowly move to focus on documentation i'm tempted to ask : Is there likely to be any documentation that might need minor updating regarding this change? (i doubt but just checking, perhaps screenshots etc? )

          ps (not patch related): just noting personally i'm not a fan of the print_grade_page_head() function mixing printing stuff with data retrieval. i also noticed this naming , print_grade_plugin_selector() vs grade_print_tabs() lol

          anyway this is up for testing

          Show
          Aparup Banerjee added a comment - Thanks for that Andrew, I've integrated this and also fixed up some minor whitespaces. As we slowly move to focus on documentation i'm tempted to ask : Is there likely to be any documentation that might need minor updating regarding this change? (i doubt but just checking, perhaps screenshots etc? ) ps (not patch related): just noting personally i'm not a fan of the print_grade_page_head() function mixing printing stuff with data retrieval. i also noticed this naming , print_grade_plugin_selector() vs grade_print_tabs() lol anyway this is up for testing
          Hide
          Ankit Agarwal added a comment -
          • By default it loads the grade report of "admin user" which should be "all users" when a teacher or admin views the report IMHO.
          • Can be unrelated issue but the results are not properly formatted when "all users" option is selected.(see attached pic)
            Stopping testing until above formatting issue can be a little further investigated.
            rest stuff works great.
          Show
          Ankit Agarwal added a comment - By default it loads the grade report of "admin user" which should be "all users" when a teacher or admin views the report IMHO. Can be unrelated issue but the results are not properly formatted when "all users" option is selected.(see attached pic) Stopping testing until above formatting issue can be a little further investigated. rest stuff works great.
          Hide
          Ankit Agarwal added a comment -

          I guess the issues are not related to this fix and were previously present.
          passing
          Thanks

          Show
          Ankit Agarwal added a comment - I guess the issues are not related to this fix and were previously present. passing Thanks
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Whoever decided one week was worth 14 days had really one bad idea. Anyway, the nightmare is over, so thanks for your, once again, amazing contributions. Many, many thanks!

          Now... disconnect, relax and enjoy the next days, yay!

          Closing...ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Whoever decided one week was worth 14 days had really one bad idea. Anyway, the nightmare is over, so thanks for your, once again, amazing contributions. Many, many thanks! Now... disconnect, relax and enjoy the next days, yay! Closing...ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: