Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: None
    • Component/s: Themes
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE

      Description

      The current implementation in check_browser_version() is problematic:

      • mobile ios devices are reported as Safari - but they are very different from the desktop/laptop sw
      • android is missing version test
      • MS specific default params are funny
      • version should default to no version

      There is another related problem in get_browser_version_classes(), I think that the ios devices should have a separate class there.

        Gliffy Diagrams

          Activity

          Hide
          Petr Skoda added a comment -

          Done, thanks SamH for the review and help. Hopefully all the agent detection is now more standardised and works in a consistent way. You can now use 'ios' or 'android' for device specific CSS hacks.

          Petr

          Show
          Petr Skoda added a comment - Done, thanks SamH for the review and help. Hopefully all the agent detection is now more standardised and works in a consistent way. You can now use 'ios' or 'android' for device specific CSS hacks. Petr

            People

            • Assignee:
              Petr Skoda
              Reporter:
              Petr Skoda
              Tester:
              Nobody
              Participants:
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: