Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-25611

cleanup browser detection code

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: None
    • Component/s: Themes
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE

      Description

      The current implementation in check_browser_version() is problematic:

      • mobile ios devices are reported as Safari - but they are very different from the desktop/laptop sw
      • android is missing version test
      • MS specific default params are funny
      • version should default to no version

      There is another related problem in get_browser_version_classes(), I think that the ios devices should have a separate class there.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            skodak Petr Skoda added a comment -

            Done, thanks SamH for the review and help. Hopefully all the agent detection is now more standardised and works in a consistent way. You can now use 'ios' or 'android' for device specific CSS hacks.

            Petr

            Show
            skodak Petr Skoda added a comment - Done, thanks SamH for the review and help. Hopefully all the agent detection is now more standardised and works in a consistent way. You can now use 'ios' or 'android' for device specific CSS hacks. Petr

              People

              • Assignee:
                skodak Petr Skoda
                Reporter:
                skodak Petr Skoda
                Tester:
                Nobody
                Participants:
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: