Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-25654

block_manager API is inconsistent. add_pretend_block and show_only_fake_blocks

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • 2.0.1
    • 2.0
    • Blocks
    • MOODLE_20_STABLE
    • MOODLE_20_STABLE

      This is a new API, so to have a stupid inconsistency in it like this really sucks.

      Petr and I prefer fake to pretend, so we will rename add_pretend_block to add_fake_block, and add a deprecated add_pretend_block method that just calls add_fake_block.

      Then fix all callers.

            timhunt Tim Hunt
            timhunt Tim Hunt
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.