Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-25654

block_manager API is inconsistent. add_pretend_block and show_only_fake_blocks

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0.1
    • Component/s: Blocks
    • Labels:
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      This is a new API, so to have a stupid inconsistency in it like this really sucks.

      Petr and I prefer fake to pretend, so we will rename add_pretend_block to add_fake_block, and add a deprecated add_pretend_block method that just calls add_fake_block.

      Then fix all callers.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              timhunt Tim Hunt added a comment -
              Show
              timhunt Tim Hunt added a comment - Petr, please review https://github.com/timhunt/moodle/compare/cvshead...wip_MDL-25654 .
              Hide
              skodak Petr Skoda added a comment -

              +2

              Show
              skodak Petr Skoda added a comment - +2
              Hide
              timhunt Tim Hunt added a comment -

              Pull request created: PULL-5.

              Show
              timhunt Tim Hunt added a comment - Pull request created: PULL-5.
              Hide
              skodak Petr Skoda added a comment -

              closing, thanks

              Show
              skodak Petr Skoda added a comment - closing, thanks

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    25/Dec/10