Moodle

Assign Roles icon disappears when using AJAX

Details

  • Database:
    PostgreSQL
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

Viewing a course page with javascript turned off in my profile, I have an 'Assign Roles' icon next to each item. With JS turned on, the Assign Roles options disappears.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Andrew Nicols added a comment -

No test for editing_assign in the for loop at resource_class.prototype.init_buttons in lib/ajax/section_classes.js therefore button doesn't get added back like the update button

Show
Andrew Nicols added a comment - No test for editing_assign in the for loop at resource_class.prototype.init_buttons in lib/ajax/section_classes.js therefore button doesn't get added back like the update button
Hide
Permalink
Andrew Nicols added a comment -

Add the assign roles button back. Does not fix the icon resizing issue (MDL-25682)

Show
Andrew Nicols added a comment - Add the assign roles button back. Does not fix the icon resizing issue ( MDL-25682 )
Hide
Permalink
Dan Poltawski added a comment -

Verified. The activity assign roles icon disapears.

Show
Dan Poltawski added a comment - Verified. The activity assign roles icon disapears.
Hide
Permalink
Dan Poltawski added a comment -

I've tested the patch and it does fix the issue, going to file a pull request.

Show
Dan Poltawski added a comment - I've tested the patch and it does fix the issue, going to file a pull request.
Hide
Permalink
Dan Poltawski added a comment -

PULL-42 submitted

Show
Dan Poltawski added a comment - PULL-42 submitted
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Moving to 2.0.2

Show
Eloy Lafuente (stronk7) added a comment - Moving to 2.0.2
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Closing as fixed. Will land upstream in hours, thanks Dan!

Show
Eloy Lafuente (stronk7) added a comment - Closing as fixed. Will land upstream in hours, thanks Dan!

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: