Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-25676

Assign Roles icon disappears when using AJAX

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0.2
    • Component/s: JavaScript
    • Labels:
    • Database:
      PostgreSQL
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      Viewing a course page with javascript turned off in my profile, I have an 'Assign Roles' icon next to each item. With JS turned on, the Assign Roles options disappears.

        Gliffy Diagrams

          Activity

          Hide
          dobedobedoh Andrew Nicols added a comment -

          No test for editing_assign in the for loop at resource_class.prototype.init_buttons in lib/ajax/section_classes.js therefore button doesn't get added back like the update button

          Show
          dobedobedoh Andrew Nicols added a comment - No test for editing_assign in the for loop at resource_class.prototype.init_buttons in lib/ajax/section_classes.js therefore button doesn't get added back like the update button
          Hide
          dobedobedoh Andrew Nicols added a comment -

          Add the assign roles button back. Does not fix the icon resizing issue (MDL-25682)

          Show
          dobedobedoh Andrew Nicols added a comment - Add the assign roles button back. Does not fix the icon resizing issue ( MDL-25682 )
          Hide
          poltawski Dan Poltawski added a comment -

          Verified. The activity assign roles icon disapears.

          Show
          poltawski Dan Poltawski added a comment - Verified. The activity assign roles icon disapears.
          Hide
          poltawski Dan Poltawski added a comment -

          I've tested the patch and it does fix the issue, going to file a pull request.

          Show
          poltawski Dan Poltawski added a comment - I've tested the patch and it does fix the issue, going to file a pull request.
          Hide
          poltawski Dan Poltawski added a comment -

          PULL-42 submitted

          Show
          poltawski Dan Poltawski added a comment - PULL-42 submitted
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          Moving to 2.0.2

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - Moving to 2.0.2
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          Closing as fixed. Will land upstream in hours, thanks Dan!

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - Closing as fixed. Will land upstream in hours, thanks Dan!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                21/Feb/11