Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 2.0
-
Fix Version/s: 2.0.2
-
Component/s: AJAX and JavaScript
-
Labels:
-
Database:PostgreSQL
-
Affected Branches:MOODLE_20_STABLE
-
Fixed Branches:MOODLE_20_STABLE
Description
Viewing a course page with javascript turned off in my profile, I have an 'Assign Roles' icon next to each item. With JS turned on, the Assign Roles options disappears.
Gliffy Diagrams
Activity
Add the assign roles button back. Does not fix the icon resizing issue (MDL-25682)
Show
Andrew Nicols
added a comment - Add the assign roles button back. Does not fix the icon resizing issue ( MDL-25682 )
Verified. The activity assign roles icon disapears.
Show
Dan Poltawski
added a comment - Verified. The activity assign roles icon disapears.
I've tested the patch and it does fix the issue, going to file a pull request.
Show
Dan Poltawski
added a comment - I've tested the patch and it does fix the issue, going to file a pull request.
PULL-42 submitted
Show
Dan Poltawski
added a comment - PULL-42 submitted
Moving to 2.0.2
Show
Eloy Lafuente (stronk7)
added a comment - Moving to 2.0.2
Closing as fixed. Will land upstream in hours, thanks Dan!
Show
Eloy Lafuente (stronk7)
added a comment - Closing as fixed. Will land upstream in hours, thanks Dan!
No test for editing_assign in the for loop at resource_class.prototype.init_buttons in lib/ajax/section_classes.js therefore button doesn't get added back like the update button