Moodle
  1. Moodle
  2. MDL-25692

Database Activity Search Dropdowns not returning search results

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.9.10
    • Fix Version/s: 1.9.11
    • Labels:
    • Environment:
      MSSQL 2005, 2008
    • Database:
      Microsoft SQL
    • Difficulty:
      Moderate
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      Referring to MDL-21437
      When searching the database activity, the dropdown search fields now appear (fixed in MDL-21437), BUT when selected and searched, no results are found.

      It's as though the form is sending an incorrect value, hence no results are found.

      Works perfectly in MYSQL, but not in MSSQL environments.
      This has been fixed in Moodle 2.0 but not 1.9+

        Gliffy Diagrams

        1. MDL-25692.patch.txt
          15 kB
          Eloy Lafuente (stronk7)

          Issue Links

            Activity

            Hide
            Filter Manager added a comment -

            Assigning this to me. I'll try to backport all the fixes implemented in MDL-21437 to 1.9.

            Thanks for the report...ciao

            Show
            Filter Manager added a comment - Assigning this to me. I'll try to backport all the fixes implemented in MDL-21437 to 1.9. Thanks for the report...ciao
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Hi Lewis,

            I'm attaching here one patch for Moodle 1.9.x that makes the search template and the search execution to work for all field types.

            The only exceptions are date fields, which search is completely disabled (not only for mssql but for all DBs, so I haven't done anything with it).

            My tests here are basic, so if you can test it with more detail it will be welcome.

            In the mean time I'm going to send the patch for review to see if can land to next 1.9.x build asap.

            Ciao

            Show
            Eloy Lafuente (stronk7) added a comment - Hi Lewis, I'm attaching here one patch for Moodle 1.9.x that makes the search template and the search execution to work for all field types. The only exceptions are date fields, which search is completely disabled (not only for mssql but for all DBs, so I haven't done anything with it). My tests here are basic, so if you can test it with more detail it will be welcome. In the mean time I'm going to send the patch for review to see if can land to next 1.9.x build asap. Ciao
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Resolving as fixed, requested for review @ PULL-19.

            Feel free to comment / reopen if necessary. Ciao

            Show
            Eloy Lafuente (stronk7) added a comment - Resolving as fixed, requested for review @ PULL-19. Feel free to comment / reopen if necessary. Ciao
            Hide
            Lewis Carr added a comment -

            I will text extensively this morning and feeback ASAP.

            Show
            Lewis Carr added a comment - I will text extensively this morning and feeback ASAP.
            Hide
            Lewis Carr added a comment -

            Patch works.
            Database search fields now return results under mssql.
            Fixed.

            Show
            Lewis Carr added a comment - Patch works. Database search fields now return results under mssql. Fixed.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Thanks for feedback, Lewis!

            Show
            Eloy Lafuente (stronk7) added a comment - Thanks for feedback, Lewis!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: