[MDL-25697] iconsmall class gives icons poor vertical alignment under Chrome - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Trivial
Resolution: Fixed
Affects Version/s: 2.0, 2.1.1, 2.2
Fix Version/s: 2.0.5, 2.1.2
Component/s: Themes
Labels:
- triaged
Environment:
Chrome 7.0.517.44-r64615

Testing Instructions:
1. Log in as an admin
2. Browse to a course
3. Turn editing on
4. Check the alignment of the editing icons in several browsers
5. Check the alignment in several theme's as well.
Affected Branches:
MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
Fixed Branches:
MOODLE_20_STABLE, MOODLE_21_STABLE
Pull from Repository:
git://github.com/samhemelryk/moodle.git
Pull Master Branch:
wip-~~MDL-25697~~-master
Pull Master Diff URL:
https://github.com/samhemelryk/moodle/compare/master...wip-MDL-25697-master

Description

Under Chrome, icons of img class 'iconsmall' have a vertical alignment of 'middle' which means that they're rendered relative to the bottom of the line (or so it appears).
theme/base/style/core.css defines img.iconsmall with a vertical-alignment of middle.

Attachments

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Attachments

25697.current.alignment.png
54 kB
28/Sep/11 8:17 PM
25697.improved.alignment.png
54 kB
28/Sep/11 8:17 PM
chrome.png
247 kB
30/Dec/10 6:48 AM
firefox.png
290 kB
30/Dec/10 6:48 AM
safari.png
250 kB
30/Dec/10 6:48 AM

Activity

People

Assignee:: Sam Hemelryk

Reporter:: Andrew Nicols

Peer reviewer:: Rossiani Wijaya

Integrator:: Eloy Lafuente (stronk7)

Tester:: Andrew Davis

Participants:: Andrew Davis, Andrew Nicols, Eloy Lafuente (stronk7), Rossiani Wijaya, Sam Hemelryk

Component watchers:: Bas Brands

Votes:: 0 Vote for this issue

Watchers:: 1 Start watching this issue

Dates

Created:: 16/Dec/10 6:45 AM

Updated:: 30/Sep/13 6:11 PM

Resolved:: 07/Oct/11 2:34 PM

Fix Release Date:: 10/Oct/11