Moodle
  1. Moodle
  2. MDL-25711

Manually purging the theme cache after changing theme settings should not be necessary

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.0, 2.3.1
    • Fix Version/s: STABLE backlog
    • Component/s: Themes
    • Labels:
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_23_STABLE
    • Rank:
      15140

      Description

      If you go to administration > appearance > themes > brick (for example) and change one of the colour settings, that setting does not take effect until you purge the theme cache.

      Clearly, Moodle should be clever enough to purge the brick theme cache when you change one of its settings (but I am not sure if you can implement that within the current admin tree API).

      (Related thread: http://moodle.org/mod/forum/discuss.php?d=164511)

        Activity

        Hide
        Xavier Paz added a comment -

        imho, this should be a global parameter that would allow you to enable/disable theme cache, as it's annoying when you are developing new themes and you have to purge cache every time you make a change.

        Show
        Xavier Paz added a comment - imho, this should be a global parameter that would allow you to enable/disable theme cache, as it's annoying when you are developing new themes and you have to purge cache every time you make a change.
        Hide
        Tim Hunt added a comment -

        You mean like setting Theme designer mode: yes under Site administration ► Appearance ► Themes ► Theme settings?

        Show
        Tim Hunt added a comment - You mean like setting Theme designer mode: yes under Site administration ► Appearance ► Themes ► Theme settings?
        Hide
        Xavier Paz added a comment -

        That would be a good solution too, Tim.

        Show
        Xavier Paz added a comment - That would be a good solution too, Tim.
        Hide
        Tim Hunt added a comment -

        What do you mean would be? That option for developers to turn off the theme cache already exists. Did you go and look?

        Show
        Tim Hunt added a comment - What do you mean would be? That option for developers to turn off the theme cache already exists. Did you go and look?
        Hide
        Dan Poltawski added a comment -

        I think this still applies, adding affected versions etc.

        Note there is $setting->set_updatedcallback('theme_reset_all_caches'); to achieve this as on themedesignermode

        Show
        Dan Poltawski added a comment - I think this still applies, adding affected versions etc. Note there is $setting->set_updatedcallback('theme_reset_all_caches'); to achieve this as on themedesignermode

          People

          • Votes:
            2 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated: