Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-25713

Obvious place to use a recordset in the grade_object

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 1.9.10
    • Fix Version/s: 1.9.11, 2.0.2
    • Component/s: Gradebook
    • Labels:
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE

      Description

      In fetch_all_helper, it does get_records_select, which loads a whole lot of data into an array. Then it immediately turns those records into objects, and puts them in another array. 2 arrays == twice as much memory use as is ready needed. We should change this to get_recordset_select.

      Patch attached. Please can we get this into 1.9 quickly. Becuase of this problem we cannot delete gradebook columns on a course with 40,000 students.

      2.0-compatible patch to follow.

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  21/Feb/11