Moodle
  1. Moodle
  2. MDL-25736

TinyMce Spellchecker French issues

    Details

    • Testing Instructions:
      Hide

      for now,
      see upstream bug report about incorrect spelling suggestions.
      1) try to write those words with error and see that suggestions are correct for the language.

      Show
      for now, see upstream bug report about incorrect spelling suggestions. 1) try to write those words with error and see that suggestions are correct for the language.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull Master Branch:
      wip_master_mdl-25736_tinymce_spellchecker_frech_issues
    • Rank:
      15962

      Description

      I've noticed the following problems in the French version:

      • accented letters represented in code
      • fairly common words not recognised (e.g. "courriel" the French for email
      • the words suggested are often rather strange (in the opinion of people on the French forum)
      • the propositions are hidden behind a popup box (see attachment)
      • difficult to use the Firefox spellchecker which is much better (Thanks to Alexandre Scherbyna I know you can use it if use the "Paste from Word" button.)

        Activity

        Hide
        Nicolas Martignoni added a comment -

        If I understand correctly, this bug affects not only moodle.org, but any Moodle 2.0 installation. It should be then a MDL bug.

        Show
        Nicolas Martignoni added a comment - If I understand correctly, this bug affects not only moodle.org, but any Moodle 2.0 installation. It should be then a MDL bug.
        Hide
        Helen Foster added a comment -

        Glenys, thanks for your report. Please could you clarify what you mean by "accented letters represented in code".

        Nicolas, thanks for converting it to an MDL issue.

        Assigning to moodle.com for anyone in the HQ team to work on.

        Show
        Helen Foster added a comment - Glenys, thanks for your report. Please could you clarify what you mean by "accented letters represented in code". Nicolas, thanks for converting it to an MDL issue. Assigning to moodle.com for anyone in the HQ team to work on.
        Hide
        Glenys Hanson added a comment -

        Hi Helen,
        I think they're called ASCII html codes. Here's an example: Vous êtes français. Instead of: Vous êtes français.

        Show
        Glenys Hanson added a comment - Hi Helen, I think they're called ASCII html codes. Here's an example: Vous êtes français. Instead of: Vous êtes français.
        Hide
        Glenys Hanson added a comment -

        The pop-up box covering the suggestions occurs not only in French but in English too.
        Nice to see the Firefox spell checker works here.

        Show
        Glenys Hanson added a comment - The pop-up box covering the suggestions occurs not only in French but in English too. Nice to see the Firefox spell checker works here.
        Hide
        Wenceslao Fernadez added a comment -

        It is the same problem in Spanish...

        And also, is it possible to set a different language than English as default? We can´t find a way to do that...

        Show
        Wenceslao Fernadez added a comment - It is the same problem in Spanish... And also, is it possible to set a different language than English as default? We can´t find a way to do that...
        Hide
        James Cracknell added a comment - - edited

        See http://tracker.moodle.org/browse/MDL-2749 - getting a language display problem with English too.

        Show
        James Cracknell added a comment - - edited See http://tracker.moodle.org/browse/MDL-2749 - getting a language display problem with English too.
        Hide
        Aparup Banerjee added a comment -

        Hi Iñaki, did you want to attach a patch or git repo? (guessing from patch label added)

        Show
        Aparup Banerjee added a comment - Hi Iñaki, did you want to attach a patch or git repo? (guessing from patch label added)
        Hide
        Iñaki Arenaza added a comment -

        Hi Aparup,

        yes I did. But then I saw the bug is present in the upstream version of TinyMCE's spellchecker plugin, and started opening a bug upstream. I delayed attaching the patch until I opened the bug upstream to add a reference to it here, but then run out of time and had to leave

        So I'm attaching the patch (in git format-patch format) for the wrong encoding in the spelling suggestions and will add a comment later with the reference to the upstream bug number.

        Saludos.
        Iñaki.

        Show
        Iñaki Arenaza added a comment - Hi Aparup, yes I did. But then I saw the bug is present in the upstream version of TinyMCE's spellchecker plugin, and started opening a bug upstream. I delayed attaching the patch until I opened the bug upstream to add a reference to it here, but then run out of time and had to leave So I'm attaching the patch (in git format-patch format) for the wrong encoding in the spelling suggestions and will add a comment later with the reference to the upstream bug number. Saludos. Iñaki.
        Hide
        Iñaki Arenaza added a comment -

        Here are the patch files for 2.0, 2.1 and master, in git format-patch format.

        As the patches for 2.1 and master contain trailing CRs (they were present in the original files), you should the use '--keep-cr' option in git-am (if you use it to apply the patches). Otherwise git-am will tell you that the patches don't apply cleanly.

        Saludos.
        Iñaki.

        Show
        Iñaki Arenaza added a comment - Here are the patch files for 2.0, 2.1 and master, in git format-patch format. As the patches for 2.1 and master contain trailing CRs (they were present in the original files), you should the use '--keep-cr' option in git-am (if you use it to apply the patches). Otherwise git-am will tell you that the patches don't apply cleanly. Saludos. Iñaki.
        Hide
        Iñaki Arenaza added a comment -

        Upstream bug from TinyMCE: #4700 ( http://www.tinymce.com/develop/bugtracker_view.php?id=4700 )

        Saludos.
        Iñaki.

        Show
        Iñaki Arenaza added a comment - Upstream bug from TinyMCE: #4700 ( http://www.tinymce.com/develop/bugtracker_view.php?id=4700 ) Saludos. Iñaki.
        Hide
        Dan Poltawski added a comment -

        Doesn't look like there has been any action from upstream on this?

        Show
        Dan Poltawski added a comment - Doesn't look like there has been any action from upstream on this?
        Hide
        Iñaki Arenaza added a comment -

        Yep, no upstream action at all.

        Could we fix this at least in our version?

        Saludos.
        Iñaki.

        Show
        Iñaki Arenaza added a comment - Yep, no upstream action at all. Could we fix this at least in our version? Saludos. Iñaki.
        Hide
        Iñaki Arenaza added a comment -

        Hi Aparup,

        as upstream doesn't look like it's going to fix this, could you push this for integration?

        Saludos.
        Iñaki.

        Show
        Iñaki Arenaza added a comment - Hi Aparup, as upstream doesn't look like it's going to fix this, could you push this for integration? Saludos. Iñaki.
        Hide
        Aparup Banerjee added a comment -

        I've added skodak who actively maintains Tinymce as watcher. imo this should be fine to integrate but we will need a sure way to test with some examples to use to compare results.

        Petr, i recall some conversation about not having hacks for tinymce but not sure about the specifics with relation to the tinymce plugins.

        ps: pushed up for integration review.

        Show
        Aparup Banerjee added a comment - I've added skodak who actively maintains Tinymce as watcher. imo this should be fine to integrate but we will need a sure way to test with some examples to use to compare results. Petr, i recall some conversation about not having hacks for tinymce but not sure about the specifics with relation to the tinymce plugins. ps: pushed up for integration review.
        Hide
        Petr Škoda added a comment -

        HI, the patch seems ok, but I did not test it. It is safe to modify our custom forked tinymce plugins in 2.4dev. Please note it is now possible to disable the spellchecker plugin completely and rely on built-in browser spellchecking which is usually much better.

        Show
        Petr Škoda added a comment - HI, the patch seems ok, but I did not test it. It is safe to modify our custom forked tinymce plugins in 2.4dev. Please note it is now possible to disable the spellchecker plugin completely and rely on built-in browser spellchecking which is usually much better.
        Hide
        Jean-Michel Vedrine added a comment - - edited

        Hello,
        I can confirm this seems to solve all issues with french accentuated words Sadly I missed this issue until yesterday !

        Show
        Jean-Michel Vedrine added a comment - - edited Hello, I can confirm this seems to solve all issues with french accentuated words Sadly I missed this issue until yesterday !
        Hide
        Aparup Banerjee added a comment -

        Hi Iñaki, a query comes to mind, could we add unit test for these spell checking fixes?

        Show
        Aparup Banerjee added a comment - Hi Iñaki, a query comes to mind, could we add unit test for these spell checking fixes?
        Hide
        Joseph Rézeau added a comment -

        Tested the patch on my local test site with Moodle 2.4beta (Build: 20121109). Works OK for me, see screenshot "météo pourave".

        Show
        Joseph Rézeau added a comment - Tested the patch on my local test site with Moodle 2.4beta (Build: 20121109). Works OK for me, see screenshot "météo pourave".
        Hide
        Joseph Rézeau added a comment -

        météo pourave (Joseph Rézeau)

        Show
        Joseph Rézeau added a comment - météo pourave (Joseph Rézeau)
        Hide
        Aparup Banerjee added a comment -

        Thanks for testing this.

        I'm not sure we need unit test for this one plugin myself (enough to block this going through for now) so this has been integrated to 22, 23 and master.

        Show
        Aparup Banerjee added a comment - Thanks for testing this. I'm not sure we need unit test for this one plugin myself (enough to block this going through for now) so this has been integrated to 22, 23 and master.
        Hide
        Aparup Banerjee added a comment -

        Passing for Joseph based on his last comment.

        Show
        Aparup Banerjee added a comment - Passing for Joseph based on his last comment.
        Hide
        Dan Poltawski added a comment -

        It looks like this change hasn't been noted in lib/editor/tinymce/readme_moodle.txt

        We should add it there else the next person to upgrade tinymce will not reapply this change.

        Show
        Dan Poltawski added a comment - It looks like this change hasn't been noted in lib/editor/tinymce/readme_moodle.txt We should add it there else the next person to upgrade tinymce will not reapply this change.
        Hide
        Aparup Banerjee added a comment -

        Thanks Dan, i've added that now.

        Show
        Aparup Banerjee added a comment - Thanks Dan, i've added that now.
        Hide
        Petr Škoda added a comment -

        Hi, the "* MDL-25736 - French spellchecker fixes." was added to incorrect readme file in master because the spellchecker is not part of upstream TinyMCE editor, it is a separate package. I am going to fix it in MDL-36475 because it was colliding with my readme changes. Ciao.

        Show
        Petr Škoda added a comment - Hi, the "* MDL-25736 - French spellchecker fixes." was added to incorrect readme file in master because the spellchecker is not part of upstream TinyMCE editor, it is a separate package. I am going to fix it in MDL-36475 because it was colliding with my readme changes. Ciao.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Many, many thanks for your effort!

        Millions of people will enjoy the results of your work, yay!

        Closing as fixed. Ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Many, many thanks for your effort! Millions of people will enjoy the results of your work, yay! Closing as fixed. Ciao

          People

          • Votes:
            8 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: