Moodle
  1. Moodle
  2. MDL-25761

Missing library inclusion in Database activity module

    Details

    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Rank:
      15495

      Description

      Reported by Joseph Réyeau in MDL-25242 and at http://moodle.org/mod/forum/discuss.php?d=163662

      PHP Fatal error: Class 'portfolio_module_caller_base' not found in \moodle\mod\data\locallib.php on line 29

      Portfolios in Database module are not officially supported yet, therefore this was not spotted during QA testing.

        Issue Links

          Activity

          Hide
          David Mudrak added a comment -

          Re side note: aha. I was not sure about this because technically, the patch can be rejected yet. But it makes perfect sense to me. Could you please publish a very short cheat-sheet on what to do in various steps that I could use it when dealing with this Procezzilla?

          Show
          David Mudrak added a comment - Re side note: aha. I was not sure about this because technically, the patch can be rejected yet. But it makes perfect sense to me. Could you please publish a very short cheat-sheet on what to do in various steps that I could use it when dealing with this Procezzilla?
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Moving to 2.0.2, this is a complete caos, lol.

          2.0.1 has been released but this bug hasn't been moved automatically to 2.0.2 as far as we are reusing the old "resolved" as "in review".

          David, I don't want to write anything yet, because first we need to discuss/sort out all these syncs. This manual change is another example of something that should be handled automatically and it isn't right now. Luckily we are handling < 100 issues up to now, so everything is manually fixable, but we need to decide ASAP or this is going to become unmanageable.

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Moving to 2.0.2, this is a complete caos, lol. 2.0.1 has been released but this bug hasn't been moved automatically to 2.0.2 as far as we are reusing the old "resolved" as "in review". David, I don't want to write anything yet, because first we need to discuss/sort out all these syncs. This manual change is another example of something that should be handled automatically and it isn't right now. Luckily we are handling < 100 issues up to now, so everything is manually fixable, but we need to decide ASAP or this is going to become unmanageable. Ciao
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Closing as fixed. Will land upstream in hours.

          Show
          Eloy Lafuente (stronk7) added a comment - Closing as fixed. Will land upstream in hours.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: