Moodle
  1. Moodle
  2. MDL-25786

settings for self enrolement are not shown when using theme Magazine

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0.3
    • Component/s: Themes
    • Labels:
      None
    • Environment:
      Windows7
      xampp
      firefox
      iexplorer
    • Database:
      MySQL
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Rank:
      15250

      Description

      When using the theme Magazine the setting page for self enrolement ist not shown correctly within a course.
      (go to course
      select Settings->Users->enrolement Methods -> Self enrolment)
      Firefox shows a corrupt page
      IExplorer only shows the accpet button
      (see attached pictures)

        Issue Links

          Activity

          Hide
          Patrick Malley added a comment -

          All you, John. Can you please try to replicate.

          Show
          Patrick Malley added a comment - All you, John. Can you please try to replicate.
          Hide
          Nitin Parmar added a comment -

          I've replicated the issue as displayed in the screenshot within Firefox 3.6.13.

          Show
          Nitin Parmar added a comment - I've replicated the issue as displayed in the screenshot within Firefox 3.6.13.
          Hide
          John Stabinger added a comment - - edited

          The fieldset has an ID of #header which is conflicting with the #header div of the theme layout. The fix would be to rename the #header div and corrosponding css.

          As a sidenote, because this fieldset has claimed the #header ID, all themes will need to avoid using #header or they could run into the same issue(s).

          Show
          John Stabinger added a comment - - edited The fieldset has an ID of #header which is conflicting with the #header div of the theme layout. The fix would be to rename the #header div and corrosponding css. As a sidenote, because this fieldset has claimed the #header ID, all themes will need to avoid using #header or they could run into the same issue(s).
          Hide
          Petr Škoda added a comment -

          Please file the PULL request through this tracker instead, we are not processing the requests on jira at all. I am going to disable the issues and hopefully requests too there.

          Thanks.

          Show
          Petr Škoda added a comment - Please file the PULL request through this tracker instead, we are not processing the requests on jira at all. I am going to disable the issues and hopefully requests too there. Thanks.
          Hide
          Sam Hemelryk added a comment -

          Hi guys,

          I've just integrated the changes John made in PULL-172 however the duplicate #header id's is a greater problem.
          I've run a quick search of the Moodle source code and #header is used at least four times within the code base, three enrolment plugins, and during installation.
          We will either need to change the magazine theme, or change all locations within Moodle using #header.
          Has anyone created an issue along these lines yet?

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Hi guys, I've just integrated the changes John made in PULL-172 however the duplicate #header id's is a greater problem. I've run a quick search of the Moodle source code and #header is used at least four times within the code base, three enrolment plugins, and during installation. We will either need to change the magazine theme, or change all locations within Moodle using #header. Has anyone created an issue along these lines yet? Cheers Sam
          Hide
          John Stabinger added a comment -

          I can create the issue and change the #header for the Magazine theme. However, I would guess that this issue will crop up again in non-core themes as #header was used in many 1.9x themes and people upgrading their themes will probably run into this.

          Let me know which way you want to go. I certainly have no problem changing the theme's selector if that is ultimately the decision.

          John

          Show
          John Stabinger added a comment - I can create the issue and change the #header for the Magazine theme. However, I would guess that this issue will crop up again in non-core themes as #header was used in many 1.9x themes and people upgrading their themes will probably run into this. Let me know which way you want to go. I certainly have no problem changing the theme's selector if that is ultimately the decision. John
          Hide
          Helen Foster added a comment -

          Klaus, thanks for your report and John, thanks for fixing.

          Show
          Helen Foster added a comment - Klaus, thanks for your report and John, thanks for fixing.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: