Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0.2
    • Component/s: SCORM
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      This purpose of this task is to fix the SCORM releated database discrepancies between a fresh install of Moodle 2.0 and an upgraded site.

      scorm

      • forcecompleted in 1.9 is tinyint(1) DEFAULT '0', in 2.0 bigint(10) NOT NULL DEFAULT '1',
      • forcenewattempt, lastattemptlock, displayattemptstatus, displaycoursestructure in 2.0 is NOT NULL, 1.9 is not.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Sam Hemelryk added a comment -

            Hi Dan,

            I've added you as a watcher here, this issue aims to resolve database discrepancies between a fresh install of Moodle 2.0 and an upgraded 1.9 site.
            Could you please have a look at the patch I've got https://github.com/samhemelryk/moodle/compare/master...wip-MDL-25792 and let me know if its OK.
            If it is I'll go ahead and create a pull request for this.

            Cheers
            Sam

            Show
            Sam Hemelryk added a comment - Hi Dan, I've added you as a watcher here, this issue aims to resolve database discrepancies between a fresh install of Moodle 2.0 and an upgraded 1.9 site. Could you please have a look at the patch I've got https://github.com/samhemelryk/moodle/compare/master...wip-MDL-25792 and let me know if its OK. If it is I'll go ahead and create a pull request for this. Cheers Sam
            Hide
            Dan Marsden added a comment -

            thanks Sam - I'm pretty sure install.xml is incorrect for forcecompleted - it should probably be tinyint(1) - adding Piers here as he wrote that code - Piers can you please confirm forcecompleted should be a tinyint?

            Show
            Dan Marsden added a comment - thanks Sam - I'm pretty sure install.xml is incorrect for forcecompleted - it should probably be tinyint(1) - adding Piers here as he wrote that code - Piers can you please confirm forcecompleted should be a tinyint?
            Hide
            Sam Hemelryk added a comment -

            Cool thanks for checking that out Dan, I was wondering whether that was a mistake or not.
            I'll wait to hear back from Piers before pushing for this to be integrated.

            Cheers
            Sam

            Show
            Sam Hemelryk added a comment - Cool thanks for checking that out Dan, I was wondering whether that was a mistake or not. I'll wait to hear back from Piers before pushing for this to be integrated. Cheers Sam
            Hide
            Dan Marsden added a comment -

            just took a closer look - definitely a typo in install.xml - forcecompleted should be tinyint(1) - thanks Sam!

            Show
            Dan Marsden added a comment - just took a closer look - definitely a typo in install.xml - forcecompleted should be tinyint(1) - thanks Sam!
            Hide
            Sam Hemelryk added a comment -

            Thanks for checking that out Dan, I'll fix it all up now as a tinyint(1) and then see about getting this into weeks integration.

            Cheers
            Sam

            Show
            Sam Hemelryk added a comment - Thanks for checking that out Dan, I'll fix it all up now as a tinyint(1) and then see about getting this into weeks integration. Cheers Sam
            Hide
            Sam Hemelryk added a comment -

            Created PULL-116

            Show
            Sam Hemelryk added a comment - Created PULL-116
            Hide
            David Mudrak added a comment -

            Tested. Closing. Thanks for the fix Sam.

            Show
            David Mudrak added a comment - Tested. Closing. Thanks for the fix Sam.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: