Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-25850

Scorm score not checking for mod/scorm:viewscores

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.9.10
    • Fix Version/s: 2.0.2
    • Component/s: SCORM
    • Labels:
    • Environment:
      linux, apache2, mysql, php5
    • Database:
      MySQL
    • Difficulty:
      Moderate
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      There is no check for mod/scorm:viewscores called when looking at the page: your_url/mod/scorm/view.php?id=##

      when the capability mod/scorm:viewscores is set to prohibit or prevent there is no check to ensure that the score should be displayed.

      view.php calls - scorm_view_display() from locallib.php

      locallib.php has the following:

      $result = scorm_get_toc($user,$scorm,'structlist',$orgidentifier);
      ...
      echo $result->toc;

      scorm_get_toc() is called from the corresponding version of scorm in mod/scorm/datamodels/

      somewhere before $result is passed back should be a check to see:
      if (has_capability('mod/scorm:viewscores', $context))

      or once it is passed back $result->sco could be cleared out if the capability is not allowed

        Attachments

          Activity

            People

            Assignee:
            danmarsden Dan Marsden
            Reporter:
            miguels Miguel Santos
            Participants:
            Component watchers:
            Damyon Wiese, Dan Marsden, Matteo Scaramuccia, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            8 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              21/Feb/11