This is still broken in 2.0.3.

The problem seems to be that the only thing passed to the 'calendar_top_controls' function is the course id number. This doesn't help if the block is not on a course page.

Confirmed this issue still affects Moodle (2.4).

Debug info: SELECT * FROM

Unknown macro: {course}

WHERE id = ?
[array (
0 => 0,
)]
Error code: invalidrecord
Stack trace:

line 1357 of /lib/dml/moodle_database.php: dml_missing_record_exception thrown
line 1333 of /lib/dml/moodle_database.php: call to moodle_database->get_record_select()
line 43 of /user/index.php: call to moodle_database->get_record()

Priority raised and marking as triaged. See testing instructions if you want to replicate.

Note: I am also fixing a problem when navigating in a course, on pages which don't end with 'view.php'.

Hi Fred,
Just summarising our discussion here. The patch works efficiently for most cases, except the ones where you are in the middle of making a post kind of thing (example backup). So if you are on step 2 of backup and click next/prev it takes you back to the first page. But there is nothing really much we can do about it.

The patch looks good, feel free to submit for integration.

Thanks

Thanks Ankit!

Indeed, that could have been an issue and that's why I decided to rely on $PAGE->url which is set by the developer for each page. As you discovered it, it wouldn't crash in the middle of a post process but go back to the beginning (or wherever the developer decides to) which sounds good enough to me.

Pushing for integration.

Integrated to master, 24 and 23. Thanks Fred.

Works as expected. Awesome work Fred, I am really proud of you mate sheds tear. Passing.

Congratulations! This issue has been resolved. Thanks for helping to make Moodle better for everyone!

Regards, Damyon