Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-25853

Calendar month block previous/next links broken on non course pages

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.0.1, 2.3.4, 2.4.1
    • Fix Version/s: 2.3.5, 2.4.2
    • Component/s: Calendar
    • Labels:
    • Database:
      Any
    • Testing Instructions:
      Hide

      Test pre-requisites

      • Move the calendar block to the left pane
      • Set the calendar block to be displayed throughout the site

      Test 1

      1. Log in as an admin
      2. Browse to your profile (outside a course)
      3. Make sure the next/previous navigation works on the calendar block, without redirecting you to another page
      4. Navigate to a site page not ending with view.php (ie. the tags page)
      5. Make sure the next/previous navigation works on the calendar block, without redirecting you to another page
      6. Navigate to another set of pages and make sure the next/previous navigation works on the calendar block, without redirecting you to another page

      Test 2

      1. Navigate to a course
      2. Make sure the next/previous navigation works on the calendar block, without redirecting you to another page
      3. Navigate to a sub page which does not end with view.php (ie. enrolment page)
      4. Make sure the next/previous navigation works on the calendar block, without redirecting you to another page
      5. Explore some other pages and make sure the next/previous navigation works on the calendar block, without redirecting you to another page
      Show
      Test pre-requisites Move the calendar block to the left pane Set the calendar block to be displayed throughout the site Test 1 Log in as an admin Browse to your profile (outside a course) Make sure the next/previous navigation works on the calendar block, without redirecting you to another page Navigate to a site page not ending with view.php (ie. the tags page) Make sure the next/previous navigation works on the calendar block, without redirecting you to another page Navigate to another set of pages and make sure the next/previous navigation works on the calendar block, without redirecting you to another page Test 2 Navigate to a course Make sure the next/previous navigation works on the calendar block, without redirecting you to another page Navigate to a sub page which does not end with view.php (ie. enrolment page) Make sure the next/previous navigation works on the calendar block, without redirecting you to another page Explore some other pages and make sure the next/previous navigation works on the calendar block, without redirecting you to another page
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-25853-master
    • Pull Master Diff URL:

      Description

      On non-course pages the previous/next links are completely broken. It should probably use the new page url stuff, but calendar is a bit spagettiish, so will take some unpicking to sort out.

        Attachments

          Issue Links

          has been marked as being related by

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-35826 Re-write calendar blocks to include the month heading as a caption within the calendar table

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-23657 view profile "context" error notice

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              fred Frédéric Massart
              Reporter:
              poltawski Dan Poltawski
              Peer reviewer:
              Ankit Agarwal
              Integrator:
              Dan Poltawski
              Tester:
              Mark Nelson
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              2 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Mar/13