Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-25855

lib/filelib.php has not been included in the html block

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.0.1
    • Fix Version/s: 2.0.2
    • Component/s: Blocks
    • Labels:
    • Database:
      Any
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      When adding the HTML_Block to a Database activity the page refused to load and following error was thrown up in debug:
      Call to undefined function file_rewrite_pluginfile_urls() in /home/imoot/public_html/2011/blocks/html/block_html.php on line 60

      This has been determined to be because lib/filelib.php hasn't been included in the block

      I have listed this as critical as it impacts a core block that is rather heavily used

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              poltawski Dan Poltawski added a comment -

              There was a similar issue to this on the user profile and file_rewrite_pluginfileurls(). I think an audit of the calls of this function is required.

              Show
              poltawski Dan Poltawski added a comment - There was a similar issue to this on the user profile and file_rewrite_pluginfileurls(). I think an audit of the calls of this function is required.
              Hide
              poltawski Dan Poltawski added a comment - - edited

              Hmm, maybe i'm missing something -because there a lot of files without filelib:

              danp@bart:~/git/moodle$ git grep -l file_rewrite_pluginfile_urls | xargs grep -L filelib
              blocks/course_summary/block_course_summary.php
              blocks/html/block_html.php
              calendar/lib.php
              course/category.php
              course/info.php
              course/scales.php
              group/members.php
              group/overview.php
              lib/grade/grade_outcome.php
              lib/grade/grade_scale.php
              lib/questionlib.php
              mod/assignment/type/online/assignment.class.php
              mod/assignment/type/online/file.php
              mod/feedback/item/label/lib.php
              mod/glossary/lib.php
              mod/glossary/showentry_ajax.php
              mod/lesson/locallib.php
              mod/page/view.php
              mod/quiz/locallib.php
              mod/quiz/report/reportlib.php
              mod/wiki/locallib.php
              mod/wiki/renderer.php
              mod/workshop/assessment.php
              mod/workshop/exassessment.php
              mod/workshop/exsubmission.php
              mod/workshop/form/accumulative/lib.php
              mod/workshop/form/comments/lib.php
              mod/workshop/form/numerrors/lib.php
              mod/workshop/form/rubric/lib.php
              mod/workshop/submission.php
              mod/workshop/view.php
              user/view.php

              Show
              poltawski Dan Poltawski added a comment - - edited Hmm, maybe i'm missing something -because there a lot of files without filelib: danp@bart:~/git/moodle$ git grep -l file_rewrite_pluginfile_urls | xargs grep -L filelib blocks/course_summary/block_course_summary.php blocks/html/block_html.php calendar/lib.php course/category.php course/info.php course/scales.php group/members.php group/overview.php lib/grade/grade_outcome.php lib/grade/grade_scale.php lib/questionlib.php mod/assignment/type/online/assignment.class.php mod/assignment/type/online/file.php mod/feedback/item/label/lib.php mod/glossary/lib.php mod/glossary/showentry_ajax.php mod/lesson/locallib.php mod/page/view.php mod/quiz/locallib.php mod/quiz/report/reportlib.php mod/wiki/locallib.php mod/wiki/renderer.php mod/workshop/assessment.php mod/workshop/exassessment.php mod/workshop/exsubmission.php mod/workshop/form/accumulative/lib.php mod/workshop/form/comments/lib.php mod/workshop/form/numerrors/lib.php mod/workshop/form/rubric/lib.php mod/workshop/submission.php mod/workshop/view.php user/view.php
              Hide
              skodak Petr Skoda added a comment -

              Should be fixed now, thanks a lot for the report!

              Petr

              Show
              skodak Petr Skoda added a comment - Should be fixed now, thanks a lot for the report! Petr
              Hide
              tsala Helen Foster added a comment -

              Julian, thanks for your report and Dan, thanks for your comments. This issue is fixed in the next weekly Moodle 2.0.1+.

              Show
              tsala Helen Foster added a comment - Julian, thanks for your report and Dan, thanks for your comments. This issue is fixed in the next weekly Moodle 2.0.1+.

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    21/Feb/11