Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-25872

Teacher listed in assignment grading (but not gradebook)

    Details

    • Database:
      MySQL
    • Testing Instructions:
      Hide

      Setup: Course with at least one student and one teacher enrolled.

      • Log in as the teacher.
      • Create an "Advanced uploading of files assignment" (with default settings).
      • Open the assignment, and click on "No attempts have been made on this assignment".

      TO VERIFY: In the list being displayed, only the student is listed, not the teacher.

      Show
      Setup: Course with at least one student and one teacher enrolled. Log in as the teacher. Create an "Advanced uploading of files assignment" (with default settings). Open the assignment, and click on "No attempts have been made on this assignment". TO VERIFY: In the list being displayed, only the student is listed, not the teacher.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      Teacher's name is showing up as a user to be graded in an advanced uploading of files assignment, unlike Moodle 1.9.x.

      Teacher's name is absent from Gradebook (as it should be).

      Screenshots attached.

        Gliffy Diagrams

        1. Mood20TeachAssign.tiff
          94 kB
          Bren Campbell
        2. Mood20TeacherRole.tiff
          122 kB
          Bren Campbell

          Issue Links

            Activity

            Hide
            marycooch Mary Cooch added a comment -

            I just tried this and found that not only is a teacher visible in advanced uploading of files assignment but also in the other three assignment types - yet as you say, not in the grades link in course admin.(Using my own test Moodle 2.0.1 (Build: 20101225) )

            Show
            marycooch Mary Cooch added a comment - I just tried this and found that not only is a teacher visible in advanced uploading of files assignment but also in the other three assignment types - yet as you say, not in the grades link in course admin.(Using my own test Moodle 2.0.1 (Build: 20101225) )
            Hide
            tsala Helen Foster added a comment -

            Bren, thanks for your report and Mary, thanks for the additional info. It seems the problem is also present in 2.1 (see MDLQA-1147).

            Show
            tsala Helen Foster added a comment - Bren, thanks for your report and Mary, thanks for the additional info. It seems the problem is also present in 2.1 (see MDLQA-1147 ).
            Hide
            cmmattia Chris Mattia added a comment -

            While recording the Moodle 2.1 Essential Training for Teachers at lynda.com I also ran into this bug, and the Teacher does show in the assignment but not in the Course Gradebook. If you switch roles to the student role and even open the Notes field (hitting cancel to get out) then the quick grade page shows that you made an attempt on this assignment and there is no way to clear this attempt that I've been able to find. The No Attempts have been made UI changes at this point to show 1 submitted assignment even though the Quick grade only recorded at date and time of the attempt.

            Show
            cmmattia Chris Mattia added a comment - While recording the Moodle 2.1 Essential Training for Teachers at lynda.com I also ran into this bug, and the Teacher does show in the assignment but not in the Course Gradebook. If you switch roles to the student role and even open the Notes field (hitting cancel to get out) then the quick grade page shows that you made an attempt on this assignment and there is no way to clear this attempt that I've been able to find. The No Attempts have been made UI changes at this point to show 1 submitted assignment even though the Quick grade only recorded at date and time of the attempt.
            Hide
            bostelm Henning Bostelmann added a comment -

            This seems to be caused by an incorrect capability used at one place in the code, see diff.

            Show
            bostelm Henning Bostelmann added a comment - This seems to be caused by an incorrect capability used at one place in the code, see diff.
            Hide
            andyjdavis Andrew Davis added a comment -

            The code change looks simple enough. Should I submit this for integration for you or do you have the permissions required to do it yourself?

            Show
            andyjdavis Andrew Davis added a comment - The code change looks simple enough. Should I submit this for integration for you or do you have the permissions required to do it yourself?
            Hide
            bostelm Henning Bostelmann added a comment -

            Sorry, I don't have the permission to send this for integration.

            Show
            bostelm Henning Bostelmann added a comment - Sorry, I don't have the permission to send this for integration.
            Hide
            andyjdavis Andrew Davis added a comment -

            done

            Show
            andyjdavis Andrew Davis added a comment - done
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Integrated, many thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Integrated, many thanks!
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Tested. Passed. Thanks

            Show
            samhemelryk Sam Hemelryk added a comment - Tested. Passed. Thanks
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            git & cvs repositories have been populated with this solution. Many thanks for your collaboration, yay!

            Closing, ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - git & cvs repositories have been populated with this solution. Many thanks for your collaboration, yay! Closing, ciao
            Hide
            sporter@nts.edu Stephen Porter added a comment -

            Is anyone still having trouble with the teacher showing up, not in the list of users as before, but when grading and after clicking "save and next" or "next" and the teacher is next alphabetically, the teacher is presented for a grade once again? The initial problem of the teacher in the list is corrected but it seems the overall problem is not solved, at least from what I am experiencing. Or is it just our system?

            Show
            sporter@nts.edu Stephen Porter added a comment - Is anyone still having trouble with the teacher showing up, not in the list of users as before, but when grading and after clicking "save and next" or "next" and the teacher is next alphabetically, the teacher is presented for a grade once again? The initial problem of the teacher in the list is corrected but it seems the overall problem is not solved, at least from what I am experiencing. Or is it just our system?
            Hide
            bostelm Henning Bostelmann added a comment -

            This seems a different - but possibly related - problem; can you open a new ticket for that?

            Show
            bostelm Henning Bostelmann added a comment - This seems a different - but possibly related - problem; can you open a new ticket for that?
            Hide
            sporter@nts.edu Stephen Porter added a comment -
            Show
            sporter@nts.edu Stephen Porter added a comment - Ok, thanks. Created: http://tracker.moodle.org/browse/MDL-29810
            Hide
            ahastie Ali Hastie added a comment -

            I am still having this problem with teachers within the assignment list for Moodle 2.4.1+

            Show
            ahastie Ali Hastie added a comment - I am still having this problem with teachers within the assignment list for Moodle 2.4.1+
            Hide
            ahastie Ali Hastie added a comment -

            Forgot to mention, it's the newer version the assignment module not 2.2 version.

            Show
            ahastie Ali Hastie added a comment - Forgot to mention, it's the newer version the assignment module not 2.2 version.
            Hide
            monkrob Rob Monk added a comment -

            This bug is not fixed. We are using Moodle 2.4 and teachers do appear in the assignment screen but not the gradebook.

            Show
            monkrob Rob Monk added a comment - This bug is not fixed. We are using Moodle 2.4 and teachers do appear in the assignment screen but not the gradebook.
            Hide
            andyjdavis Andrew Davis added a comment -

            Hi Rob. Could you please open a new issue describing what you're seeing.

            Show
            andyjdavis Andrew Davis added a comment - Hi Rob. Could you please open a new issue describing what you're seeing.
            Hide
            monkrob Rob Monk added a comment -

            Done.

            Show
            monkrob Rob Monk added a comment - Done.
            Hide
            tsala Helen Foster added a comment -

            Linking to Rob's report of this issue reoccurring in Moodle 2.4.3 - MDL-40011.

            Show
            tsala Helen Foster added a comment - Linking to Rob's report of this issue reoccurring in Moodle 2.4.3 - MDL-40011 .

              People

              • Votes:
                19 Vote for this issue
                Watchers:
                15 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Oct/11