[MDL-25883] Wiki Comments HTML Editor Broken - Moodle Tracker

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.0.1, 2.0.7, 2.2.1
Fix Version/s: 2.0.8, 2.1.5, 2.2.2
Component/s: HTML Editor (TinyMCE), Wiki (2.x)
Labels:
- patch
- triaged

Database:

Any
Testing Instructions:
Hide

Note: You need firebug/ developer tool for checking JS errors.

Log in as Admin and turn editing on

Select a course and add a wiki activity

Select wiki activity and add a new Creole format page

Click on comments tab and then click on add comment

Open error console to check for javascript errors

Type text and select/highlight text in comment box

click on bold icon and you should not see any javascript error. Also ** should be suffixed and prefixed to selected text.

Repeat above steps for NWIKI page format as well.

Note that because of ~~MDL-28101~~ Bold and Italics fail in a different way for NWIKI.
Show
Note: You need firebug/ developer tool for checking JS errors. Log in as Admin and turn editing on Select a course and add a wiki activity Select wiki activity and add a new Creole format page Click on comments tab and then click on add comment Open error console to check for javascript errors Type text and select/highlight text in comment box click on bold icon and you should not see any javascript error. Also ** should be suffixed and prefixed to selected text. Repeat above steps for NWIKI page format as well. Note that because of MDL-28101 Bold and Italics fail in a different way for NWIKI.
Difficulty:
Easy
Affected Branches:
MOODLE_20_STABLE, MOODLE_22_STABLE
Fixed Branches:
MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
Pull from Repository:
https://github.com/mackensen/moodle
Pull Master Branch:
~~MDL-25883~~-master
Pull Master Diff URL:
https://github.com/mackensen/moodle/compare/master...MDL-25883-master

Description

The HTML editor for wiki comments doesn't work. If you highlight text and click on any of the editor buttons, nothing happens.
It produces the following javascript error: document.forms.mform1 is undefined
Source File: http://moodle2.clamp-it.org/lib/javascript.php?file=%2Fmod%2Fwiki%2Feditors%2Fwiki%2Fbuttons.js&rev=160
Line: 2

The form ID is "wikiform" but the script references the id "mform1".

Gliffy Diagrams

Attachments

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Attachments

mdl25883_fixform.patch
0.7 kB
07/Jan/11 12:06 AM

Issue Links

blocks

MDL-28101 Bold and italics do not work with the NWIKI formatting

Closed

has a non-specific relationship to

MDL-31584 wiki_editor.php should be removed and wikieditor element should be used

Open

has been marked as being related by

MDL-33143 Unable to insert images into Creole wiki when already previewing

Closed

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Charles Fulton added a comment - 06/Jan/11 11:48 PM

I've reproduced this leaving a comment for both Creole and NWiki pages; HTML appears to be fine.

Show

Charles Fulton added a comment - 06/Jan/11 11:48 PM I've reproduced this leaving a comment for both Creole and NWiki pages; HTML appears to be fine.

Hide

Permalink

Charles Fulton added a comment - 07/Jan/11 12:06 AM

This appears to be an outdated reference in wiki_editor.php. I've posted what ought to be a quick fix with no downstream effects.

Show

Charles Fulton added a comment - 07/Jan/11 12:06 AM This appears to be an outdated reference in wiki_editor.php. I've posted what ought to be a quick fix with no downstream effects.

Hide

Permalink

Charles Fulton added a comment - 29/Jun/11 11:02 PM

This is still broken in 2.1 and is a blocker for ~~MDL-28101~~. Patch here: https://github.com/mackensen/moodle/compare/master...mdl-25883.

Show

Charles Fulton added a comment - 29/Jun/11 11:02 PM This is still broken in 2.1 and is a blocker for MDL-28101 . Patch here: https://github.com/mackensen/moodle/compare/master...mdl-25883 .

Hide

Permalink

Charles Fulton added a comment - 16/Jan/12 2:43 AM

This is still broken in all versions of 2.

Show

Charles Fulton added a comment - 16/Jan/12 2:43 AM This is still broken in all versions of 2.

Hide

Permalink

Rajesh Taneja added a comment - 10/Feb/12 9:56 AM - edited

Thanks for spot-on patch Charles

Pushing it through process.

Show

Rajesh Taneja added a comment - 10/Feb/12 9:56 AM - edited Thanks for spot-on patch Charles Pushing it through process.

Hide

Permalink

Rajesh Taneja added a comment - 10/Feb/12 10:09 AM

FYI:
Javascript is trying to find textarea with id=mform1 /mod/wiki/editors/wiki/buttons.js - Line 23, but while creating wiki editor (/mod/wiki/editors/wiki_editor.php - line 77) we assign id = wikiform.

Well spotted by Jason

Show

Rajesh Taneja added a comment - 10/Feb/12 10:09 AM FYI: Javascript is trying to find textarea with id=mform1 /mod/wiki/editors/wiki/buttons.js - Line 23, but while creating wiki editor (/mod/wiki/editors/wiki_editor.php - line 77) we assign id = wikiform. Well spotted by Jason

Hide

Permalink

Ankit Agarwal added a comment - 10/Feb/12 11:40 AM

Looks good to me!
Thanks

Show

Ankit Agarwal added a comment - 10/Feb/12 11:40 AM Looks good to me! Thanks

Hide

Permalink

Sam Hemelryk added a comment - 13/Feb/12 9:38 AM

Thanks guys, this has been integrated now.
I was in two minds about it to begin with as wikiform is a much better id in this case then mform1, however given the impending wiki change I think there is no harm in this.

Cheers
Sam

Show

Sam Hemelryk added a comment - 13/Feb/12 9:38 AM Thanks guys, this has been integrated now. I was in two minds about it to begin with as wikiform is a much better id in this case then mform1, however given the impending wiki change I think there is no harm in this. Cheers Sam

Hide

Permalink

Rajesh Taneja added a comment - 13/Feb/12 10:06 AM

I thought the same Sam, but looking at wikieditor (form element) implementation, I changed my mind

Show

Rajesh Taneja added a comment - 13/Feb/12 10:06 AM I thought the same Sam, but looking at wikieditor (form element) implementation, I changed my mind

Hide

Permalink

Glenn Ansley added a comment - 14/Feb/12 4:24 AM

Looks good. I tested in master, 2.2, 2.1, and 2.0 integration branches. I will note that the NWiki page type still throws an error but this is being handled in another ticket according to the testing instructions.

Show

Glenn Ansley added a comment - 14/Feb/12 4:24 AM Looks good. I tested in master, 2.2, 2.1, and 2.0 integration branches. I will note that the NWiki page type still throws an error but this is being handled in another ticket according to the testing instructions.

Hide

Permalink

Eloy Lafuente (stronk7) added a comment - 17/Feb/12 10:07 AM

It is late here and I'm very tired but I didn't want to go to sleep before expressing my admiration for your amazing collaboration. Thanks!

Closing as fixed, heading to zzzZZZzzz, niao

Show

Eloy Lafuente (stronk7) added a comment - 17/Feb/12 10:07 AM It is late here and I'm very tired but I didn't want to go to sleep before expressing my admiration for your amazing collaboration. Thanks! Closing as fixed, heading to zzzZZZzzz, niao

People

Assignee:

Rajesh Taneja

Reporter:

Jason Bennett

Peer reviewer:

Ankit Agarwal

Integrator:

Sam Hemelryk

Tester:

Glenn Ansley

Participants:

Ankit Agarwal, Charles Fulton, Eloy Lafuente (stronk7), Glenn Ansley, Jason Bennett, Rajesh Taneja, Sam Hemelryk

Votes:

12 Vote for this issue

Watchers:

5 Start watching this issue

Dates

Created:

06/Jan/11 11:29 PM

Updated:

30/Sep/13 10:14 AM

Resolved:

17/Feb/12 10:07 AM

Fix Release Date:

12/Mar/12