Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-25883

Wiki Comments HTML Editor Broken

          Details

          • Database:
            Any
          • Testing Instructions:
            Hide

            Note: You need firebug/ developer tool for checking JS errors.

            1. Log in as Admin and turn editing on
            2. Select a course and add a wiki activity
            3. Select wiki activity and add a new Creole format page
            4. Click on comments tab and then click on add comment
            5. Open error console to check for javascript errors
            6. Type text and select/highlight text in comment box
            7. click on bold icon and you should not see any javascript error. Also ** should be suffixed and prefixed to selected text.

            Repeat above steps for NWIKI page format as well.

            Note that because of MDL-28101 Bold and Italics fail in a different way for NWIKI.

            Show
            Note: You need firebug/ developer tool for checking JS errors. Log in as Admin and turn editing on Select a course and add a wiki activity Select wiki activity and add a new Creole format page Click on comments tab and then click on add comment Open error console to check for javascript errors Type text and select/highlight text in comment box click on bold icon and you should not see any javascript error. Also ** should be suffixed and prefixed to selected text. Repeat above steps for NWIKI page format as well. Note that because of MDL-28101 Bold and Italics fail in a different way for NWIKI.
          • Difficulty:
            Easy
          • Affected Branches:
            MOODLE_20_STABLE, MOODLE_22_STABLE
          • Fixed Branches:
            MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
          • Pull from Repository:
          • Pull Master Branch:
            MDL-25883-master
          • Pull Master Diff URL:

            Description

            The HTML editor for wiki comments doesn't work. If you highlight text and click on any of the editor buttons, nothing happens.
            It produces the following javascript error: document.forms.mform1 is undefined
            Source File: http://moodle2.clamp-it.org/lib/javascript.php?file=%2Fmod%2Fwiki%2Feditors%2Fwiki%2Fbuttons.js&rev=160
            Line: 2

            The form ID is "wikiform" but the script references the id "mform1".

              Gliffy Diagrams

                Attachments

                  Issue Links

                  blocks

                  Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-28101 Bold and italics do not work with the NWIKI formatting

                  • Minor - Minor loss of function where workaround is possible
                  • Closed
                  has a non-specific relationship to

                  Improvement - An enhancement to an existing Moodle feature. MDL-31584 wiki_editor.php should be removed and wikieditor element should be used

                  • Minor - Minor loss of function where workaround is possible
                  • Open
                  has been marked as being related by

                  Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-33143 Unable to insert images into Creole wiki when already previewing

                  • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
                  • Closed

                    Activity

                      People

                      • Votes:
                        12 Vote for this issue
                        Watchers:
                        5 Start watching this issue

                        Dates

                        • Created:
                          Updated:
                          Resolved:
                          Fix Release Date:
                          12/Mar/12