Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-25888

1.9.5+ to 2.0.1+ Upgrade Breaks Serial Numbers Display

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Won't Fix
    • Affects Version/s: 2.0.1
    • Fix Version/s: None
    • Component/s: Themes
    • Labels:
    • Environment:
      LAMP
    • Database:
      MySQL
    • Affected Branches:
      MOODLE_20_STABLE

      Description

      On upgrading the 1.9.5+ site to 2.0.1+ using Splash theme, I noticed that the serial numbers are broken that were originally generated by HTML Area editor of 1.9.5+. For example:

      1.
      2.
      3.
      4.
      5.
      6.
      7.
      8.
      9.
      10.
      11.
      12.

      Looks like,

      1.
      2.
      3.
      4.
      5.
      6.
      7.
      8.
      9.
      0.
      1.
      2.

        Gliffy Diagrams

          Issue Links

            Activity

            123iitjee Manish Verma created issue -
            Hide
            korpelainen Mauno Korpelainen added a comment -

            This is not caused by editor - it is caused by theme css - see http://moodle.org/mod/forum/discuss.php?d=165759

            Show
            korpelainen Mauno Korpelainen added a comment - This is not caused by editor - it is caused by theme css - see http://moodle.org/mod/forum/discuss.php?d=165759
            123iitjee Manish Verma made changes -
            Field Original Value New Value
            Labels TinyMCE CSS Theme TinyMCE
            Description On upgrading the 1.9.5+ site to 2.0.1+, I noticed that the serial numbers are broken (checked on Splash theme) that were originally generated by HTML Area editor of 1.9.5+. For example:

             1.
             2.
             3.
             4.
             5.
             6.
             7.
             8.
             9.
            10.
            11.
            12.

            Looks like,

            1.
            2.
            3.
            4.
            5.
            6.
            7.
            8.
            9.
            0.
            1.
            2.
            On upgrading the 1.9.5+ site to 2.0.1+ using Splash theme, I noticed that the serial numbers are broken that were originally generated by HTML Area editor of 1.9.5+. For example:

             1.
             2.
             3.
             4.
             5.
             6.
             7.
             8.
             9.
            10.
            11.
            12.

            Looks like,

            1.
            2.
            3.
            4.
            5.
            6.
            7.
            8.
            9.
            0.
            1.
            2.
            Component/s Themes [ 10088 ]
            Hide
            korpelainen Mauno Korpelainen added a comment -

            The code there is created with normal ol li tags in both HTMLArea and TinyMCE and upgrading should not change that at all - probably the reason is found from some recent change in base theme or canvas theme css for some ol li or plain li tags

            <ol><li>a</li>
            <li>b</li>
            <li>c</li>
            <li>d</li>
            <li>e</li>

            <li>f</li>
            <li>g</li>
            <li>h</li>
            <li>i</li>
            <li>j</li>
            <li>k</li>
            <li>l</li>
            </ol>

            Show
            korpelainen Mauno Korpelainen added a comment - The code there is created with normal ol li tags in both HTMLArea and TinyMCE and upgrading should not change that at all - probably the reason is found from some recent change in base theme or canvas theme css for some ol li or plain li tags <ol><li>a</li> <li>b</li> <li>c</li> <li>d</li> <li>e</li> <li>f</li> <li>g</li> <li>h</li> <li>i</li> <li>j</li> <li>k</li> <li>l</li> </ol>
            Hide
            korpelainen Mauno Korpelainen added a comment -

            Finally figured this out - the whole thing is caused by yui css (again).

            Because file lib/yui/3.2.0/build/cssbase/base-min.css has css rules

            ol li

            {list-style:decimal outside;}

            ul li

            {list-style:disc outside;}

            all ordered lists (ol) that are INSIDE unordered lists (ul) will use list-style disc.

            If you place an ordered list for example to Front page description it works ok and shows numbers.

            You could of course change the order of those css rules in custom theme css or create more detailed css rules for various cases but Sam H might want to create a permanent solution to base theme css

            Show
            korpelainen Mauno Korpelainen added a comment - Finally figured this out - the whole thing is caused by yui css (again). Because file lib/yui/3.2.0/build/cssbase/base-min.css has css rules ol li {list-style:decimal outside;} ul li {list-style:disc outside;} all ordered lists (ol) that are INSIDE unordered lists (ul) will use list-style disc. If you place an ordered list for example to Front page description it works ok and shows numbers. You could of course change the order of those css rules in custom theme css or create more detailed css rules for various cases but Sam H might want to create a permanent solution to base theme css
            cfulton Charles Fulton made changes -
            Link This issue has a non-specific relationship to MDL-23060 [ MDL-23060 ]
            Hide
            korpelainen Mauno Korpelainen added a comment -

            The best fix would be to avoid using common css rules for common li tags in any themes and use only class or id specific rules, If some theme sets for example margin for li it effects both ul and ol list margins. And since we can't remove yui css rules like

            ol li

            {list-style:decimal outside;}

            ul li

            {list-style:disc outside;}

            from file lib/yui/3.2.0/build/cssbase/base-min.css (or can we - is there a way to block some yui css files in themes?)

            the next trial could be to add new rules like

            ul ol li

            {list-style:decimal outside;}

            ol ul li

            {list-style:disc outside;}

            to base theme css to fix cases where ordered lists are inside unordered lists or unordered lists are inside ordered lists.

            But once we create lists that have lists inside lists inside lists this approach fails again...

            Show
            korpelainen Mauno Korpelainen added a comment - The best fix would be to avoid using common css rules for common li tags in any themes and use only class or id specific rules, If some theme sets for example margin for li it effects both ul and ol list margins. And since we can't remove yui css rules like ol li {list-style:decimal outside;} ul li {list-style:disc outside;} from file lib/yui/3.2.0/build/cssbase/base-min.css (or can we - is there a way to block some yui css files in themes?) the next trial could be to add new rules like ul ol li {list-style:decimal outside;} ol ul li {list-style:disc outside;} to base theme css to fix cases where ordered lists are inside unordered lists or unordered lists are inside ordered lists. But once we create lists that have lists inside lists inside lists this approach fails again...
            Hide
            tsala Helen Foster added a comment -

            Manish, thanks for your report and Mauno, thanks for your diagnosis.

            It seems from the discussion http://moodle.org/mod/forum/discuss.php?d=165759 that this issue affects all 2.0 sites, not just upgraded ones.

            Show
            tsala Helen Foster added a comment - Manish, thanks for your report and Mauno, thanks for your diagnosis. It seems from the discussion http://moodle.org/mod/forum/discuss.php?d=165759 that this issue affects all 2.0 sites, not just upgraded ones.
            tsala Helen Foster made changes -
            Labels CSS Theme TinyMCE CSS triaged
            Fix Version/s STABLE backlog [ 10463 ]
            Priority Minor [ 4 ] Major [ 3 ]
            Component/s HTML Editor [ 10070 ]
            tsala Helen Foster made changes -
            Link This issue will help resolve MDLSITE-1236 [ MDLSITE-1236 ]
            dougiamas Martin Dougiamas made changes -
            Workflow MDL Workflow [ 66669 ] MDL Full Workflow [ 75604 ]
            cfulton Charles Fulton made changes -
            Link This issue has a non-specific relationship to MDL-27826 [ MDL-27826 ]
            Hide
            salvetore Michael de Raadt added a comment -

            Thanks for reporting this issue.

            We have detected that this issue has been inactive for over a year. It was reported as affecting versions that are no longer supported.

            If you believe that this issue is still relevant to current versions (2.5 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

            Michael d.

            TW9vZGxlDQo=

            Show
            salvetore Michael de Raadt added a comment - Thanks for reporting this issue. We have detected that this issue has been inactive for over a year. It was reported as affecting versions that are no longer supported. If you believe that this issue is still relevant to current versions (2.5 and beyond), please comment on the issue. Issues left inactive for a further month will be closed. Michael d. TW9vZGxlDQo=
            Hide
            salvetore Michael de Raadt added a comment -

            I'm closing this issue as it has been inactive for over a year has been recorded as affecting versions that are no longer supported.

            This is being done as part of a bulk annual clean-up of issues.

            If you still believe this is an issue in supported versions, please create a new issue.

            Show
            salvetore Michael de Raadt added a comment - I'm closing this issue as it has been inactive for over a year has been recorded as affecting versions that are no longer supported. This is being done as part of a bulk annual clean-up of issues. If you still believe this is an issue in supported versions, please create a new issue.
            salvetore Michael de Raadt made changes -
            Status Open [ 1 ] Closed [ 6 ]
            Assignee moodle.com [ moodle.com ]
            Resolution Won't Fix [ 2 ]
            Fix Version/s STABLE backlog [ 10463 ]

              People

              • Votes:
                2 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: