Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-25927

Completion system print_help_icon: should be changed to return string not print directly

          Details

          • Type: Improvement
          • Status: Closed
          • Priority: Minor
          • Resolution: Fixed
          • Affects Version/s: 2.0.1
          • Fix Version/s: 2.0.2
          • Component/s: Activity completion
          • Labels:
            None
          • Affected Branches:
            MOODLE_20_STABLE
          • Fixed Branches:
            MOODLE_20_STABLE

            Description

            The completion system uses a function completion_info::print_help_icon which prints the 'Your progress' help button.

            A developer here is trying to implement a new course format and to use a proper renderer structure. In order to do this it would be helpful if the print_help_icon function were changed to display_help_icon (return html string rather than printing it directly).

              Gliffy Diagrams

                Attachments

                  Activity

                  Ascending order - Click to sort in descending order
                  Hide
                  Permalink
                  jenny-gray Jenny Gray added a comment -

                  Just to confirm that the patch is what I was looking for - thank you.

                  Show
                  jenny-gray Jenny Gray added a comment - Just to confirm that the patch is what I was looking for - thank you.
                  Hide
                  Permalink
                  mudrd8mz David Mudrák added a comment -

                  Tested, closing. Thanks for the patch!

                  Show
                  mudrd8mz David Mudrák added a comment - Tested, closing. Thanks for the patch!

                    People

                    • Votes:
                      0 Vote for this issue
                      Watchers:
                      2 Start watching this issue

                      Dates

                      • Created:
                        Updated:
                        Resolved:
                        Fix Release Date:
                        21/Feb/11