Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-25971

html_writer::select should accept 'disabled' => true/false, as well as 'disabled' => 'disabled'

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.1
    • Fix Version/s: 2.0.2
    • Component/s: Libraries
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      In Moodle 1.9, you could pass $disabled = true to choose from menu (or, more significantly $disabled =

      {some boolean expression}

      ).

      That does not currently work with the Moodle 2.0 equivalent: html_writer::select.

      This patch fixes that.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            timhunt Tim Hunt added a comment -

            Oops. This is the right patch.

            Show
            timhunt Tim Hunt added a comment - Oops. This is the right patch.
            Hide
            timhunt Tim Hunt added a comment -

            PULL-113 created.

            Show
            timhunt Tim Hunt added a comment - PULL-113 created.
            Hide
            skodak Petr Skoda added a comment -

            Instead of typing "pull created" please link the issues, thanks.

            Show
            skodak Petr Skoda added a comment - Instead of typing "pull created" please link the issues, thanks.
            Hide
            timhunt Tim Hunt added a comment -

            OK. Noted for the future.

            Show
            timhunt Tim Hunt added a comment - OK. Noted for the future.
            Hide
            mudrd8mz David Mudrák added a comment -

            Tested, works well. Thanks for this improvement Tim.

            Show
            mudrd8mz David Mudrák added a comment - Tested, works well. Thanks for this improvement Tim.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  21/Feb/11