Moodle
  1. Moodle
  2. MDL-25971

html_writer::select should accept 'disabled' => true/false, as well as 'disabled' => 'disabled'

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.1
    • Fix Version/s: 2.0.2
    • Component/s: Libraries
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Rank:
      15912

      Description

      In Moodle 1.9, you could pass $disabled = true to choose from menu (or, more significantly $disabled =

      {some boolean expression}

      ).

      That does not currently work with the Moodle 2.0 equivalent: html_writer::select.

      This patch fixes that.

        Activity

        Hide
        Tim Hunt added a comment -

        Oops. This is the right patch.

        Show
        Tim Hunt added a comment - Oops. This is the right patch.
        Hide
        Tim Hunt added a comment -

        PULL-113 created.

        Show
        Tim Hunt added a comment - PULL-113 created.
        Hide
        Petr Škoda added a comment -

        Instead of typing "pull created" please link the issues, thanks.

        Show
        Petr Škoda added a comment - Instead of typing "pull created" please link the issues, thanks.
        Hide
        Tim Hunt added a comment -

        OK. Noted for the future.

        Show
        Tim Hunt added a comment - OK. Noted for the future.
        Hide
        David Mudrak added a comment -

        Tested, works well. Thanks for this improvement Tim.

        Show
        David Mudrak added a comment - Tested, works well. Thanks for this improvement Tim.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: