Moodle
  1. Moodle
  2. MDL-25975

The user/selector ajax for searching users fails in IE8

    Details

    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Rank:
      15428

      Description

      Steps to replicate:
      1) Select a category
      2) In the settings block, select 'Assign Roles'
      3) Choose a role to assign
      4) Try to search by typing some text into the search text field below the user list.

      In IE8 this results in a javascript error complaining about an undefined object.

      Offending line:
      this.timeoutid = setTimeout(function(obj)

      {obj.send_query(false)}, this.querydelay*1000, this);

      This can be fixed by changing using YUI's 'later' function instead of setTimeout:
      this.timeoutid = Y.later(this.querydelay*1000, e, function(obj){obj.send_query(false)}

      , this);

      Patch file attached.

        Issue Links

          Activity

          Hide
          Helen Foster added a comment -

          Adam, thanks for your report with patch. Increasing the priority and hoping an HQ developer can look at it soon.

          Further discussion about the problem here: http://moodle.org/mod/forum/discuss.php?d=164924

          Show
          Helen Foster added a comment - Adam, thanks for your report with patch. Increasing the priority and hoping an HQ developer can look at it soon. Further discussion about the problem here: http://moodle.org/mod/forum/discuss.php?d=164924
          Hide
          Sam Hemelryk added a comment -

          Hi Adam,

          Thanks for reporting the issue and providing a fix. Most helpful!
          I'll check it out first thing Monday morning and if it's good look to get it into the integration cycle.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Hi Adam, Thanks for reporting the issue and providing a fix. Most helpful! I'll check it out first thing Monday morning and if it's good look to get it into the integration cycle. Cheers Sam
          Hide
          Tim Hunt added a comment -

          While looking at this, you may also want to look at MDL-25975.

          Show
          Tim Hunt added a comment - While looking at this, you may also want to look at MDL-25975 .
          Hide
          Sam Hemelryk added a comment -

          Damn, sorry guys I completely forgot about this in the rush of things.
          I am off to get work for the next month as I'm getting married so I'm assigning this to moodle.com and raising priority so it gets looked at seen as it has a patch (Thanks again for that).

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Damn, sorry guys I completely forgot about this in the rush of things. I am off to get work for the next month as I'm getting married so I'm assigning this to moodle.com and raising priority so it gets looked at seen as it has a patch (Thanks again for that). Cheers Sam
          Hide
          Sam Hemelryk added a comment -

          Thanks Adam,
          I've finally got around to looking at this issue, sorry it took so long.
          The patch worked fine, I tested before after etc... all good!

          I've created PULL-483 to see this integrated. Providing it passes integration and testing this will be included in the next weekly release on Wednesday.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Thanks Adam, I've finally got around to looking at this issue, sorry it took so long. The patch worked fine, I tested before after etc... all good! I've created PULL-483 to see this integrated. Providing it passes integration and testing this will be included in the next weekly release on Wednesday. Cheers Sam
          Hide
          Andrew Davis added a comment -

          Raised MDL-26927 while testing this.

          Show
          Andrew Davis added a comment - Raised MDL-26927 while testing this.
          Hide
          Helen Foster added a comment -

          I can confirm that this issue is fixed in this week's 2.0.2+. Thanks everyone.

          Show
          Helen Foster added a comment - I can confirm that this issue is fixed in this week's 2.0.2+. Thanks everyone.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: