Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-25987

Improve how question type settings pages are included in the admin tree

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.1
    • Fix Version/s: 2.0.2
    • Component/s: Questions
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      At the moment, admin/settings/plugins.php includes questionlib.php to get a list of all the question type plugins that may have settings pages. This is quite expensive (and for people who are logged in as admin, happens on every page).

      It would be cheaper and better to use the standard get_plugin_list.

      Note that no core question types have settings pages. I noticed and fixed this when working on an OU question type.

        Gliffy Diagrams

          Activity

          Hide
          timhunt Tim Hunt added a comment -

          Also, we should allow question type settings pages to be admin external pages. I am about to do another commit that allows that.

          Show
          timhunt Tim Hunt added a comment - Also, we should allow question type settings pages to be admin external pages. I am about to do another commit that allows that.
          Hide
          tsala Helen Foster added a comment -

          Tim, assuming this issue is fixed, as you've created a pull request.

          Show
          tsala Helen Foster added a comment - Tim, assuming this issue is fixed, as you've created a pull request.
          Hide
          tsala Helen Foster added a comment -

          Thanks for this improvement Tim.

          Show
          tsala Helen Foster added a comment - Thanks for this improvement Tim.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                21/Feb/11