Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-29160 META: en language pack improvements
  3. MDL-25996

Language editing interface terms

          Details

          • Type: Sub-task
          • Status: Closed
          • Priority: Minor
          • Resolution: Fixed
          • Affects Version/s: 2.0.1, 2.1, 2.2
          • Fix Version/s: 2.1.5, 2.2.2
          • Component/s: Language
          • Labels:
          • Environment:
            en language pack
          • Database:
            MySQL
          • Testing Instructions:
            Hide

            This is a no clear cut test for this one.

            1. Open the admin/tool/customlang/lang/en/tool_customlang.php (or admin/report/customlang/lang/en/report_customlang.php for 2.2) in patched version
              1. Make sure all variations of the word customisation use the Australian spelling of the word (an s instead of a z)
              2. Check that the descriptions are friendly to non developers
            Show
            This is a no clear cut test for this one. Open the admin/tool/customlang/lang/en/tool_customlang.php (or admin/report/customlang/lang/en/report_customlang.php for 2.2) in patched version Make sure all variations of the word customisation use the Australian spelling of the word (an s instead of a z ) Check that the descriptions are friendly to non developers
          • Affected Branches:
            MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
          • Fixed Branches:
            MOODLE_21_STABLE, MOODLE_22_STABLE
          • Pull from Repository:
          • Pull Master Branch:
            m_MDL-25996_making_language_editing_terms_user_friendly
          • Pull Master Diff URL:

            Description

            Language customization: Should be Language customisation, "z" is for en_us.

            Checkout strings into translator and Save and check in strings into files: These terms are less than useful for users who have no knowledge of the underlying technology. This is developer speak that needs to be replaced.

            Suggestions:

            Open language pack for editing
            Update language pack

            The first of these suggestions should be redundant in an ideal world as selecting the language should take the user directly to this page without the additional step - why else would you select the language from the drop-down?

              Gliffy Diagrams

                Attachments

                  Issue Links

                  has been marked as being related by

                  Improvement - An enhancement to an existing Moodle feature. MDL-31582 Random step in language customiser which involves clicking a button and nothing else.

                  • Minor - Minor loss of function where workaround is possible
                  • Open

                    Activity

                    Ascending order - Click to sort in descending order
                    Hide
                    Permalink
                    marycooch Mary Cooch added a comment -

                    I absolutely agree!

                    Show
                    marycooch Mary Cooch added a comment - I absolutely agree!
                    Hide
                    Permalink
                    koen Koen Roggemans added a comment -

                    English langpack is for moodle.com - Helen will take care of it.

                    Show
                    koen Koen Roggemans added a comment - English langpack is for moodle.com - Helen will take care of it.
                    Hide
                    Permalink
                    tsala Helen Foster added a comment -

                    Ray, thanks for your report and apologies for not yet getting around to amending the language strings as suggested. I'm currently going through open language string issues and adding them as subtasks to MDL-29160 for an HQ developer to easily fix.

                    Show
                    tsala Helen Foster added a comment - Ray, thanks for your report and apologies for not yet getting around to amending the language strings as suggested. I'm currently going through open language string issues and adding them as subtasks to MDL-29160 for an HQ developer to easily fix.
                    Hide
                    Permalink
                    gerry Gerard Caulfield added a comment -

                    Hi Ray

                    I also agree.

                    Regarding the ideal world you mention, I have submitted an issue so that we can start working towards it MDL-31582 That extra step baffles me too.

                    I'm currently working on the other language issues.

                    Thank you for your input and time

                    Show
                    gerry Gerard Caulfield added a comment - Hi Ray I also agree. Regarding the ideal world you mention, I have submitted an issue so that we can start working towards it MDL-31582 That extra step baffles me too. I'm currently working on the other language issues. Thank you for your input and time
                    Hide
                    Permalink
                    poltawski Dan Poltawski added a comment -

                    Looks good to me!

                    Show
                    poltawski Dan Poltawski added a comment - Looks good to me!
                    Hide
                    Permalink
                    gerry Gerard Caulfield added a comment -

                    Thanks for reviewing this Dan

                    Show
                    gerry Gerard Caulfield added a comment - Thanks for reviewing this Dan
                    Hide
                    Permalink
                    stronk7 Eloy Lafuente (stronk7) added a comment -

                    The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

                    TIA and ciao

                    Show
                    stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
                    Hide
                    Permalink
                    gerry Gerard Caulfield added a comment -

                    rebased.

                    Show
                    gerry Gerard Caulfield added a comment - rebased.
                    Hide
                    Permalink
                    stronk7 Eloy Lafuente (stronk7) added a comment -

                    Uhm... it surprised me to find that:

                    • the 22_STABLE branch had 4 less lines modified. Seems that the strings 'checkin' and 'savecontinue' have been NOT modified there.
                    • the 21_STABLE branch has (adds) a trailing white line not present in other branches.
                    • The 'savecheckin' string has different translations in master/22_STABLE

                    Perhaps we could, simply, prepare the master branch and cherry-pick it both to 22 and 21 stables? Just to make them 100% the same fix (unless there is some reason to keep them different).

                    Holding this for some hours....ciao

                    Show
                    stronk7 Eloy Lafuente (stronk7) added a comment - Uhm... it surprised me to find that: the 22_STABLE branch had 4 less lines modified. Seems that the strings 'checkin' and 'savecontinue' have been NOT modified there. the 21_STABLE branch has (adds) a trailing white line not present in other branches. The 'savecheckin' string has different translations in master/22_STABLE Perhaps we could, simply, prepare the master branch and cherry-pick it both to 22 and 21 stables? Just to make them 100% the same fix (unless there is some reason to keep them different). Holding this for some hours....ciao
                    Hide
                    Permalink
                    gerry Gerard Caulfield added a comment -

                    Looking at this now

                    Show
                    gerry Gerard Caulfield added a comment - Looking at this now
                    Hide
                    Permalink
                    gerry Gerard Caulfield added a comment -

                    Fixed the mentioned issues. Thanks Eloy.

                    Show
                    gerry Gerard Caulfield added a comment - Fixed the mentioned issues. Thanks Eloy.
                    Hide
                    Permalink
                    stronk7 Eloy Lafuente (stronk7) added a comment -

                    Integrated (21, 22 & master), thanks!

                    Show
                    stronk7 Eloy Lafuente (stronk7) added a comment - Integrated (21, 22 & master), thanks!
                    Hide
                    Permalink
                    rajeshtaneja Rajesh Taneja added a comment -

                    Looks Good,
                    Checked "Language customisation" and all string appear fine.

                    Few Questions:

                    1. Do we need to change string keys to reflect en-au ? like $string['filtercustomized'] ?
                    2. Should we break long strings in multiple lines with strong tags, so they appear nicely on confirmation screen.
                    Show
                    rajeshtaneja Rajesh Taneja added a comment - Looks Good, Checked "Language customisation" and all string appear fine. Few Questions: Do we need to change string keys to reflect en-au ? like $string ['filtercustomized'] ? Should we break long strings in multiple lines with strong tags, so they appear nicely on confirmation screen.
                    Hide
                    Permalink
                    stronk7 Eloy Lafuente (stronk7) added a comment -

                    Some changes to Moodle should be milestones in the project by themselves.

                    This is not the case and your fix is not so important, but your collaboration is highly appreciated, thanks!

                    Closing as fixed, ciao

                    Show
                    stronk7 Eloy Lafuente (stronk7) added a comment - Some changes to Moodle should be milestones in the project by themselves. This is not the case and your fix is not so important, but your collaboration is highly appreciated, thanks! Closing as fixed, ciao

                      People

                      • Votes:
                        3 Vote for this issue
                        Watchers:
                        5 Start watching this issue

                        Dates

                        • Created:
                          Updated:
                          Resolved:
                          Fix Release Date:
                          12/Mar/12