Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.1
    • Fix Version/s: 2.0.3
    • Component/s: Themes
    • Labels:
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      RTL patches to the theme/core and other plugins in Moodle 2
      (By the RTL/BIDI Hebrew Translation team, Shenkar College, Israel)

        Gliffy Diagrams

          Attachments

          1. base_admin_css.patch
            0.5 kB
          2. base_blocks.css.patch
            0.6 kB
          3. base_core_css.patch
            0.8 kB
          4. base_core_css.patch
            0.4 kB
          5. base_core_css.patch
            0.5 kB
          6. base_core_css.patch
            0.5 kB
          7. base_core.css.patch
            0.5 kB
          8. base_core.css.patch
            1 kB
          9. base_core.css.patch
            1 kB
          10. base_pagelayout.css.patch
            1 kB
          11. base_pagelayout.css.patch
            0.8 kB
          12. base_questions_css.patch
            1 kB
          13. base_style_admin.css.patch
            1 kB
          14. base_style_admin.css.patch
            0.5 kB
          15. base_style_blocks.css.patch
            0.7 kB
          16. base_style_blocks.css.patch
            0.6 kB
          17. base_style_calendar.css.patch
            0.9 kB
          18. base_style_core.css.patch
            1 kB
          19. base_style_core.css.patch
            0.7 kB
          20. base_style_user.css.patch
            0.6 kB
          21. base_user_css.patch
            0.6 kB
          22. block_navigation_styles.patch
            0.8 kB
          23. blocks_messages_style.css.patch
            0.7 kB
          24. blocks_online_users_styles.css.patch
            0.6 kB
          25. blocks_recent_activity_styles.css.patch
            0.6 kB
          26. chat_gui_ajax_theme_bubble_chat_css.patch
            2 kB
          27. chat_gui_ajax_theme_compact_chat_css.patch
            0.8 kB
          28. core.css.patch
            0.5 kB
          29. enrolmentmanager.css.patch
            0.8 kB
          30. local_history.patch
            0.8 kB
          31. mod_assignment_styles.css.patch
            0.5 kB
          32. mod_assignment_styles.css.patch
            0.4 kB
          33. mod_assignment_styles.css.patch
            0.7 kB
          34. mod_data_lib.php.patch
            1 kB
          35. mod_data_lib.php.patch
            0.9 kB
          36. mod_data_styles.css.patch
            0.5 kB
          37. mod_data_styles.css.patch
            0.6 kB
          38. mod_wiki_styles.css.patch
            0.6 kB
          39. quiz_styles_css.patch
            2 kB
          40. standard_modules.css.patch
            1 kB
          41. standard_style_modules.patch
            0.7 kB
          42. styles.css
            0.1 kB
          43. styles.css
            0.1 kB
          44. tinymce_clearlooks2_window.css.patch
            0.9 kB
          45. tinymce_o2k7_ui.css.patch
            2 kB
          46. tinymce_o2k7_ui.css.patch
            1 kB
          47. treeview-sprite-rtl.gif
            treeview-sprite-rtl.gif
            4 kB
          48. yui_sam_skin.css.patch
            24 kB
          49. yui282_build_assets_skins_sam_skin.css.patch
            6 kB
          50. yui282_build_assets_skins_sam_skin.css.patch
            0.5 kB

            Issue Links

              Activity

              Hide
              nadavkav Nadav Kavalerchik added a comment -

              fix reviewoptionshdr (review options section) layout in mod/quiz/styles.css

              Show
              nadavkav Nadav Kavalerchik added a comment - fix reviewoptionshdr (review options section) layout in mod/quiz/styles.css
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              fix Enrol User (yui dialog) moodle2/enrol/yui/enrolmentmanager/assets/skins/sam/enrolmentmanager.css

              Show
              nadavkav Nadav Kavalerchik added a comment - fix Enrol User (yui dialog) moodle2/enrol/yui/enrolmentmanager/assets/skins/sam/enrolmentmanager.css
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              show numerical bullets (somehow, setting overflow:auto hides the bullets after tinymce submit the content)

              Show
              nadavkav Nadav Kavalerchik added a comment - show numerical bullets (somehow, setting overflow:auto hides the bullets after tinymce submit the content)
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              when not setting a discription to an image in tinymce, the notice text message in Image's "missing description" dialog is off dialog

              Show
              nadavkav Nadav Kavalerchik added a comment - when not setting a discription to an image in tinymce, the notice text message in Image's "missing description" dialog is off dialog
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              tinymce@ right align : mouse right click popup menu items & comboboxes: font, font-size, format item lists

              Show
              nadavkav Nadav Kavalerchik added a comment - tinymce@ right align : mouse right click popup menu items & comboboxes: font, font-size, format item lists
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              ui.css update: right align font, font-size and format combobox titles

              Show
              nadavkav Nadav Kavalerchik added a comment - ui.css update: right align font, font-size and format combobox titles
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              file picker: right align text & switch file plugins and file list DIVs (to support rtl direction layout)

              Show
              nadavkav Nadav Kavalerchik added a comment - file picker: right align text & switch file plugins and file list DIVs (to support rtl direction layout)
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              update: left align all input#id_externalurl (url) form fields

              Show
              nadavkav Nadav Kavalerchik added a comment - update: left align all input#id_externalurl (url) form fields
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              right align block's title and icons

              Show
              nadavkav Nadav Kavalerchik added a comment - right align block's title and icons
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              right align glossary posts

              Show
              nadavkav Nadav Kavalerchik added a comment - right align glossary posts
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              right align columns in assignment submissions table

              Show
              nadavkav Nadav Kavalerchik added a comment - right align columns in assignment submissions table
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              fix assignment grading form layout

              Show
              nadavkav Nadav Kavalerchik added a comment - fix assignment grading form layout
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              right align tinymce text format combobox to textarea box

              Show
              nadavkav Nadav Kavalerchik added a comment - right align tinymce text format combobox to textarea box
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              shrink to fit, submitted file (or online) assignment dialog

              Show
              nadavkav Nadav Kavalerchik added a comment - shrink to fit, submitted file (or online) assignment dialog
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              moodle2/theme/base/style/pagelayout.css
              (update) last patch introduced visual regression in course layout, oups.

              Show
              nadavkav Nadav Kavalerchik added a comment - moodle2/theme/base/style/pagelayout.css (update) last patch introduced visual regression in course layout, oups.
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              right align filepicker upload list (paragraph) in assignment type: single file upload

              Show
              nadavkav Nadav Kavalerchik added a comment - right align filepicker upload list (paragraph) in assignment type: single file upload
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              right align group management page

              Show
              nadavkav Nadav Kavalerchik added a comment - right align group management page
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              right align add users to group page

              Show
              nadavkav Nadav Kavalerchik added a comment - right align add users to group page
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              right align permissions names in course user permissions page

              Show
              nadavkav Nadav Kavalerchik added a comment - right align permissions names in course user permissions page
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              right align textarea format listbox (in questions form)

              Show
              nadavkav Nadav Kavalerchik added a comment - right align textarea format listbox (in questions form)
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              right align question preview page

              Show
              nadavkav Nadav Kavalerchik added a comment - right align question preview page
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              fix right side display of icons on block navigation

              Show
              nadavkav Nadav Kavalerchik added a comment - fix right side display of icons on block navigation
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              right align headers in the basic chat gui UI

              Show
              nadavkav Nadav Kavalerchik added a comment - right align headers in the basic chat gui UI
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              right align chat ajax gui theme compact

              Show
              nadavkav Nadav Kavalerchik added a comment - right align chat ajax gui theme compact
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              right align chat ajax gui theme bubble

              Show
              nadavkav Nadav Kavalerchik added a comment - right align chat ajax gui theme bubble
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              right align forum discussion subjects

              Show
              nadavkav Nadav Kavalerchik added a comment - right align forum discussion subjects
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              minor update

              Show
              nadavkav Nadav Kavalerchik added a comment - minor update
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              right align UI elements in the edit quiz page

              Show
              nadavkav Nadav Kavalerchik added a comment - right align UI elements in the edit quiz page
              Hide
              ohameiri omer added a comment -

              hi, any idea when all of these updates will be merged into to official release ?

              omer

              Show
              ohameiri omer added a comment - hi, any idea when all of these updates will be merged into to official release ? omer
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              table cell alignment support when creating a new "Add Template"

              Show
              nadavkav Nadav Kavalerchik added a comment - table cell alignment support when creating a new "Add Template"
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              Enable longer lines of text in the Navigation block menu (usability)

              Show
              nadavkav Nadav Kavalerchik added a comment - Enable longer lines of text in the Navigation block menu (usability)
              Hide
              nadavkav Nadav Kavalerchik added a comment - - edited

              right align Module DATA's Template generated table cells (LTR and RTL)

              Show
              nadavkav Nadav Kavalerchik added a comment - - edited right align Module DATA's Template generated table cells (LTR and RTL)
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              Module Data, pad exporting option list (usability)

              Show
              nadavkav Nadav Kavalerchik added a comment - Module Data, pad exporting option list (usability)
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              Align all INPUT textboxes that show URLs to the left (Both LTR and RTL modes)

              Show
              nadavkav Nadav Kavalerchik added a comment - Align all INPUT textboxes that show URLs to the left (Both LTR and RTL modes)
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              left align text in File Picker's header (RTL mode)

              Show
              nadavkav Nadav Kavalerchik added a comment - left align text in File Picker's header (RTL mode)
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              right align listbox headers in admin/role/assign.php

              Show
              nadavkav Nadav Kavalerchik added a comment - right align listbox headers in admin/role/assign.php
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              right align Name column in Modules,Blocks,Filters... admin tables
              + center all admin tables

              Show
              nadavkav Nadav Kavalerchik added a comment - right align Name column in Modules,Blocks,Filters... admin tables + center all admin tables
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              update (include admin settings block)

              Show
              nadavkav Nadav Kavalerchik added a comment - update (include admin settings block)
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              treeview-sprite-rtl.gif goes into moodle2/lib/yui/2.8.2/build/assets/skins/sam/treeview-sprite-rtl.gif

              + sam skin.css updates to support RTL treeview gif

              Show
              nadavkav Nadav Kavalerchik added a comment - treeview-sprite-rtl.gif goes into moodle2/lib/yui/2.8.2/build/assets/skins/sam/treeview-sprite-rtl.gif + sam skin.css updates to support RTL treeview gif
              Hide
              nadavkav Nadav Kavalerchik added a comment - - edited

              right align user names Block Online Users

              Show
              nadavkav Nadav Kavalerchik added a comment - - edited right align user names Block Online Users
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              right align text in Block Messages

              Show
              nadavkav Nadav Kavalerchik added a comment - right align text in Block Messages
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              block news_items, align name and date fields

              Show
              nadavkav Nadav Kavalerchik added a comment - block news_items, align name and date fields
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              align rounded corners (calendar event view)

              Show
              nadavkav Nadav Kavalerchik added a comment - align rounded corners (calendar event view)
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              right align item's header (random glossary block)

              Show
              nadavkav Nadav Kavalerchik added a comment - right align item's header (random glossary block)
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              right align cells in participants table
              + center table on the page

              Show
              nadavkav Nadav Kavalerchik added a comment - right align cells in participants table + center table on the page
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              right align item's header (block recent activity)

              Show
              nadavkav Nadav Kavalerchik added a comment - right align item's header (block recent activity)
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              wiki report, align buttons
              + center report table

              Show
              nadavkav Nadav Kavalerchik added a comment - wiki report, align buttons + center report table
              Hide
              ohameiri omer added a comment -

              hi nadav,
              do you have any idea whan all of this will be merged to the official release ?

              omer

              Show
              ohameiri omer added a comment - hi nadav, do you have any idea whan all of this will be merged to the official release ? omer
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              right align "print wiki page"

              Show
              nadavkav Nadav Kavalerchik added a comment - right align "print wiki page"
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              updates (format listbox alignment, on various settings pages)

              Show
              nadavkav Nadav Kavalerchik added a comment - updates (format listbox alignment, on various settings pages)
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              Hi Omer

              Not sure It's been a while...

              We wrote an email to Martin two weeks ago and we did not get any response.
              I will discuss a solution (tomorrow) with the Translation Team.
              We consider posting a special Moodle 2 release, until we get a response from Moodle HQ.

              Show
              nadavkav Nadav Kavalerchik added a comment - Hi Omer Not sure It's been a while... We wrote an email to Martin two weeks ago and we did not get any response. I will discuss a solution (tomorrow) with the Translation Team. We consider posting a special Moodle 2 release, until we get a response from Moodle HQ.
              Hide
              ohameiri omer added a comment -

              hi,
              due to many bugs in my currently installed version i have to upgrade al of my installations (over 70) to the latest release.

              wish it had included your fixes....

              :\

              Show
              ohameiri omer added a comment - hi, due to many bugs in my currently installed version i have to upgrade al of my installations (over 70) to the latest release. wish it had included your fixes.... :\
              Hide
              dougiamas Martin Dougiamas added a comment - - edited

              Thanks guys! Sorry about the long time since you had a response. Lots of things happening.

              Someone from the STABLE sprint team will review these, and produce some new rebased PULL requests for integration.

              Show
              dougiamas Martin Dougiamas added a comment - - edited Thanks guys! Sorry about the long time since you had a response. Lots of things happening. Someone from the STABLE sprint team will review these, and produce some new rebased PULL requests for integration.
              Hide
              samhemelryk Sam Hemelryk added a comment -

              Hi Nadav,

              I've been through all your patches now, merged them into stable and dev, and have reviewed all of them.
              I've created two PULL requests to see your changes integrated PULL-663 and PULL-664.
              Providing these pass the weekly review they will be in the upcoming weekly releases.

              Most of your patches were spot on however I did alter several and there were a few that did not make it in.
              For future patches keen the following in mind:

              1. Don't make changes within 3rd party libs, we don't make any changes that arn't 100% required there as it always causing problems later on. Instead just make the required changes in the base/standard theme.
              2. We don't put any browser specific CSS into base unless we absolutely need to, this is things such as border radius and such.
              3. Try to avoid rules like select[name=*introeditor]. There is always a better way, in this case those format boxes were associated with the editor so .felement.feditor select worked fine.

              At this point I'll close this issue.
              If you produce any further patches please do share them with us but create a new issue. We've changed the way we inspect new bugs and if you create a new bug and attach a patch it will be looked at sooner, hopefully this will lead to your work being integrated quicker.

              One more thing, I made you the author of the changes so that you get credit within our git repository, I used the email address on your tracker profile I hope thats OK.

              Cheers
              Sam

              Show
              samhemelryk Sam Hemelryk added a comment - Hi Nadav, I've been through all your patches now, merged them into stable and dev, and have reviewed all of them. I've created two PULL requests to see your changes integrated PULL-663 and PULL-664. Providing these pass the weekly review they will be in the upcoming weekly releases. Most of your patches were spot on however I did alter several and there were a few that did not make it in. For future patches keen the following in mind: Don't make changes within 3rd party libs, we don't make any changes that arn't 100% required there as it always causing problems later on. Instead just make the required changes in the base/standard theme. We don't put any browser specific CSS into base unless we absolutely need to, this is things such as border radius and such. Try to avoid rules like select [name=*introeditor] . There is always a better way, in this case those format boxes were associated with the editor so .felement.feditor select worked fine. At this point I'll close this issue. If you produce any further patches please do share them with us but create a new issue. We've changed the way we inspect new bugs and if you create a new bug and attach a patch it will be looked at sooner, hopefully this will lead to your work being integrated quicker. One more thing, I made you the author of the changes so that you get credit within our git repository, I used the email address on your tracker profile I hope thats OK. Cheers Sam
              Hide
              samhemelryk Sam Hemelryk added a comment -

              Linked PULL-663 and PULL-664

              Show
              samhemelryk Sam Hemelryk added a comment - Linked PULL-663 and PULL-664
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              Hi Sam

              Thank you very much!

              I was really looking forward for those remarks you gave me,
              Since i was coding in the dark and was not sure what was the right
              strategic you guys prefer. especially when i got no response over time to my patches.

              So, thank you very much

              For the future...
              I am not sure i know where and how to open PULL request. (Can you link me to some info?)
              I do have some experience with projects i manage on Github and i work with git all the time.
              I even have all the changes we (the Moodle Hebrew Translation Team) make to Moodle 1.9.x
              on github (https://github.com/nadavkav/Moodle-RTL--Shenkar-Translation-Team-) and MDL-22952

              Thank you for making me the Auther, too.

              Show
              nadavkav Nadav Kavalerchik added a comment - Hi Sam Thank you very much! I was really looking forward for those remarks you gave me, Since i was coding in the dark and was not sure what was the right strategic you guys prefer. especially when i got no response over time to my patches. So, thank you very much For the future... I am not sure i know where and how to open PULL request. (Can you link me to some info?) I do have some experience with projects i manage on Github and i work with git all the time. I even have all the changes we (the Moodle Hebrew Translation Team) make to Moodle 1.9.x on github ( https://github.com/nadavkav/Moodle-RTL--Shenkar-Translation-Team- ) and MDL-22952 Thank you for making me the Auther, too.
              Hide
              samhemelryk Sam Hemelryk added a comment -

              Hi Nadav,

              I wrote a docs page the other day about my development process when working on Moodle with Git.

              http://docs.moodle.org/en/User:Sam_Hemelryk/My_Moodle_Git_workflow

              Hopefully that will answer some of the questions that you have about PULL requests.
              If you have any doubts just ask on the MDL question (or within the PULL request if you have created one).

              Cheers
              Sam

              Show
              samhemelryk Sam Hemelryk added a comment - Hi Nadav, I wrote a docs page the other day about my development process when working on Moodle with Git. http://docs.moodle.org/en/User:Sam_Hemelryk/My_Moodle_Git_workflow Hopefully that will answer some of the questions that you have about PULL requests. If you have any doubts just ask on the MDL question (or within the PULL request if you have created one). Cheers Sam
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              Hi Sam

              That was very (very) helpful!
              Thank you

              Show
              nadavkav Nadav Kavalerchik added a comment - Hi Sam That was very (very) helpful! Thank you

                People

                • Votes:
                  2 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    5/May/11