Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.1
    • Fix Version/s: 2.0.3
    • Component/s: Themes
    • Labels:
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      RTL patches to the theme/core and other plugins in Moodle 2
      (By the RTL/BIDI Hebrew Translation team, Shenkar College, Israel)

        Gliffy Diagrams

        1. base_admin_css.patch
          0.5 kB
          Nadav Kavalerchik
        2. base_blocks.css.patch
          0.6 kB
          Nadav Kavalerchik
        3. base_core_css.patch
          0.8 kB
          Nadav Kavalerchik
        4. base_core_css.patch
          0.4 kB
          Nadav Kavalerchik
        5. base_core_css.patch
          0.5 kB
          Nadav Kavalerchik
        6. base_core_css.patch
          0.5 kB
          Nadav Kavalerchik
        7. base_core.css.patch
          0.5 kB
          Nadav Kavalerchik
        8. base_core.css.patch
          1 kB
          Nadav Kavalerchik
        9. base_core.css.patch
          1 kB
          Nadav Kavalerchik
        10. base_pagelayout.css.patch
          1 kB
          Nadav Kavalerchik
        11. base_pagelayout.css.patch
          0.8 kB
          Nadav Kavalerchik
        12. base_questions_css.patch
          1 kB
          Nadav Kavalerchik
        13. base_style_admin.css.patch
          1 kB
          Nadav Kavalerchik
        14. base_style_admin.css.patch
          0.5 kB
          Nadav Kavalerchik
        15. base_style_blocks.css.patch
          0.7 kB
          Nadav Kavalerchik
        16. base_style_blocks.css.patch
          0.6 kB
          Nadav Kavalerchik
        17. base_style_calendar.css.patch
          0.9 kB
          Nadav Kavalerchik
        18. base_style_core.css.patch
          1 kB
          Nadav Kavalerchik
        19. base_style_core.css.patch
          0.7 kB
          Nadav Kavalerchik
        20. base_style_user.css.patch
          0.6 kB
          Nadav Kavalerchik
        21. base_user_css.patch
          0.6 kB
          Nadav Kavalerchik
        22. block_navigation_styles.patch
          0.8 kB
          Nadav Kavalerchik
        23. blocks_messages_style.css.patch
          0.7 kB
          Nadav Kavalerchik
        24. blocks_online_users_styles.css.patch
          0.6 kB
          Nadav Kavalerchik
        25. blocks_recent_activity_styles.css.patch
          0.6 kB
          Nadav Kavalerchik
        26. chat_gui_ajax_theme_bubble_chat_css.patch
          2 kB
          Nadav Kavalerchik
        27. chat_gui_ajax_theme_compact_chat_css.patch
          0.8 kB
          Nadav Kavalerchik
        28. core.css.patch
          0.5 kB
          Nadav Kavalerchik
        29. enrolmentmanager.css.patch
          0.8 kB
          Nadav Kavalerchik
        30. local_history.patch
          0.8 kB
          Nadav Kavalerchik
        31. mod_assignment_styles.css.patch
          0.5 kB
          Nadav Kavalerchik
        32. mod_assignment_styles.css.patch
          0.4 kB
          Nadav Kavalerchik
        33. mod_assignment_styles.css.patch
          0.7 kB
          Nadav Kavalerchik
        34. mod_data_lib.php.patch
          1 kB
          Nadav Kavalerchik
        35. mod_data_lib.php.patch
          0.9 kB
          Nadav Kavalerchik
        36. mod_data_styles.css.patch
          0.5 kB
          Nadav Kavalerchik
        37. mod_data_styles.css.patch
          0.6 kB
          Nadav Kavalerchik
        38. mod_wiki_styles.css.patch
          0.6 kB
          Nadav Kavalerchik
        39. quiz_styles_css.patch
          2 kB
          Nadav Kavalerchik
        40. standard_modules.css.patch
          1 kB
          Nadav Kavalerchik
        41. standard_style_modules.patch
          0.7 kB
          Nadav Kavalerchik
        42. styles.css
          0.1 kB
          Nadav Kavalerchik
        43. styles.css
          0.1 kB
          Nadav Kavalerchik
        44. tinymce_clearlooks2_window.css.patch
          0.9 kB
          Nadav Kavalerchik
        45. tinymce_o2k7_ui.css.patch
          2 kB
          Nadav Kavalerchik
        46. tinymce_o2k7_ui.css.patch
          1 kB
          Nadav Kavalerchik
        47. yui_sam_skin.css.patch
          24 kB
          Nadav Kavalerchik
        48. yui282_build_assets_skins_sam_skin.css.patch
          6 kB
          Nadav Kavalerchik
        49. yui282_build_assets_skins_sam_skin.css.patch
          0.5 kB
          Nadav Kavalerchik
        1. treeview-sprite-rtl.gif
          4 kB

          Issue Links

            Activity

            Hide
            Nadav Kavalerchik added a comment -

            fix reviewoptionshdr (review options section) layout in mod/quiz/styles.css

            Show
            Nadav Kavalerchik added a comment - fix reviewoptionshdr (review options section) layout in mod/quiz/styles.css
            Hide
            Nadav Kavalerchik added a comment -

            fix Enrol User (yui dialog) moodle2/enrol/yui/enrolmentmanager/assets/skins/sam/enrolmentmanager.css

            Show
            Nadav Kavalerchik added a comment - fix Enrol User (yui dialog) moodle2/enrol/yui/enrolmentmanager/assets/skins/sam/enrolmentmanager.css
            Hide
            Nadav Kavalerchik added a comment -

            show numerical bullets (somehow, setting overflow:auto hides the bullets after tinymce submit the content)

            Show
            Nadav Kavalerchik added a comment - show numerical bullets (somehow, setting overflow:auto hides the bullets after tinymce submit the content)
            Hide
            Nadav Kavalerchik added a comment -

            when not setting a discription to an image in tinymce, the notice text message in Image's "missing description" dialog is off dialog

            Show
            Nadav Kavalerchik added a comment - when not setting a discription to an image in tinymce, the notice text message in Image's "missing description" dialog is off dialog
            Hide
            Nadav Kavalerchik added a comment -

            tinymce@ right align : mouse right click popup menu items & comboboxes: font, font-size, format item lists

            Show
            Nadav Kavalerchik added a comment - tinymce@ right align : mouse right click popup menu items & comboboxes: font, font-size, format item lists
            Hide
            Nadav Kavalerchik added a comment -

            ui.css update: right align font, font-size and format combobox titles

            Show
            Nadav Kavalerchik added a comment - ui.css update: right align font, font-size and format combobox titles
            Hide
            Nadav Kavalerchik added a comment -

            file picker: right align text & switch file plugins and file list DIVs (to support rtl direction layout)

            Show
            Nadav Kavalerchik added a comment - file picker: right align text & switch file plugins and file list DIVs (to support rtl direction layout)
            Hide
            Nadav Kavalerchik added a comment -

            update: left align all input#id_externalurl (url) form fields

            Show
            Nadav Kavalerchik added a comment - update: left align all input#id_externalurl (url) form fields
            Hide
            Nadav Kavalerchik added a comment -

            right align block's title and icons

            Show
            Nadav Kavalerchik added a comment - right align block's title and icons
            Hide
            Nadav Kavalerchik added a comment -

            right align glossary posts

            Show
            Nadav Kavalerchik added a comment - right align glossary posts
            Hide
            Nadav Kavalerchik added a comment -

            right align columns in assignment submissions table

            Show
            Nadav Kavalerchik added a comment - right align columns in assignment submissions table
            Hide
            Nadav Kavalerchik added a comment -

            fix assignment grading form layout

            Show
            Nadav Kavalerchik added a comment - fix assignment grading form layout
            Hide
            Nadav Kavalerchik added a comment -

            right align tinymce text format combobox to textarea box

            Show
            Nadav Kavalerchik added a comment - right align tinymce text format combobox to textarea box
            Hide
            Nadav Kavalerchik added a comment -

            shrink to fit, submitted file (or online) assignment dialog

            Show
            Nadav Kavalerchik added a comment - shrink to fit, submitted file (or online) assignment dialog
            Hide
            Nadav Kavalerchik added a comment -

            moodle2/theme/base/style/pagelayout.css
            (update) last patch introduced visual regression in course layout, oups.

            Show
            Nadav Kavalerchik added a comment - moodle2/theme/base/style/pagelayout.css (update) last patch introduced visual regression in course layout, oups.
            Hide
            Nadav Kavalerchik added a comment -

            right align filepicker upload list (paragraph) in assignment type: single file upload

            Show
            Nadav Kavalerchik added a comment - right align filepicker upload list (paragraph) in assignment type: single file upload
            Hide
            Nadav Kavalerchik added a comment -

            right align group management page

            Show
            Nadav Kavalerchik added a comment - right align group management page
            Hide
            Nadav Kavalerchik added a comment -

            right align add users to group page

            Show
            Nadav Kavalerchik added a comment - right align add users to group page
            Hide
            Nadav Kavalerchik added a comment -

            right align permissions names in course user permissions page

            Show
            Nadav Kavalerchik added a comment - right align permissions names in course user permissions page
            Hide
            Nadav Kavalerchik added a comment -

            right align textarea format listbox (in questions form)

            Show
            Nadav Kavalerchik added a comment - right align textarea format listbox (in questions form)
            Hide
            Nadav Kavalerchik added a comment -

            right align question preview page

            Show
            Nadav Kavalerchik added a comment - right align question preview page
            Hide
            Nadav Kavalerchik added a comment -

            fix right side display of icons on block navigation

            Show
            Nadav Kavalerchik added a comment - fix right side display of icons on block navigation
            Hide
            Nadav Kavalerchik added a comment -

            right align headers in the basic chat gui UI

            Show
            Nadav Kavalerchik added a comment - right align headers in the basic chat gui UI
            Hide
            Nadav Kavalerchik added a comment -

            right align chat ajax gui theme compact

            Show
            Nadav Kavalerchik added a comment - right align chat ajax gui theme compact
            Hide
            Nadav Kavalerchik added a comment -

            right align chat ajax gui theme bubble

            Show
            Nadav Kavalerchik added a comment - right align chat ajax gui theme bubble
            Hide
            Nadav Kavalerchik added a comment -

            right align forum discussion subjects

            Show
            Nadav Kavalerchik added a comment - right align forum discussion subjects
            Hide
            Nadav Kavalerchik added a comment -

            minor update

            Show
            Nadav Kavalerchik added a comment - minor update
            Hide
            Nadav Kavalerchik added a comment -

            right align UI elements in the edit quiz page

            Show
            Nadav Kavalerchik added a comment - right align UI elements in the edit quiz page
            Hide
            omer added a comment -

            hi, any idea when all of these updates will be merged into to official release ?

            omer

            Show
            omer added a comment - hi, any idea when all of these updates will be merged into to official release ? omer
            Hide
            Nadav Kavalerchik added a comment -

            table cell alignment support when creating a new "Add Template"

            Show
            Nadav Kavalerchik added a comment - table cell alignment support when creating a new "Add Template"
            Hide
            Nadav Kavalerchik added a comment -

            Enable longer lines of text in the Navigation block menu (usability)

            Show
            Nadav Kavalerchik added a comment - Enable longer lines of text in the Navigation block menu (usability)
            Hide
            Nadav Kavalerchik added a comment - - edited

            right align Module DATA's Template generated table cells (LTR and RTL)

            Show
            Nadav Kavalerchik added a comment - - edited right align Module DATA's Template generated table cells (LTR and RTL)
            Hide
            Nadav Kavalerchik added a comment -

            Module Data, pad exporting option list (usability)

            Show
            Nadav Kavalerchik added a comment - Module Data, pad exporting option list (usability)
            Hide
            Nadav Kavalerchik added a comment -

            Align all INPUT textboxes that show URLs to the left (Both LTR and RTL modes)

            Show
            Nadav Kavalerchik added a comment - Align all INPUT textboxes that show URLs to the left (Both LTR and RTL modes)
            Hide
            Nadav Kavalerchik added a comment -

            left align text in File Picker's header (RTL mode)

            Show
            Nadav Kavalerchik added a comment - left align text in File Picker's header (RTL mode)
            Hide
            Nadav Kavalerchik added a comment -

            right align listbox headers in admin/role/assign.php

            Show
            Nadav Kavalerchik added a comment - right align listbox headers in admin/role/assign.php
            Hide
            Nadav Kavalerchik added a comment -

            right align Name column in Modules,Blocks,Filters... admin tables
            + center all admin tables

            Show
            Nadav Kavalerchik added a comment - right align Name column in Modules,Blocks,Filters... admin tables + center all admin tables
            Hide
            Nadav Kavalerchik added a comment -

            update (include admin settings block)

            Show
            Nadav Kavalerchik added a comment - update (include admin settings block)
            Hide
            Nadav Kavalerchik added a comment -

            treeview-sprite-rtl.gif goes into moodle2/lib/yui/2.8.2/build/assets/skins/sam/treeview-sprite-rtl.gif

            + sam skin.css updates to support RTL treeview gif

            Show
            Nadav Kavalerchik added a comment - treeview-sprite-rtl.gif goes into moodle2/lib/yui/2.8.2/build/assets/skins/sam/treeview-sprite-rtl.gif + sam skin.css updates to support RTL treeview gif
            Hide
            Nadav Kavalerchik added a comment - - edited

            right align user names Block Online Users

            Show
            Nadav Kavalerchik added a comment - - edited right align user names Block Online Users
            Hide
            Nadav Kavalerchik added a comment -

            right align text in Block Messages

            Show
            Nadav Kavalerchik added a comment - right align text in Block Messages
            Hide
            Nadav Kavalerchik added a comment -

            block news_items, align name and date fields

            Show
            Nadav Kavalerchik added a comment - block news_items, align name and date fields
            Hide
            Nadav Kavalerchik added a comment -

            align rounded corners (calendar event view)

            Show
            Nadav Kavalerchik added a comment - align rounded corners (calendar event view)
            Hide
            Nadav Kavalerchik added a comment -

            right align item's header (random glossary block)

            Show
            Nadav Kavalerchik added a comment - right align item's header (random glossary block)
            Hide
            Nadav Kavalerchik added a comment -

            right align cells in participants table
            + center table on the page

            Show
            Nadav Kavalerchik added a comment - right align cells in participants table + center table on the page
            Hide
            Nadav Kavalerchik added a comment -

            right align item's header (block recent activity)

            Show
            Nadav Kavalerchik added a comment - right align item's header (block recent activity)
            Hide
            Nadav Kavalerchik added a comment -

            wiki report, align buttons
            + center report table

            Show
            Nadav Kavalerchik added a comment - wiki report, align buttons + center report table
            Hide
            omer added a comment -

            hi nadav,
            do you have any idea whan all of this will be merged to the official release ?

            omer

            Show
            omer added a comment - hi nadav, do you have any idea whan all of this will be merged to the official release ? omer
            Hide
            Nadav Kavalerchik added a comment -

            right align "print wiki page"

            Show
            Nadav Kavalerchik added a comment - right align "print wiki page"
            Hide
            Nadav Kavalerchik added a comment -

            updates (format listbox alignment, on various settings pages)

            Show
            Nadav Kavalerchik added a comment - updates (format listbox alignment, on various settings pages)
            Hide
            Nadav Kavalerchik added a comment -

            Hi Omer

            Not sure It's been a while...

            We wrote an email to Martin two weeks ago and we did not get any response.
            I will discuss a solution (tomorrow) with the Translation Team.
            We consider posting a special Moodle 2 release, until we get a response from Moodle HQ.

            Show
            Nadav Kavalerchik added a comment - Hi Omer Not sure It's been a while... We wrote an email to Martin two weeks ago and we did not get any response. I will discuss a solution (tomorrow) with the Translation Team. We consider posting a special Moodle 2 release, until we get a response from Moodle HQ.
            Hide
            omer added a comment -

            hi,
            due to many bugs in my currently installed version i have to upgrade al of my installations (over 70) to the latest release.

            wish it had included your fixes....

            :\

            Show
            omer added a comment - hi, due to many bugs in my currently installed version i have to upgrade al of my installations (over 70) to the latest release. wish it had included your fixes.... :\
            Hide
            Martin Dougiamas added a comment - - edited

            Thanks guys! Sorry about the long time since you had a response. Lots of things happening.

            Someone from the STABLE sprint team will review these, and produce some new rebased PULL requests for integration.

            Show
            Martin Dougiamas added a comment - - edited Thanks guys! Sorry about the long time since you had a response. Lots of things happening. Someone from the STABLE sprint team will review these, and produce some new rebased PULL requests for integration.
            Hide
            Sam Hemelryk added a comment -

            Hi Nadav,

            I've been through all your patches now, merged them into stable and dev, and have reviewed all of them.
            I've created two PULL requests to see your changes integrated PULL-663 and PULL-664.
            Providing these pass the weekly review they will be in the upcoming weekly releases.

            Most of your patches were spot on however I did alter several and there were a few that did not make it in.
            For future patches keen the following in mind:

            1. Don't make changes within 3rd party libs, we don't make any changes that arn't 100% required there as it always causing problems later on. Instead just make the required changes in the base/standard theme.
            2. We don't put any browser specific CSS into base unless we absolutely need to, this is things such as border radius and such.
            3. Try to avoid rules like select[name=*introeditor]. There is always a better way, in this case those format boxes were associated with the editor so .felement.feditor select worked fine.

            At this point I'll close this issue.
            If you produce any further patches please do share them with us but create a new issue. We've changed the way we inspect new bugs and if you create a new bug and attach a patch it will be looked at sooner, hopefully this will lead to your work being integrated quicker.

            One more thing, I made you the author of the changes so that you get credit within our git repository, I used the email address on your tracker profile I hope thats OK.

            Cheers
            Sam

            Show
            Sam Hemelryk added a comment - Hi Nadav, I've been through all your patches now, merged them into stable and dev, and have reviewed all of them. I've created two PULL requests to see your changes integrated PULL-663 and PULL-664. Providing these pass the weekly review they will be in the upcoming weekly releases. Most of your patches were spot on however I did alter several and there were a few that did not make it in. For future patches keen the following in mind: Don't make changes within 3rd party libs, we don't make any changes that arn't 100% required there as it always causing problems later on. Instead just make the required changes in the base/standard theme. We don't put any browser specific CSS into base unless we absolutely need to, this is things such as border radius and such. Try to avoid rules like select [name=*introeditor] . There is always a better way, in this case those format boxes were associated with the editor so .felement.feditor select worked fine. At this point I'll close this issue. If you produce any further patches please do share them with us but create a new issue. We've changed the way we inspect new bugs and if you create a new bug and attach a patch it will be looked at sooner, hopefully this will lead to your work being integrated quicker. One more thing, I made you the author of the changes so that you get credit within our git repository, I used the email address on your tracker profile I hope thats OK. Cheers Sam
            Hide
            Sam Hemelryk added a comment -

            Linked PULL-663 and PULL-664

            Show
            Sam Hemelryk added a comment - Linked PULL-663 and PULL-664
            Hide
            Nadav Kavalerchik added a comment -

            Hi Sam

            Thank you very much!

            I was really looking forward for those remarks you gave me,
            Since i was coding in the dark and was not sure what was the right
            strategic you guys prefer. especially when i got no response over time to my patches.

            So, thank you very much

            For the future...
            I am not sure i know where and how to open PULL request. (Can you link me to some info?)
            I do have some experience with projects i manage on Github and i work with git all the time.
            I even have all the changes we (the Moodle Hebrew Translation Team) make to Moodle 1.9.x
            on github (https://github.com/nadavkav/Moodle-RTL--Shenkar-Translation-Team-) and MDL-22952

            Thank you for making me the Auther, too.

            Show
            Nadav Kavalerchik added a comment - Hi Sam Thank you very much! I was really looking forward for those remarks you gave me, Since i was coding in the dark and was not sure what was the right strategic you guys prefer. especially when i got no response over time to my patches. So, thank you very much For the future... I am not sure i know where and how to open PULL request. (Can you link me to some info?) I do have some experience with projects i manage on Github and i work with git all the time. I even have all the changes we (the Moodle Hebrew Translation Team) make to Moodle 1.9.x on github ( https://github.com/nadavkav/Moodle-RTL--Shenkar-Translation-Team- ) and MDL-22952 Thank you for making me the Auther, too.
            Hide
            Sam Hemelryk added a comment -

            Hi Nadav,

            I wrote a docs page the other day about my development process when working on Moodle with Git.

            http://docs.moodle.org/en/User:Sam_Hemelryk/My_Moodle_Git_workflow

            Hopefully that will answer some of the questions that you have about PULL requests.
            If you have any doubts just ask on the MDL question (or within the PULL request if you have created one).

            Cheers
            Sam

            Show
            Sam Hemelryk added a comment - Hi Nadav, I wrote a docs page the other day about my development process when working on Moodle with Git. http://docs.moodle.org/en/User:Sam_Hemelryk/My_Moodle_Git_workflow Hopefully that will answer some of the questions that you have about PULL requests. If you have any doubts just ask on the MDL question (or within the PULL request if you have created one). Cheers Sam
            Hide
            Nadav Kavalerchik added a comment -

            Hi Sam

            That was very (very) helpful!
            Thank you

            Show
            Nadav Kavalerchik added a comment - Hi Sam That was very (very) helpful! Thank you

              People

              • Votes:
                2 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: